Page MenuHomePhabricator
Create Task
Maniphest T25653

USDevice cannot be edited/removed when its video source is an OIGTL Client
Closed, ResolvedPublic
Actions

Description

How to reproduce this bug:

  • Open Ultrasound Support-View in MITK
  • Click on "New Video Device"
  • Choose "OIGTL Client" as Video Source
  • Click on "Add Video Device"

Then in the main view of the Ultrasound Support-View: The buttons "Remove" and "Edit Video Device" are not enabled and cannot be clicked.

Related Objects

Event Timeline

mittmann triaged this task as Normal priority.Nov 14 2018, 2:06 PM
mittmann created this task.
mittmann claimed this task.Dec 5 2018, 4:05 PM
mittmann moved this task from Backlog to In Progress on the IGT board.
mittmann added a comment.Dec 5 2018, 4:10 PM

Pushed new branch T25653-USDeviceNotEditableWhenVideoSourceOIGTLClient.

mittmann added a comment.EditedDec 7 2018, 6:09 PM

Hint: I fixed this issue of editing/removing the USDevice in case of an OIGTL client or server within this task. However, there are some things that has to be fixed in other branches/tasks in the future: 1) I think the persistence of an IGTL-USDevice is not working correctly 2) Loading/saving an IGTL-USDevice configuration is still not supported. 3) All features of the USImageVideoSource such as cropping, region of interest etc. are not supported by the IGTLMessageToUSImageFilter, which is an USImageSource, as well. So, it might be a good idea, if the IGTLMessageToUSImageFilter supports these features in the future.

mittmann moved this task from In Progress to Ready for merge on the IGT board.Dec 7 2018, 6:12 PM
mittmann mentioned this in rMITK3c19d3a8c642: Merge branch 'T25653-USDeviceNotEditableWhenVideoSourceOIGTLClient' into T25522….Dec 7 2018, 6:15 PM
mittmann moved this task from Ready for merge to Finished on the IGT board.Dec 7 2018, 6:15 PM
mittmann closed this task as Resolved.Dec 12 2018, 1:26 PM
MITK · MIC · IMSY · DKFZ