Page MenuHomePhabricator

PropertyRelationRules: DataNodes are not transparent at ID layer -> problem when mixing data and data nodes.
Closed, ResolvedPublic

Description

Currently the ID layer connection between to BaseDatas is not correctly detected when passing the nodes of the basedata instances. On the data level of the rule it is no problem because there the node behaves transparent. It should work like that (transparent) also on the ID layer to give a consitent behavior.

Currently the best solution is to implement in the RuleBase a switch that checks if the destination is a DataNode. If this is the case the data should be checked for ID. Con: We build up an internal dependencies between RuleBase and DataNode. Pro: It is the best solution as it is an hidden implementation detail and other options would lead to changing of interfaces or so.

Todos:

  • implement the check/switch (see above)
  • extend the rule tests to check also if this case (relation between BaseData, but checked with the DataNode as source) is covered.

Revisions and Commits

rMITK MITK
Restricted Differential Revision