Page MenuHomePhabricator
Create Task
Maniphest T27969

Toggling "Show cross hair" in a render window menu does not update the check state in other render window menus
Closed, ResolvedPublic
Actions

Description

  • Uncheck "Show cross hair" in a render window menu
  • Open another render window menu
    • Still checked
    • Have to uncheck and check again to show the cross hair again

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITKaba3194febeb Update the check state in other render window menus
Restricted Differential RevisionrMITK4661bf2a5c6f Make function names consistent
Restricted Differential RevisionrMITK5da13409b6f3 Notify state change to all render windows

Related Objects

Event Timeline

kislinsk triaged this task as High priority.Nov 18 2020, 9:21 AM
kislinsk created this task.
kalali added a revision: Restricted Differential Revision.Nov 30 2020, 3:50 PM

This also happens for the rotation mode. The proposed changes fix both.

kalali claimed this task.Nov 30 2020, 3:51 PM
kalali added a commit: rMITK5da13409b6f3: Notify state change to all render windows.Nov 30 2020, 8:46 PM
kalali added a commit: rMITK4661bf2a5c6f: Make function names consistent.
kalali added a commit: rMITKaba3194febeb: Update the check state in other render window menus.
kalali closed this task as Resolved.Nov 30 2020, 8:46 PM
kislinsk added a comment.Dec 1 2020, 12:35 PM

As it is a public API change I suggest that you tag this task with Noteworthy and write a line about the breaking change or in case it is not trivial a short migration guide.

kalali added a project: Noteworthy.Dec 3 2020, 9:03 PM
NOTE: API change: LayoutDesignListChanged was renamed to UpdateLayoutDesignList for consistency with the newly added functions and for not to be confused with the Qt signals.
kislinsk mentioned this in T28126: 2020 Week 52 (Late December).Dec 21 2020, 5:16 AM
MITK · MIC · IMSY · DKFZ