Page MenuHomePhabricator

kalali (Amir Kalali)
Developer

Projects

User Details

User Since
Aug 1 2016, 12:10 PM (181 w, 3 d)

Recent Activity

Yesterday

kalali added a comment to T26694: [image statistics plugin] Add multithreading .

Modified this feature with respect to changes made in T26348. Also fixed the naming by using the UID of image and mask, that are currently processed by a QRunnable.

Thu, Jan 23, 6:45 PM · MITK
kalali added a comment to T27030: Building mitk installer on windows failed..

No found ZIP-folder / file was created, no installer was built - just the bin-folder with the .exe-file.

Thu, Jan 23, 4:21 PM · MITK
kalali updated subscribers of T22888: ImageStatistics Plugin: Model/View instead of TableWidget.

@floca Is this resolved / invalid? As far as I can see we now have a QmitkImageStatisticsTreeModel (NOT A TABLE MODEL).
I spotted some false namings, there seem to be some things mixed up (e.g. QmitkStatisticsModelToStringConverter speaks about a table model being converted, when actually a QmitkImageStatisticsTreeModel is used etc.).

Thu, Jan 23, 3:16 PM · MITK
kalali added a comment to T26269: [image statistics plugin] refactor to use new node selection widget.

The IgnoreZeroCheckBox needs to be implemented, enabling it should change all selected statistic data.

Thu, Jan 23, 2:56 PM · MITK
kalali updated the task description for T24775: Refactor plugins to use the new node selection widgets.
Thu, Jan 23, 2:54 PM · MITK
kalali added a comment to T24776: Refactor MatchPoint plugins to use the new node selection widgets.

So open plugins are: MatchPoint Mapper as far as I see?
MatchPoint Registration Batch Processing and MatchPoint Frame Correction do not need any node selection.

Thu, Jan 23, 2:53 PM · MITK
kalali added a revision to T27028: Add selection condition check for multi-node selection: Unknown Object (Differential Revision).
Thu, Jan 23, 1:39 PM · MITK
kalali triaged T27028: Add selection condition check for multi-node selection as Normal priority.
Thu, Jan 23, 1:33 PM · MITK
kalali updated the task description for T26741: Finishing new node selection concept.
Thu, Jan 23, 11:09 AM · Restricted Project

Wed, Jan 22

kalali updated subscribers of T19124: When selecting more than one measurement, statistics aren't calculated.

The new multi node selection functionality allows to select an image and multiple corresponding masks. However, this will compute the statistics for each mask individually.
From the description it is not clear what is requested here:

  1. compute the unified statistics of both masks
  2. compute two individual statistics, one for each mask respectively
Wed, Jan 22, 4:01 PM · Bugzilla, MITK

Tue, Jan 21

kalali added a project to T27019: Do not disable rendering tests on Linux by default: CI.
Tue, Jan 21, 3:43 PM · CI, Noteworthy, MITK

Mon, Jan 20

kalali committed rMITK6aa36ba9511c: Merge branch 'T26475-Remove-node-change-reaction' (authored by kalali).
Merge branch 'T26475-Remove-node-change-reaction'
Mon, Jan 20, 5:33 PM
kalali closed T26475: QmitkPropertyTreeView does not react on DICOM node changes as Resolved.
Mon, Jan 20, 5:33 PM · Restricted Project, MITK
kalali committed rMITK18039d0020ae: Remove name-property-observer to not react on name changes (authored by kalali).
Remove name-property-observer to not react on name changes
Mon, Jan 20, 5:31 PM
kalali added a comment to T26475: QmitkPropertyTreeView does not react on DICOM node changes.

Pushed new branch T26475-Remove-node-change-reaction.

Mon, Jan 20, 5:31 PM · Restricted Project, MITK
kalali closed T26998: Refactor Properties plugin to use the new node selection widgets as Resolved.
Mon, Jan 20, 3:48 PM · MITK
kalali closed T26998: Refactor Properties plugin to use the new node selection widgets, a subtask of T24775: Refactor plugins to use the new node selection widgets, as Resolved.
Mon, Jan 20, 3:48 PM · MITK
kalali updated the task description for T24775: Refactor plugins to use the new node selection widgets.
Mon, Jan 20, 3:48 PM · MITK
kalali committed rMITK86585d5917c7: Merge branch 'T26998-Properties-view-with-single-node-selection-widget' (authored by kalali).
Merge branch 'T26998-Properties-view-with-single-node-selection-widget'
Mon, Jan 20, 3:46 PM
kalali committed rMITK4ec12cda7899: Merge branch 'T27002-DICOM-inspector-view-with-single-node-selection-widget' (authored by kalali).
Merge branch 'T27002-DICOM-inspector-view-with-single-node-selection-widget'
Mon, Jan 20, 3:45 PM
kalali committed rMITK3f8115606192: Modernize and clean class (authored by kalali).
Modernize and clean class
Mon, Jan 20, 3:42 PM
kalali committed rMITKb82bf8b5268b: Fix gcc warning-as-error by using a different function name (authored by kalali).
Fix gcc warning-as-error by using a different function name
Mon, Jan 20, 3:42 PM
kalali committed rMITKbef7e116d21d: Add a single node selection widget (authored by kalali).
Add a single node selection widget
Mon, Jan 20, 3:42 PM
kalali added a comment to T26998: Refactor Properties plugin to use the new node selection widgets.

Pushed new branch T26998-Properties-view-with-single-node-selection-widget.

Mon, Jan 20, 3:41 PM · MITK
kalali updated the task description for T24775: Refactor plugins to use the new node selection widgets.
Mon, Jan 20, 2:14 PM · MITK
kalali closed T27002: Refactor DICOM inspector plugin to use the new node selection widgets as Resolved.
Mon, Jan 20, 2:14 PM · MITK
kalali closed T27002: Refactor DICOM inspector plugin to use the new node selection widgets, a subtask of T24775: Refactor plugins to use the new node selection widgets, as Resolved.
Mon, Jan 20, 2:14 PM · MITK
kalali committed rMITK94adc0ebd8e8: Add suggestions from D226 (authored by kalali).
Add suggestions from D226
Mon, Jan 20, 2:13 PM
kalali committed rMITKe9a988a5cb42: Modernize and clean class (authored by kalali).
Modernize and clean class
Mon, Jan 20, 2:13 PM
kalali committed rMITKe2b214a0eb5d: Add a single node selection widget (authored by kalali).
Add a single node selection widget
Mon, Jan 20, 2:13 PM
kalali added a comment to T27002: Refactor DICOM inspector plugin to use the new node selection widgets.

Pushed new branch T27002-DICOM-inspector-view-with-single-node-selection-widget.

Mon, Jan 20, 2:13 PM · MITK
kalali triaged T27016: Use OpenStack for our CI system as Normal priority.
Mon, Jan 20, 11:43 AM · Restricted Project, CI

Fri, Jan 17

kalali closed T26259: QmitkConvertToMultiLabelSegmentationAction only works once as Resolved.

Should work now with the fix of T26938. Please reopen, if this problem persists.

Fri, Jan 17, 12:43 PM · MITK
kalali accepted rMITK99804079e0a8: Add container for Type, LineStyle and Color.
Fri, Jan 17, 12:32 PM
kalali accepted rMITK61caf41dc62c: Add Function for returning index by string.
Fri, Jan 17, 12:32 PM
kalali accepted rMITK39cfb5c5df5e: Remove override.
Fri, Jan 17, 12:31 PM
kalali accepted rMITKcdda996996fd: Add Function to update existing data.
Fri, Jan 17, 12:31 PM
kalali accepted rMITKf98609dac0c1: Modify functions for GUI.
Fri, Jan 17, 12:31 PM
kalali accepted rMITKea1cf2ffd166: Add new function for adding data.
Fri, Jan 17, 12:30 PM
kalali accepted rMITK7aa0559a1250: Add function to update existing data.
Fri, Jan 17, 12:30 PM
kalali accepted rMITK2ef6a51b13de: Add emplace.
Fri, Jan 17, 12:29 PM
kalali accepted rMITK4fe5206d5ca9: Add chartExistance boolean to avoid #T26790.

Still an open issue: T26790

Fri, Jan 17, 12:29 PM
kalali accepted rMITKbe64b0e66a24: Re-add emplace functionality.
Fri, Jan 17, 12:28 PM
kalali accepted rMITK5bdfc4c4048e: Avoid repeated converting.
Fri, Jan 17, 12:27 PM
kalali accepted rMITK726b04a3e631: Refactor AddChartExampleData to avoid converting.
Fri, Jan 17, 12:27 PM
kalali accepted rMITK2bb676acf3f1: Remove unnecessary emplacements.
Fri, Jan 17, 12:26 PM
kalali accepted rMITKb6992664bb45: Remove emplacement for lineType & clarify naming of it.
Fri, Jan 17, 12:26 PM

Thu, Jan 16

kalali added a revision to T27002: Refactor DICOM inspector plugin to use the new node selection widgets: Unknown Object (Differential Revision).
Thu, Jan 16, 4:55 PM · MITK
kalali triaged T27002: Refactor DICOM inspector plugin to use the new node selection widgets as Normal priority.
Thu, Jan 16, 3:05 PM · MITK
kalali updated the task description for T26741: Finishing new node selection concept.
Thu, Jan 16, 3:01 PM · Restricted Project
kalali triaged T27001: Rename org.mitk.gui.qt.dicom to org.mitk.gui.qt.dicombrowser as Low priority.
Thu, Jan 16, 2:55 PM · Request for Discussion, MITK
kalali added a comment to T26475: QmitkPropertyTreeView does not react on DICOM node changes.

The topic is about the properties-view tab title. I was just looking into it and thinking if we can remove this functionality completely: We now have the selection widget which shows the currently selected node - no need to write the name of the selected node in the tab title.

Thu, Jan 16, 2:49 PM · Restricted Project, MITK
kalali merged task T27000: QmitkAbstractNodeSelectionWidget does not react to node changes into T26851: QmitkNodeSelectionButton does not refresh if node information changes.
Thu, Jan 16, 1:31 PM · MITK
kalali merged T27000: QmitkAbstractNodeSelectionWidget does not react to node changes into T26851: QmitkNodeSelectionButton does not refresh if node information changes.
Thu, Jan 16, 1:31 PM · MITK
kalali triaged T27000: QmitkAbstractNodeSelectionWidget does not react to node changes as Normal priority.
Thu, Jan 16, 1:25 PM · MITK
kalali added a comment to T26998: Refactor Properties plugin to use the new node selection widgets.

This task does not fix T26475 since the QmitkSingleSlotSelectionWidget does not react to node changes itself.

Thu, Jan 16, 1:12 PM · MITK
kalali closed T24659: Implement "Favorites" inspector, a subtask of T23751: Introduction of new selection concept, as Resolved.
Thu, Jan 16, 11:17 AM · MITK
kalali closed T24659: Implement "Favorites" inspector as Resolved.
Thu, Jan 16, 11:17 AM · MITK
kalali committed rMITKe1268d66cadd: Merge branch 'T24659-Implement-favorites-inspector' (authored by kalali).
Merge branch 'T24659-Implement-favorites-inspector'
Thu, Jan 16, 11:17 AM
kalali committed rMITK78ffa3d3aa42: Simplify logic (authored by kalali).
Simplify logic
Thu, Jan 16, 11:16 AM
kalali accepted rMITKfdfabc089f2d: Enalbe NodeChanged event trigger and pre-check if update is necessary.
Thu, Jan 16, 11:11 AM
kalali added inline comments to rMITKfdfabc089f2d: Enalbe NodeChanged event trigger and pre-check if update is necessary.
Thu, Jan 16, 11:11 AM

Wed, Jan 15

kalali added 1 auditor(s) for rMITKfdfabc089f2d: Enalbe NodeChanged event trigger and pre-check if update is necessary: floca.
Wed, Jan 15, 6:28 PM
kalali committed rMITKfdfabc089f2d: Enalbe NodeChanged event trigger and pre-check if update is necessary (authored by kalali).
Enalbe NodeChanged event trigger and pre-check if update is necessary
Wed, Jan 15, 6:27 PM
kalali committed rMITK0bb2c01d5b33: Revert changes for updating the view of the inspector manually (authored by kalali).
Revert changes for updating the view of the inspector manually
Wed, Jan 15, 6:27 PM
kalali committed rMITK1f4788e1aec5: Adapt button title to be more precise (authored by kalali).
Adapt button title to be more precise
Wed, Jan 15, 6:27 PM
kalali accepted rMITK13e7f96912aa: Add new inspector for favorite nodes.
Wed, Jan 15, 6:26 PM
kalali added inline comments to rMITK13e7f96912aa: Add new inspector for favorite nodes.
Wed, Jan 15, 6:26 PM
kalali claimed T26998: Refactor Properties plugin to use the new node selection widgets.
Wed, Jan 15, 5:17 PM · MITK
kalali renamed T26998: Refactor Properties plugin to use the new node selection widgets from Refactor Properties plugins to use the new node selection widgets to Refactor Properties plugin to use the new node selection widgets.
Wed, Jan 15, 5:11 PM · MITK
kalali added a revision to T26998: Refactor Properties plugin to use the new node selection widgets: Unknown Object (Differential Revision).
Wed, Jan 15, 5:11 PM · MITK
kalali triaged T26998: Refactor Properties plugin to use the new node selection widgets as Normal priority.
Wed, Jan 15, 5:02 PM · MITK
kalali committed rMITKedcb00699a6f: Merge branch 'T26958-MapToSource-in-level-window-preset-dialog' (authored by kalali).
Merge branch 'T26958-MapToSource-in-level-window-preset-dialog'
Wed, Jan 15, 12:04 PM
kalali committed rMITK713aa629ad7a: Fix T26958 (authored by kalali).
Fix T26958
Wed, Jan 15, 12:04 PM
kalali added a comment to T26958: LevelWindow Preset Dialog does not work correctly.

Pushed new branch T26958-MapToSource-in-level-window-preset-dialog.

Wed, Jan 15, 12:03 PM · MITK (2018-04-4)
kalali closed T26958: LevelWindow Preset Dialog does not work correctly as Resolved by committing rMITK713aa629ad7a: Fix T26958.
Wed, Jan 15, 12:03 PM · MITK (2018-04-4)
kalali updated the task description for T26958: LevelWindow Preset Dialog does not work correctly.
Wed, Jan 15, 11:55 AM · MITK (2018-04-4)
kalali added inline comments to rMITK13e7f96912aa: Add new inspector for favorite nodes.
Wed, Jan 15, 11:48 AM

Tue, Jan 14

kalali added 1 auditor(s) for rMITK13e7f96912aa: Add new inspector for favorite nodes: floca.
Tue, Jan 14, 6:59 PM
kalali added a comment to rMITK13e7f96912aa: Add new inspector for favorite nodes.

Some remarks as written in T24659#191634

Tue, Jan 14, 6:57 PM
kalali added a comment to T24659: Implement "Favorites" inspector.

Everything works now but I'm not 100% convinced that this is the best way to do it. Will add some remarks in a review.

Tue, Jan 14, 6:42 PM · MITK
kalali committed rMITKd4170f5dbca9: Do some code cleaning (authored by kalali).
Do some code cleaning
Tue, Jan 14, 6:41 PM
kalali committed rMITK13e7f96912aa: Add new inspector for favorite nodes (authored by kalali).
Add new inspector for favorite nodes
Tue, Jan 14, 6:41 PM
kalali added a comment to T24659: Implement "Favorites" inspector.

Pushed new branch T24659-Implement-favorites-inspector.

Tue, Jan 14, 6:40 PM · MITK
kalali updated the task description for T24659: Implement "Favorites" inspector.
Tue, Jan 14, 6:34 PM · MITK
kalali added a comment to T24659: Implement "Favorites" inspector.

Added a class that inherits from QmitkDataStorageListInspector to keep it simple. Favorites are filtered by adding a custom predicate that checks for the suggested org.mitk.selection.favorite-property. This property will be set inside a QmitkNodeSelectionDialog using a third dialog-button.
The inspector can be added to the dialog-button using the preferences-page for the selection concept.

Tue, Jan 14, 12:39 PM · MITK

Mon, Jan 13

kalali added a project to T26962: Improve dynamic analysis and test coverage reporting: CI.
Mon, Jan 13, 12:49 PM · CI, MITK
kalali renamed T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification from [Checklist] LevelWindow checklist does not provide explicit expected results for suifficient verification to [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification .
Mon, Jan 13, 12:45 PM · Request for Discussion, Restricted Project, MITK
kalali claimed T24659: Implement "Favorites" inspector.
Mon, Jan 13, 12:44 PM · MITK
kalali updated the task description for T26754: Review checklists.
Mon, Jan 13, 12:38 PM · Request for Discussion, Restricted Project, MITK

Fri, Jan 10

kalali edited projects for T26754: Review checklists, added: Restricted Project, Request for Discussion; removed Restricted Project.
Fri, Jan 10, 11:43 AM · Request for Discussion, Restricted Project, MITK

Thu, Jan 9

kalali reopened T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry as "Open".

What happened here? The suggested code is not merged, so this task cannot be resolved.
However, the suggested code is just a revert of the fix I made for T24766 (except for the =, but I tested this in October and it leads to a crash as far as I remember).

Thu, Jan 9, 4:13 PM · Request for Discussion, Restricted Project, MITK (2018-04-4)

Tue, Jan 7

kalali updated the task description for T26754: Review checklists.
Tue, Jan 7, 5:39 PM · Request for Discussion, Restricted Project, MITK
kalali triaged T26959: Newly created LabelSet segmentation is not displayed as "outline binary" as Normal priority.
Tue, Jan 7, 4:47 PM · MITK (2018-04-4)
kalali created T26959: Newly created LabelSet segmentation is not displayed as "outline binary".
Tue, Jan 7, 4:47 PM · MITK (2018-04-4)
kalali triaged T26958: LevelWindow Preset Dialog does not work correctly as Normal priority.
Tue, Jan 7, 3:35 PM · MITK (2018-04-4)
kalali updated the task description for T26754: Review checklists.
Tue, Jan 7, 2:43 PM · Request for Discussion, Restricted Project, MITK
kalali triaged T26957: LevelWindow context menu entries change default level-window as Normal priority.
Tue, Jan 7, 1:50 PM · MITK (2018-04-4), Restricted Project
kalali created T26957: LevelWindow context menu entries change default level-window.
Tue, Jan 7, 1:49 PM · MITK (2018-04-4), Restricted Project
kalali triaged T26956: LevelWindow slider does not expand the level/window scale as Normal priority.
Tue, Jan 7, 12:57 PM · MITK (2018-04-4)