Page MenuHomePhabricator | MITK

kalali (Amir Kalali)
Developer

Projects

User Details

User Since
Aug 1 2016, 12:10 PM (150 w, 1 d)

Recent Activity

Yesterday

kalali triaged T26410: Create new, theme-aware icon for RenderWindowManager as Normal priority.
Tue, Jun 18, 1:26 PM · Restricted Project, MITK
kalali triaged T26409: Create new, theme-aware icon for SemanticRelations as Normal priority.
Tue, Jun 18, 1:25 PM · Restricted Project, MITK

Mon, Jun 17

kalali placed T26376: Segmentation plugin does not work correctly with the new mxn multi widget up for grabs.
Mon, Jun 17, 12:44 PM · Request for Discussion, MITK

Fri, Jun 14

kalali closed T26395: Overhaul multi widget layout selection widget as Resolved.
Fri, Jun 14, 4:05 PM · MITK
kalali placed T25753: Some refactoring of the selection classes up for grabs.
Fri, Jun 14, 4:02 PM · MITK
kalali placed T25804: Set 'selected' property when using the new selection concept up for grabs.
Fri, Jun 14, 4:02 PM · MITK
kalali placed T24771: Add a concept documentation for the data storage inspectors and the overhaul of the selection concept up for grabs.
Fri, Jun 14, 4:02 PM · MITK
kalali placed T23751: Introduction of new selection concept up for grabs.
Fri, Jun 14, 4:01 PM · MITK
kalali committed rMITKcba07a80dc9b: Merge branch 'T26394-Render-window-manager-tree-view' into T22946-Integration… (authored by kalali).
Merge branch 'T26394-Render-window-manager-tree-view' into T22946-Integration…
Fri, Jun 14, 2:37 PM
kalali placed T26394: Provide tree view / model for the render window manager up for grabs.

Removing a node on 1. level with child nodes is not correctly reflected in the currently selected render specific tree. The tree model is updated with all data nodes of the data storage before the remove-process is finished so the data storage still contains the to-be-removed- data node.
If this also happens in the QmitkDataStorageSimpleTreeModel needs to be investigated.

Fri, Jun 14, 12:20 PM · Restricted Project, MITK
kalali committed rMITK5a7c85698b70: Modify and extend the tree model (authored by kalali).
Modify and extend the tree model
Fri, Jun 14, 12:20 PM
kalali committed rMITKf60c5f065d53: Add tree model in exchange for list model (authored by kalali).
Add tree model in exchange for list model
Fri, Jun 14, 12:20 PM
kalali committed rMITK30536f2bc3a0: Add function to initialize specific render window properties (authored by kalali).
Add function to initialize specific render window properties
Fri, Jun 14, 12:20 PM
kalali added a comment to T26394: Provide tree view / model for the render window manager.

Pushed new branch T26394-Render-window-manager-tree-view.

Fri, Jun 14, 12:20 PM · Restricted Project, MITK

Thu, Jun 13

kalali claimed T26394: Provide tree view / model for the render window manager.
Thu, Jun 13, 1:03 PM · Restricted Project, MITK

Wed, Jun 12

kalali added a comment to T26399: Workbench crash on simple tree model update.

Possible solutions:

  1. Add
if (!parentItem)
    return QModelIndex();

to QModelIndex QmitkDataStorageSimpleTreeModel::parent(const QModelIndex &child) const

  1. Remove
if (m_Root)
{
  m_Root->Delete();
}

from void QmitkDataStorageSimpleTreeModel::DataStorageChanged(). This will lead to unreferenced pointers so I suggest to work with smart pointers (for this QmitkDataStorageTreeModelInternalItem needs to be modified).

Wed, Jun 12, 4:19 PM · Request for Discussion, MITK
kalali triaged T26399: Workbench crash on simple tree model update as Normal priority.
Wed, Jun 12, 4:06 PM · Request for Discussion, MITK
kalali committed rMITK9ffd4fcef43c: Make empty place holder pixmap transparent (authored by kalali).
Make empty place holder pixmap transparent
Wed, Jun 12, 11:33 AM
kalali committed rMITKf26bedaa00b3: Change string to denote lesion presence (authored by kalali).
Change string to denote lesion presence
Wed, Jun 12, 11:33 AM
kalali committed rMITK6d42f82f3e90: Use context menu entry to create and link new segmentation (authored by kalali).
Use context menu entry to create and link new segmentation
Wed, Jun 12, 11:33 AM
kalali committed rMITK5c8a46bc23e1: Merge branch 'T26395-Overhaul-layout-selection-widget' into T22946-Integration… (authored by kalali).
Merge branch 'T26395-Overhaul-layout-selection-widget' into T22946-Integration…
Wed, Jun 12, 11:33 AM

Tue, Jun 11

kalali created T26396: Refactor functions to create new (empty) segmentations.
Tue, Jun 11, 3:05 PM · Restricted Project, Request for Discussion, MITK
kalali committed rMITKdc28f9189cdd: Remove surplus table columns (authored by kalali).
Remove surplus table columns
Tue, Jun 11, 12:19 PM
kalali committed rMITKb1dbe1696724: Use white cell color to make the cells visible in dark theme mode (authored by kalali).
Use white cell color to make the cells visible in dark theme mode
Tue, Jun 11, 12:19 PM
kalali committed rMITK1e0e1f706cd3: Move layout selection popup to the left so that it is fully visible (authored by kalali).
Move layout selection popup to the left so that it is fully visible
Tue, Jun 11, 12:19 PM
kalali committed rMITKe6b796743dfb: Fill empty cells with place holder pixmap (authored by kalali).
Fill empty cells with place holder pixmap
Tue, Jun 11, 12:19 PM
kalali added a comment to T26395: Overhaul multi widget layout selection widget.

Pushed new branch T26395-Overhaul-layout-selection-widget.

Tue, Jun 11, 12:18 PM · MITK
kalali triaged T26395: Overhaul multi widget layout selection widget as Normal priority.
Tue, Jun 11, 12:13 PM · MITK

Fri, Jun 7

kalali triaged T26394: Provide tree view / model for the render window manager as Normal priority.
Fri, Jun 7, 5:24 PM · Restricted Project, MITK
kalali committed rMITK957828cc8540: Cross-hair rotation does not work anymore (authored by kalali).
Cross-hair rotation does not work anymore
Fri, Jun 7, 2:08 PM

Wed, Jun 5

kalali committed rMITK0306c69d63cd: Refactor semantic relations actions (authored by kalali).
Refactor semantic relations actions
Wed, Jun 5, 2:03 PM
kalali committed rMITKe92366c5395b: Remove messages from actions and use rethrow; added function description (authored by kalali).
Remove messages from actions and use rethrow; added function description
Wed, Jun 5, 2:03 PM

Tue, Jun 4

kalali committed rMITKc6069d1f64ca: Merge branch 'T26376-Remove-specific-render-windows-from-segmentation-plugin'… (authored by kalali).
Merge branch 'T26376-Remove-specific-render-windows-from-segmentation-plugin'…
Tue, Jun 4, 6:33 PM
kalali committed rMITK4f47d770e31f: Check if currently active render window part has a 3d render window (authored by kalali).
Check if currently active render window part has a 3d render window
Tue, Jun 4, 6:32 PM
kalali committed rMITKddec6738bbb0: Remove specific render windows (authored by kalali).
Remove specific render windows
Tue, Jun 4, 6:32 PM
kalali committed rMITK1959adec442a: Merge branch 'T26376-Set-active-render-window' into T25767-BlackSwan-release (authored by kalali).
Merge branch 'T26376-Set-active-render-window' into T25767-BlackSwan-release
Tue, Jun 4, 6:32 PM
kalali committed rMITK76ecef0ef166: Control all render windows of the active render window part (authored by kalali).
Control all render windows of the active render window part
Tue, Jun 4, 6:32 PM
kalali added a comment to T26376: Segmentation plugin does not work correctly with the new mxn multi widget.

Pushed new branch T26376-Remove-specific-render-windows-from-segmentation-plugin.

Tue, Jun 4, 6:32 PM · Request for Discussion, MITK
kalali committed rMITKd86d88367d31: Allow setting the currently active render window of a render window part (authored by kalali).
Allow setting the currently active render window of a render window part
Tue, Jun 4, 6:31 PM
kalali committed rMITK9d24a346df04: Install regiongrowing plugin (authored by kalali).
Install regiongrowing plugin
Tue, Jun 4, 6:31 PM
kalali added a comment to T26376: Segmentation plugin does not work correctly with the new mxn multi widget.

Pushed new branch T26376-Set-active-render-window.

Tue, Jun 4, 6:30 PM · Request for Discussion, MITK
kalali triaged T26381: QmitkDataStorageComboBox does not react on node changes as Normal priority.
Tue, Jun 4, 6:04 PM · Restricted Project, MITK
kalali added a comment to T26376: Segmentation plugin does not work correctly with the new mxn multi widget.

The plugin always shows the message "Please perform a reinit on the segmentation image!", when the active render window is not an axial render window, though. In that case, both world geometries (working node and current geometry of active render window) are not equal.

Tue, Jun 4, 11:35 AM · Request for Discussion, MITK
kalali added a comment to T26376: Segmentation plugin does not work correctly with the new mxn multi widget.

Reinit did not work correctly, as the RenderingManagerViewsInitializedEvent was not send for a single view initialization.
In case of a specified base render (using the RenderWindowManager context menu), reinit will only initialize the specified render window. This will now also send the mentioned event so that the segmentation plugin can react to this event as it would if all render windows would have been initialized.

Tue, Jun 4, 11:34 AM · Request for Discussion, MITK
kalali claimed T26376: Segmentation plugin does not work correctly with the new mxn multi widget.
Tue, Jun 4, 11:32 AM · Request for Discussion, MITK

Mon, Jun 3

kalali added a comment to T26376: Segmentation plugin does not work correctly with the new mxn multi widget.

An active render window will now be set by using the RenderWindowManager.
The plugin always shows the message "Please perform a reinit on the segmentation image!", when the active render window is not an axial render window, though. In that case, both world geometries are not equal.

Mon, Jun 3, 6:38 PM · Request for Discussion, MITK
kalali lowered the priority of T26376: Segmentation plugin does not work correctly with the new mxn multi widget from High to Normal.

This was fixed for T25767. Need to look closer and test if everything works as expected.
The idea is not to ask for specific render windows but to retrieve all available render windows of a multi widget and use them.

Mon, Jun 3, 5:06 PM · Request for Discussion, MITK
kalali committed rMITKb0c92cb212b6: Add crosshair moving to change plane orientation (authored by kalali).
Add crosshair moving to change plane orientation
Mon, Jun 3, 3:26 PM
kalali triaged T26376: Segmentation plugin does not work correctly with the new mxn multi widget as High priority.
Mon, Jun 3, 1:55 PM · Request for Discussion, MITK
kalali committed rMITK97f4bc5189b6: Check for invalid last segmentation (authored by kalali).
Check for invalid last segmentation
Mon, Jun 3, 12:15 PM
kalali updated subscribers of T25535: DCMTK won't build if Anaconda is installed.

I can't think of any reason. I just stumbled upon this and suggested the fix. Since I have no experience with Anaconda or DCMTK I wasn't sure if this is the correct way to fix it or if there are any side effects. Maybe a review would have been a good idea. Maybe @nolden can help?

Mon, Jun 3, 11:12 AM · MITK
kalali added a comment to T19683: "Show only selected node" changes the visibility of crosshair.

QmitkDataNodeShowSelectedNodesAction.cpp and QmitkDataNodeShowSelectedNodesAction2.cpp in Plugins/org.mitk.gui.qt.application/src/

Mon, Jun 3, 11:04 AM · Bugzilla, Pull Request, MITK

Wed, May 29

kalali committed rMITK77f93ce4db27: Check for invalid last segmentation (authored by kalali).
Check for invalid last segmentation
Wed, May 29, 4:42 PM
kalali committed rMITK023be0d87f70: Merge branch 'T22946-Integration-beta' into T25767-BlackSwan-release (authored by kalali).
Merge branch 'T22946-Integration-beta' into T25767-BlackSwan-release
Wed, May 29, 4:42 PM
kalali committed rMITK341c72e4a585: Merge remote-tracking branch 'origin/T25772-integrate-bone-seg-in-mitk' into… (authored by kalali).
Merge remote-tracking branch 'origin/T25772-integrate-bone-seg-in-mitk' into…
Wed, May 29, 4:42 PM
kalali committed rMITK9d7fa17b2e3f: Clean and refactor bone segmentation classes (authored by kalali).
Clean and refactor bone segmentation classes
Wed, May 29, 4:42 PM
kalali committed rMITK79d4ceb65399: Add combo box for data node selection and clean classes (authored by kalali).
Add combo box for data node selection and clean classes
Wed, May 29, 4:42 PM
kalali committed rMITK7cd31261b50c: Use the semantic relations inside the region growing plugin (authored by kalali).
Use the semantic relations inside the region growing plugin
Wed, May 29, 4:42 PM
kalali committed rMITK71fe61c6aeb0: Move add-action and make it available inside the region growing plugin (authored by kalali).
Move add-action and make it available inside the region growing plugin
Wed, May 29, 4:42 PM
kalali committed rMITKf96607d3fd05: Clean and refactor region growing classes (authored by kalali).
Clean and refactor region growing classes
Wed, May 29, 4:42 PM
kalali committed rMITK4dabae6bd007: Merge remote-tracking branch 'origin/T22346-point-set-tool-and-region-growing'… (authored by kalali).
Merge remote-tracking branch 'origin/T22346-point-set-tool-and-region-growing'…
Wed, May 29, 4:42 PM

Tue, May 28

kalali committed rMITK8a9a91e8af46: Use RelationStorage inside the control point manager. (authored by kalali).
Use RelationStorage inside the control point manager.
Tue, May 28, 4:15 PM
kalali committed rMITKffc679b70219: Clean classes (authored by kalali).
Clean classes
Tue, May 28, 4:15 PM
kalali committed rMITK80d994fdf88c: Merge branch 'T25292-Multi-pixmap-patient-table-inspector' into T22946… (authored by kalali).
Merge branch 'T25292-Multi-pixmap-patient-table-inspector' into T22946…
Tue, May 28, 4:15 PM
kalali committed rMITKa59b8a842627: Overwrite existing images when using the context menu (set control point /… (authored by kalali).
Overwrite existing images when using the context menu (set control point /…
Tue, May 28, 4:15 PM
kalali committed rMITK9abbcbe66574: Only show examination periods without date (authored by kalali).
Only show examination periods without date
Tue, May 28, 4:14 PM
kalali committed rMITKdbaca8cfe10f: Allow user input to overwrite existing image at patient table cell (authored by kalali).
Allow user input to overwrite existing image at patient table cell
Tue, May 28, 4:14 PM
kalali committed rMITKb29cf8b0017f: Merge branch 'T23606-Lesion-volume-matrix' into T22946-Integration-beta (authored by kalali).
Merge branch 'T23606-Lesion-volume-matrix' into T22946-Integration-beta
Tue, May 28, 4:14 PM
kalali committed rMITKc109d46d2c94: Allow renaming examination periods (authored by kalali).
Allow renaming examination periods
Tue, May 28, 4:14 PM
kalali closed T26270: Update MatchPoint third party file as Resolved.
Tue, May 28, 11:42 AM · MITK
kalali added a comment to T19683: "Show only selected node" changes the visibility of crosshair.

Why are there now 2 actions? Did we miss some side effects with the base renderer?

Tue, May 28, 11:21 AM · Bugzilla, Pull Request, MITK

May 10 2019

kalali committed rMITK07bd2d71d29b: Update to latest Matchpoint version (authored by kalali).
Update to latest Matchpoint version
May 10 2019, 1:50 PM
kalali committed rMITK333ef2228793: Update to latest Matchpoint version (authored by kalali).
Update to latest Matchpoint version
May 10 2019, 1:50 PM
kalali added a revision to T26270: Update MatchPoint third party file: Unknown Object (Differential Revision).
May 10 2019, 1:48 PM · MITK

May 3 2019

kalali closed T22878: Level window slider only affects the topmost visible node in the data manager, a subtask of T25603: Combine render window manager with custom multi widget, as Invalid.
May 3 2019, 11:37 AM · Restricted Project, MITK
kalali closed T22878: Level window slider only affects the topmost visible node in the data manager as Invalid.

This task is not valid anymore.

  1. The level window slider has an option to modify the level window of a (list of) selected node(s) (see T25483)
  2. The BlackSwan project uses the PACS mode where the level window can be changed via mouse buttons
  3. The render window manager now uses the concept of data storage inspectors and thus behaves differently than here
May 3 2019, 11:37 AM · Restricted Project, MITK

May 2 2019

kalali committed rMITK4f08aea29b78: Revert latest update of the MatchPoint third party file (authored by kalali).
Revert latest update of the MatchPoint third party file
May 2 2019, 12:11 PM
kalali committed rMITKeeace5c321bd: Revert latest update of the MatchPoint third party file (authored by kalali).
Revert latest update of the MatchPoint third party file
May 2 2019, 12:11 PM
kalali added inline comments to rMITK750daa0b6d2b: Fixed crash for single time step segmentations.
May 2 2019, 12:10 PM
kalali added a revision to T26270: Update MatchPoint third party file: Unknown Object (Differential Revision).
May 2 2019, 11:24 AM · MITK

Apr 30 2019

kalali committed rMITK0bfb16968973: Add comments and clean classes (authored by kalali).
Add comments and clean classes
Apr 30 2019, 2:29 PM
kalali committed rMITK9344fadd0e8b: Compute statistics with the help of the image statistics ui module. (authored by kalali).
Compute statistics with the help of the image statistics ui module.
Apr 30 2019, 2:29 PM
kalali committed rMITKda01cc8a8c3c: Remove lesion volume computation from the lesion manager (authored by kalali).
Remove lesion volume computation from the lesion manager
Apr 30 2019, 2:29 PM
kalali added a revision to T26270: Update MatchPoint third party file: Unknown Object (Differential Revision).
Apr 30 2019, 2:26 PM · MITK
kalali committed rMITK91cded52abe4: Revert latest changes (authored by kalali).
Revert latest changes
Apr 30 2019, 2:26 PM
kalali reopened T26270: Update MatchPoint third party file as "Open".

Reopened to revert the latest changed due to errors.

Apr 30 2019, 2:20 PM · MITK
kalali closed T26270: Update MatchPoint third party file as Resolved.
Apr 30 2019, 1:41 PM · MITK
kalali committed rMITKa9b9c6c7d295: Remove local url (authored by kalali).
Remove local url
Apr 30 2019, 1:37 PM
kalali committed rMITK94f0e04f81db: Update MatchPoint third party file to include recent changes and bug fixes. (authored by kalali).
Update MatchPoint third party file to include recent changes and bug fixes.
Apr 30 2019, 1:37 PM
kalali committed rMITKab3fbc95cffd: Update MatchPoint third party file to include recent changes and bug fixes. (authored by kalali).
Update MatchPoint third party file to include recent changes and bug fixes.
Apr 30 2019, 1:37 PM
kalali added a revision to T26270: Update MatchPoint third party file: Unknown Object (Differential Revision).
Apr 30 2019, 10:34 AM · MITK
kalali committed rMITK0b251023c917: Update new version of MatchPoint (authored by kalali).
Update new version of MatchPoint
Apr 30 2019, 10:30 AM

Apr 26 2019

kalali committed rMITKddd8db08e2bc: Extend semantic relations functions (authored by kalali).
Extend semantic relations functions
Apr 26 2019, 7:52 PM
kalali committed rMITKc5b320323fbe: First approach for mask volume computation (authored by kalali).
First approach for mask volume computation
Apr 26 2019, 7:52 PM
kalali committed rMITK0c882afdc8de: Add model-view classes for statistics tree (authored by kalali).
Add model-view classes for statistics tree
Apr 26 2019, 7:52 PM
kalali committed rMITK605229d139d8: Simplify and remove update functions (authored by kalali).
Simplify and remove update functions
Apr 26 2019, 7:52 PM
kalali committed rMITKa6da3290eca4: Merge branch 'T25294-Suggest-last-added-segmentation' into T22946-Integration… (authored by kalali).
Merge branch 'T25294-Suggest-last-added-segmentation' into T22946-Integration…
Apr 26 2019, 7:52 PM
kalali committed rMITKd5d58b01ced6: Remove empty destructors (authored by kalali).
Remove empty destructors
Apr 26 2019, 7:51 PM
kalali added a comment to T19683: "Show only selected node" changes the visibility of crosshair.

Would be good to leave the baseRenderer as an argument so that you can set the visibility of a specific node in a predefined base renderer (e.g. by using the RenderWindowManager). This is useful when using the new MultiWidget(Editor).

Apr 26 2019, 5:43 PM · Bugzilla, Pull Request, MITK

Apr 23 2019

kalali committed rMITK6100739c8144: Store last added segmentation node and use it as a suggestion for a newly added… (authored by kalali).
Store last added segmentation node and use it as a suggestion for a newly added…
Apr 23 2019, 1:15 PM