- User Since
- Aug 1 2016, 12:10 PM (205 w, 10 h)
Fri, Jul 3
Result of the discussion:
We will "activate auto selection" mode as default. The user has to select a node anyway. Either the selection slot is empty or already contains an automatically selected node. In both cases the user has to manually select a node. But in the latter case there might be a chance that the automatically selected node is the required one.
Thu, Jul 2
see comment in D338
I tested this with Pic3D and can not reproduce this bug:
Can not be reproduced.
Tue, Jun 30
Mon, Jun 29
Image statistics are now correctly cached to prevent recalculation for the same image (-mask pair).
The UI of the histogram has been improved and is now theme-aware.
Fri, Jun 26
In the description it says:
MITK User Manual --> MITK Plugin Manuals --> Statistics Plugin
Will be continued in T27097: [MITKDoc] Revise Statistics Plugin Documentation.
Thu, Jun 25
Seems to be resolved because D329 changed
// In case the time is not valid use 0 to access the time geometry of the working node unsigned int time_position = 0; if (m_LastSNC->GetTime() != nullptr) time_position = m_LastSNC->GetTime()->GetPos();
Yes. I think this is more related to your other discussion in T26974: "What to do with a 3D segmentation of a 4D image."
Wed, Jun 24
The QmitkNodeSelectionDialog is the main widget to be used in order to select data nodes from the data storage. It is a pop-up-dialog that can be included in any other widget, such as the QmitkSingleNodeSelectionWidget or the QmitkMultiNodeSelectionWidget. It uses a tab widget that holds different data storage inspectors. A data storage inspector shows the (possibly filtered) data nodes of the data storage and allows to select one or more nodes. The selection can be accepted inside the node selection dialog and will be send to the including widget (i.e. the single node selection widget).
Tue, Jun 23
Has been solved in D328
Mon, Jun 22
- The following functions inside the QmitkStdMultiWidget have been removed
Sat, Jun 20
New documentation has been reviewed by André, next step would be to have it reviewed by a non-MITK developer (MITK Workbench user). This could probably happen during a release phase / checklist session.
Thank you for your response and for pointing out the redundancy, I will fix this next week.
Fri, Jun 19
I fixed the tutorial accordingly and close this task as resolved. If you still have problems, don't hesitate to reopen this task.
Thu, Jun 18
Tue, Jun 16
I can reproduce the error. There was a change in the StdMultiWidget so we have to adapt the tutorial. A specific initialization-method was added, so we need to call InitializeMultiWidget before accessing the render windows (which does some things for us so we can remove some lines from the tutorial).
The level window slider was removed from the StdMultiWidget and needs to be added additionally.
Mon, Jun 15
Fri, Jun 12
We could add a check in QmitkSlicesInterpolator::SetCurrentContourListID()
A static mask is generated in QmitkSegmentationView::CreateNewSegmentation() with
const auto refTimeGeometry = image->GetTimeGeometry(); auto newTimeGeometry = mitk::ProportionalTimeGeometry::New(); newTimeGeometry->SetFirstTimePoint(refTimeGeometry->GetMinimumTimePoint()); newTimeGeometry->SetStepDuration(refTimeGeometry->GetMaximumTimePoint() - refTimeGeometry->GetMinimumTimePoint());
mitk::ProportionalTimeGeometry::GetGeometryForTimeStep returns nullptr during
mitk::Vector3D spacing = workingNode->GetData()->GetGeometry(time_position)->GetSpacing() inside QmitkSlicesInterpolator::SetCurrentContourListID().
Obviously because IsValidTimeStep(timeStep)) for e.g. timestep = 2 is false.
Can T14333: Improve mitk::UIDGenerator be closed?
Wed, Jun 10
May 28 2020
Closed now but might be related to T27085.
Some things may have changed. So If I have time during the next 4 weeks I would like to give it a second look, finish the clean-up and merge / close this branch.
May 8 2020
I tried to reproduce it. I can verify Step 1 with the MITK Multilabel Image reader but if I use the ITK NrrdImageIO reader there is no option to use autocrop.
Could it be that there is something wrong with T26840-MitkHomepageReorganization-TopLevel? I created a branch based on it and a review a while ago and the CI system detected compile errors (can't see the error message). But now @kleina has some errors building the diff-branch because of the Pharmacokinetics-Module and the mitkConcentrationCurveGenerator using Ubuntu (probably gcc, which is why did not experience this error). I think 3d5e49433c92 is missing in the TopLevel-branch which @floca added but it was never included in the mentioned branch.
I don't know if that's a good thing 😈
Hm, yeah I guess that was our original problem, mentioned in the referenced task. So it might be that we never did it right because we could never really inspect the behavior sadface
Ok thanks, then I would like to test the data with an old installer (e.g. 2016) to see if we ever did it correctly.
I tested this and I can confirm that the segmentation-node will be deselected but the parent node stays selected in my case!
I just ran into this error (on Windows) unexpectedly by doing the following:
- load ImageStatistics/testimage.dcm
- remove the image node
- load Pic3D
- -> Error in PlaneGeometry::CheckBounds(const BoundingBox::BoundsArrayType &bounds)
May 7 2020
mitk::ExtractSliceFilter::GenerateOutputInformation() generates the bounds of the itk object. There are some values that need to be inspected:
xMin = 0 xMax = 512 yMin = 0 yMax = 0
// currently the unit rectangle must be starting at the origin [0,0] assert(bounds == 0); assert(bounds == 0); // the unit rectangle must be two-dimensional assert(bounds > 0); assert(bounds > 0);
in PlaneGeometry::CheckBounds(const BoundingBox::BoundsArrayType &bounds) fails.
I just found out the following:
- perform both steps as written in the description
- change the layer of one of the two segmentations such that one segmentation is on the same layer as the parent node (the other segmentation should still have a layer above the parent node),
ParentNode: Layer 4 Segmentation1: Layer 5 Segmentation2: Layer 7
ParentNode: Layer 4 Segmentation1: Layer 5 Segmentation2: Layer 4
- see how both segmentations are visible with overlapping area
@floca Any progress here? This also happened often with real data from partners and is really annoying because the error message is somewhat unspecific.
I would also like to see this fixed for MITK 2020.
May 6 2020
May 5 2020
For MITK 2020 I would remove them since it doesn't seem feasible with time constraints (so change task to wishlist and change title to implement interpolation).
Is there some rough estimate when this bug was introduced?