Page MenuHomePhabricator

kalali (Amir Kalali)
Developer

Projects (7)

User Details

User Since
Aug 1 2016, 12:10 PM (216 w, 3 d)

Recent Activity

Wed, Sep 23

kalali closed T27659: Refactor BasicImageProcessing plugin to use the new node selection widgets as Resolved.
Wed, Sep 23, 3:06 PM · MITK, Cleared
kalali closed T27659: Refactor BasicImageProcessing plugin to use the new node selection widgets, a subtask of T24775: Refactor plugins to use the new node selection widgets, as Resolved.
Wed, Sep 23, 3:06 PM · MITK, Restricted Project, Cleared
kalali committed rMITK37cb6b019f24: Refactor BasicImageProcessing plugin to use the new node selection widgets (authored by kalali).
Refactor BasicImageProcessing plugin to use the new node selection widgets
Wed, Sep 23, 3:04 PM
kalali committed rMITKc62c87720cd3: Correct combo box information string (authored by kalali).
Correct combo box information string
Wed, Sep 23, 3:04 PM
kalali committed rMITKad3b729fbec7: Use different signal-slot connection syntax (authored by kalali).
Use different signal-slot connection syntax
Wed, Sep 23, 3:04 PM
kalali committed rMITKa3af275fcd47: Use new Qt5 signal-slot syntax (authored by kalali).
Use new Qt5 signal-slot syntax
Wed, Sep 23, 3:04 PM
kalali committed rMITK3a674ca1e74d: Use smart pointer explicitly (authored by kalali).
Use smart pointer explicitly
Wed, Sep 23, 3:04 PM
kalali committed rMITK1ce667e7d8c1: Add single node selection widgets (authored by kalali).
Add single node selection widgets
Wed, Sep 23, 3:04 PM
kalali committed rMITK12a990bdeb32: Remove dead functions (authored by kalali).
Remove dead functions
Wed, Sep 23, 3:04 PM
kalali committed rMITKfe2e8ad01759: Clean class, remove unnecessary comments, use auto (authored by kalali).
Clean class, remove unnecessary comments, use auto
Wed, Sep 23, 3:04 PM

Mon, Sep 21

kalali added a revision to T27744: [MITKDoc] Revise Model Fit Demo View Documentation: Unknown Object (Differential Revision).
Mon, Sep 21, 10:54 AM · Cleared, MITK (2020)

Wed, Sep 16

kalali added a comment to T27716: Extend "Checkliste Segmentierung – Manuelle Segmentierung / 2D Segmentierung".

We discussed the open todos concerning Checklists (storage, format, language) and decided that this topic should be prioritized higher but not for the milestone of the new release / current documentation refactoring.
I think this would be a good option for the phase after the release but if you have a strong point to do it now, please state here.

Wed, Sep 16, 12:21 PM · Restricted Project, Cleared, MITK (2020)

Tue, Sep 15

kalali raised the priority of T27716: Extend "Checkliste Segmentierung – Manuelle Segmentierung / 2D Segmentierung" from Normal to High.

@thomass, @gaoh Can someone please proofread?

Tue, Sep 15, 8:11 PM · Restricted Project, Cleared, MITK (2020)
kalali raised the priority of T27737: Extend "Checkliste Segmentierung – Optionen" from Normal to High.
Tue, Sep 15, 8:02 PM · Restricted Project, Cleared, MITK (2020)
kalali updated the task description for T25804: Set 'selected' property when using the new selection concept.
Tue, Sep 15, 7:54 PM · Request for Discussion, MITK

Mon, Sep 14

kalali updated the task description for T27737: Extend "Checkliste Segmentierung – Optionen".
Mon, Sep 14, 2:45 PM · Restricted Project, Cleared, MITK (2020)
kalali triaged T27737: Extend "Checkliste Segmentierung – Optionen" as Normal priority.
Mon, Sep 14, 2:42 PM · Restricted Project, Cleared, MITK (2020)
kalali moved T27716: Extend "Checkliste Segmentierung – Manuelle Segmentierung / 2D Segmentierung" from Backlog to Segmentation on the MITK (2020) board.
Mon, Sep 14, 2:39 PM · Restricted Project, Cleared, MITK (2020)
kalali added a revision to T24771: [MITKDoc] Add a concept documentation for the data storage inspectors and the overhaul of the selection concept: Unknown Object (Differential Revision).
Mon, Sep 14, 1:13 PM · MITK (2020)

Sat, Sep 12

kalali renamed T27716: Extend "Checkliste Segmentierung – Manuelle Segmentierung / 2D Segmentierung" from Extend "Checkliste Segmentierung – Manuelle Segmentierung" to Extend "Checkliste Segmentierung – Manuelle Segmentierung / 2D Segmentierung".
Sat, Sep 12, 1:04 PM · Restricted Project, Cleared, MITK (2020)
kalali updated subscribers of T27716: Extend "Checkliste Segmentierung – Manuelle Segmentierung / 2D Segmentierung".

I updated the document and added content to explicitly tests

  • segmentation on a 3D image
  • 3D segmentation (static) on a 4D image
  • 4D segmentation (dynamic) on a 4D image
Sat, Sep 12, 12:56 PM · Restricted Project, Cleared, MITK (2020)

Fri, Sep 11

kalali triaged T27721: [Segmentation] 2D Fast Marching crashes with 4D image and static segmentation as High priority.
Fri, Sep 11, 6:29 PM · MITK (2020)
kalali updated the task description for T26754: Review checklists.
Fri, Sep 11, 1:55 PM · Request for Discussion, Restricted Project, MITK
kalali moved T23811: PatientViewPlugin ++ from MITK Meeting to Backlog on the Request for Discussion board.
Fri, Sep 11, 12:51 PM · Request for Discussion, MITK
kalali moved T26854: Unattended Qt installation from In Progress to Backlog on the CI board.
Fri, Sep 11, 12:36 PM · CI, Restricted Project, MITK
kalali added a comment to T27713: [Segmentation] Disable "New" button when no image is selected.

Also, the "red warning" does not change back to "Please select an image" if an image is removed (which was automatically selected before).

Fri, Sep 11, 12:35 PM · MITK (2020)
kalali added a comment to T27713: [Segmentation] Disable "New" button when no image is selected.

Also, the checklist states "Er ist disabled"

Fri, Sep 11, 12:03 PM · MITK (2020)
kalali added a comment to T27506: Extend checklists for segmentation view.

What exactly? I copied the checklists to my local machine and I'm working on T27716: Extend "Checkliste Segmentierung – Manuelle Segmentierung / 2D Segmentierung".

Fri, Sep 11, 11:48 AM · Restricted Project, Cleared, MITK (2020)
kalali renamed T26989: [Checklist] GUI test data originates from different sources from [Checklist] GUI test data originates from different sources to [Checklist] GUI test data originates from different sources.
Fri, Sep 11, 11:47 AM · Restricted Project, Request for Discussion, MITK
kalali added a comment to T27506: Extend checklists for segmentation view.

All tools have to check for the following usage scenario:

  • All this with an image which time geometry does not start at 0 ms (e.g. MITK-Data/3D+t-ITKIO-TestData/LinearModel_4D_arbitrary_time_geometry.nrrd)
Fri, Sep 11, 10:22 AM · Restricted Project, Cleared, MITK (2020)
kalali triaged T27716: Extend "Checkliste Segmentierung – Manuelle Segmentierung / 2D Segmentierung" as Normal priority.
Fri, Sep 11, 10:10 AM · Restricted Project, Cleared, MITK (2020)
kalali added a comment to T27506: Extend checklists for segmentation view.

I started with the checklists I from E130-Daten\Release\Checklisten\MITK Workbench Release.

Fri, Sep 11, 10:07 AM · Restricted Project, Cleared, MITK (2020)

Thu, Sep 10

kalali moved T23811: PatientViewPlugin ++ from Backlog to MITK Meeting on the Request for Discussion board.
Thu, Sep 10, 1:52 PM · Request for Discussion, MITK
kalali added a project to T23811: PatientViewPlugin ++: Request for Discussion.
Thu, Sep 10, 1:52 PM · Request for Discussion, MITK
kalali moved T25804: Set 'selected' property when using the new selection concept from Backlog to MITK Meeting on the Request for Discussion board.
Thu, Sep 10, 12:17 PM · Request for Discussion, MITK

Wed, Sep 9

kalali added a revision to T27096: [MITKDoc] Revise MultiLabel Segmentation Utilities Plugin Documentation: Unknown Object (Differential Revision).
Wed, Sep 9, 4:36 PM · Cleared, MITK (2020)
kalali added a comment to T27094: [MITKDoc] Revise Segmentation Utilities Plugin Documentation.

Another utility Contour to image was added so I had to add a screenshot. For visual consistency I changed all screenshots.

Wed, Sep 9, 3:43 PM · Cleared, MITK (2020)
kalali added a revision to T27094: [MITKDoc] Revise Segmentation Utilities Plugin Documentation: Unknown Object (Differential Revision).
Wed, Sep 9, 3:41 PM · Cleared, MITK (2020)

Tue, Sep 8

kalali claimed T27096: [MITKDoc] Revise MultiLabel Segmentation Utilities Plugin Documentation.
Tue, Sep 8, 11:33 AM · Cleared, MITK (2020)
kalali claimed T27094: [MITKDoc] Revise Segmentation Utilities Plugin Documentation.
Tue, Sep 8, 11:32 AM · Cleared, MITK (2020)

Fri, Sep 4

kalali closed T27674: [Selection widgets] Enabling auto selection emits a signal that might not yet be connected as Resolved.

Closed with changes of D398 as discussed: Remark for developers.

Fri, Sep 4, 11:15 AM · Cleared, MITK
kalali committed rMITKe33c81988106: Provide developer remark for auto selection mode (authored by kalali).
Provide developer remark for auto selection mode
Fri, Sep 4, 11:14 AM
kalali committed rMITKccc798c6f898: Add remark on how to use the auto selection mode (authored by kalali).
Add remark on how to use the auto selection mode
Fri, Sep 4, 11:14 AM
kalali committed rMITKba371719c114: Modify remark on how to use the auto selection mode (authored by kalali).
Modify remark on how to use the auto selection mode
Fri, Sep 4, 11:14 AM
kalali added a comment to T27184: Clipping plane deformation tool doesn't show updates in 3d window.

I couldn't identify any differences between the latest develop branch and my installed MITK v2018.04.2.

Fri, Sep 4, 11:10 AM · Missing Info, Restricted Project, MITK (2020)
kalali added a comment to T27184: Clipping plane deformation tool doesn't show updates in 3d window.

Do you know when it worked the last time? What do you want to rewrite - I don't see any reference to the 3D window.

Fri, Sep 4, 9:41 AM · Missing Info, Restricted Project, MITK (2020)

Thu, Sep 3

kalali awarded T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation a Cup of Joe token.
Thu, Sep 3, 10:21 PM · Missing Info, Restricted Project, MITK (2020)
kalali added a revision to T27674: [Selection widgets] Enabling auto selection emits a signal that might not yet be connected: Unknown Object (Differential Revision).
Thu, Sep 3, 2:02 PM · Cleared, MITK
kalali updated subscribers of T27659: Refactor BasicImageProcessing plugin to use the new node selection widgets.

@kislinsk mentioned that I might use some feature that is not working with Clang. Actually the only special feature I'm using it qOverload.

Thu, Sep 3, 12:10 PM · MITK, Cleared
kalali added a comment to T27659: Refactor BasicImageProcessing plugin to use the new node selection widgets.

MacOS still fails building MITK (see https://ci.mitk.org/job/MITK/job/Differential/job/macOS%20Mojave/431/console).

Thu, Sep 3, 12:09 PM · MITK, Cleared
kalali added a comment to T27659: Refactor BasicImageProcessing plugin to use the new node selection widgets.

Updated D381

Thu, Sep 3, 11:21 AM · MITK, Cleared

Wed, Sep 2

kalali claimed T27674: [Selection widgets] Enabling auto selection emits a signal that might not yet be connected.

Thank you, I wanted to post the discussion result here as well. I will fix this.

Wed, Sep 2, 9:01 AM · Cleared, MITK

Mon, Aug 31

kalali moved T27691: [MITKDoc] Documentation links reference "The Phenotyping" subpages from Backlog to Documentation on the MITK (2020) board.
Mon, Aug 31, 4:08 PM · MITK (2020)
kalali edited projects for T27691: [MITKDoc] Documentation links reference "The Phenotyping" subpages, added: MITK (2020); removed MITK.
Mon, Aug 31, 4:08 PM · MITK (2020)
kalali triaged T27691: [MITKDoc] Documentation links reference "The Phenotyping" subpages as Normal priority.
Mon, Aug 31, 3:39 PM · MITK (2020)
kalali added a comment to T27094: [MITKDoc] Revise Segmentation Utilities Plugin Documentation.
  1. That is rather a bug, because in Phenotyping there is a reference that shouldn't be there, maybe we can remove that.
Mon, Aug 31, 3:30 PM · Cleared, MITK (2020)

Fri, Aug 28

kalali added a comment to T27094: [MITKDoc] Revise Segmentation Utilities Plugin Documentation.

I started with the modifications but I have two questions (@thomass
):

  • What exactly is Surface To Image doing and which data could be used to see the effect?
  • When open MITK User Manual -> MITK Plugin Manuals -> List of General Purpose Plugins -> The Segmentation and select The Segmentation Utilities View in the left menu (or in the Overview-section) I am redirected to MITK User Manual -> MITK Plugin Manuals -> List of Application-specific Plugins -> The Phenotyping -> The Segmentation Utilities View (see QmitkPhenotypingPortalPage.dox).
Fri, Aug 28, 4:58 PM · Cleared, MITK (2020)
kalali moved T27674: [Selection widgets] Enabling auto selection emits a signal that might not yet be connected from Backlog to MITK Meeting on the Request for Discussion board.
Fri, Aug 28, 11:32 AM · Cleared, MITK

Wed, Aug 26

kalali added a comment to T16026: Distinct tool names for 2d and 3d segmentation tools.

Is this still a topic?

Wed, Aug 26, 10:01 AM · MITK, Bugzilla

Aug 24 2020

kalali renamed T27681: Image cropper image selection widget accepts bounding box from Image cropper image selection widgets accepts bounding box to Image cropper image selection widget accepts bounding box.
Aug 24 2020, 1:21 PM · MITK
kalali triaged T27681: Image cropper image selection widget accepts bounding box as Normal priority.
Aug 24 2020, 12:45 PM · MITK

Aug 17 2020

kalali added a comment to T27524: Should RenderingManager be used without singleton?.

I cannot see any declaration of GetRenderingManager() in BaseRenderer

Aug 17 2020, 11:38 AM · Request for Discussion, MITK
kalali added a comment to T27637: [Segmentation] Multilable label name dialoge on label creation is a UX problem.

You're right, I was mistakenly reading the dialog that shows up when you create a new layer for a layer name dialog.

Aug 17 2020, 10:35 AM · Request for Discussion, MITK

Aug 14 2020

kalali updated the task description for T27524: Should RenderingManager be used without singleton?.
Aug 14 2020, 5:58 PM · Request for Discussion, MITK
kalali added a comment to T27637: [Segmentation] Multilable label name dialoge on label creation is a UX problem.

+1 and I'm also not sure why a Layer needs to have a name. I can't see it anywhere and if the name is used somewhere, the same discussion as for the labels might be needed for layers.

Aug 14 2020, 5:57 PM · Request for Discussion, MITK
kalali added a project to T27674: [Selection widgets] Enabling auto selection emits a signal that might not yet be connected: Request for Discussion.
Aug 14 2020, 5:52 PM · Cleared, MITK
kalali triaged T27674: [Selection widgets] Enabling auto selection emits a signal that might not yet be connected as Normal priority.
Aug 14 2020, 5:51 PM · Cleared, MITK
kalali added a revision to T27105: [MITKDoc] Revise Measurement Plugin Documentation: Unknown Object (Differential Revision).
Aug 14 2020, 5:30 PM · Cleared, MITK (2020)
kalali added a comment to T27672: [Measurement] Planar figures are disabled when the image is already loaded.

Proposed a fix in D388, maybe there is a more elegant way but it works now

Aug 14 2020, 3:10 PM · MITK (2020)

Aug 13 2020

kalali updated subscribers of T27498: [Selection widgets] Define default for auto selection / listening mechanism.

How do we proceed with (ML)Segmentation

Segmentation already uses AutoSelection as default (can be configured via preferences, default is true)

Aug 13 2020, 10:05 AM · Restricted Project, MITK (2020)

Aug 12 2020

kalali added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.

I started fixing some plugins. How do we proceed with (ML)Segmentation and MatchPoint?

Aug 12 2020, 12:34 PM · Restricted Project, MITK (2020)
kalali claimed T27659: Refactor BasicImageProcessing plugin to use the new node selection widgets.
Aug 12 2020, 12:32 PM · MITK, Cleared
kalali added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.

Pushed new branch T27498-Set-selection-mode-to-auto-selection.

Aug 12 2020, 11:24 AM · Restricted Project, MITK (2020)
kalali renamed T27665: PlanarFigure tests show error with DICOMTagsOfInterestAddHelper from PlanarFigure tests faile due to DICOMTagsOfInterestAddHelper to PlanarFigure tests show error with DICOMTagsOfInterestAddHelper.
Aug 12 2020, 9:34 AM · MITK
kalali triaged T27665: PlanarFigure tests show error with DICOMTagsOfInterestAddHelper as Normal priority.
Aug 12 2020, 9:33 AM · MITK
kalali closed T27061: Planar figures crash if drawn with empty data storage, a subtask of T27049: Refactor Measurement plugin to use the new node selection widgets, as Resolved.
Aug 12 2020, 8:19 AM · MITK
kalali closed T27061: Planar figures crash if drawn with empty data storage as Resolved.
Aug 12 2020, 8:19 AM · Restricted Project, MITK
kalali committed rMITK67d34b5de004: Introduce nullptr checks in PlanarFigureInteractor to avoid nullptr exception (authored by kalali).
Introduce nullptr checks in PlanarFigureInteractor to avoid nullptr exception
Aug 12 2020, 8:18 AM
kalali committed rMITK5b5d523a5c51: Add nullptr checks to prevent crashes (authored by kalali).
Add nullptr checks to prevent crashes
Aug 12 2020, 8:18 AM
kalali committed rMITK780e8d84937f: Clean class (authored by kalali).
Clean class
Aug 12 2020, 8:18 AM

Aug 11 2020

kalali added a revision to T27061: Planar figures crash if drawn with empty data storage: Unknown Object (Differential Revision).
Aug 11 2020, 4:51 PM · Restricted Project, MITK
kalali added a revision to T27101: [MITKDoc] Revise Logging Plugin Documentation: Unknown Object (Differential Revision).
Aug 11 2020, 1:58 PM · Cleared, MITK (2020)

Aug 8 2020

kalali added a revision to T27659: Refactor BasicImageProcessing plugin to use the new node selection widgets: Restricted Differential Revision.
Aug 8 2020, 5:34 PM · MITK, Cleared
kalali triaged T27659: Refactor BasicImageProcessing plugin to use the new node selection widgets as Normal priority.
Aug 8 2020, 5:01 PM · MITK, Cleared
kalali added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.

Plugins from T24775: Refactor plugins to use the new node selection widgets that do not follow the discussion result and need to be refactored:
No auto selection (SetAutoSelectNewNodes(true))

  • Dicom Inspector
  • Segmentation (although it is working if the segmentation plugin is opened AFTER a node has been loaded - but not the other way around)
  • Segmentation Utilities (QmitkDataSelectionWidget) (although it is working if the segmentation utilities plugin is opened BEFORE a node has been loaded - but not the other way around)
  • MultiLabel Segmentation Utilities (QmitkDataSelectionWidget) (not working at all - although the same QmitkDataSelectionWidget is used)
  • Image Cropper (will be fixed in D375)
  • Image Statistics (uses MultiNodeSelectionWidget)
  • Measurement (will be fixed in D372)
  • MatchPoint
  • Properties
  • Semantic Relations
  • Semantic Relations Statistics
  • Volume Visualization
Aug 8 2020, 10:00 AM · Restricted Project, MITK (2020)

Aug 3 2020

kalali committed rMITK936b789bbc0a: Refactor DeformableClippingPlane plugin to use the new node selection widgets (authored by kalali).
Refactor DeformableClippingPlane plugin to use the new node selection widgets
Aug 3 2020, 1:13 PM
kalali committed rMITK540a9ae22d0d: Ensure color components to be <= 1.0f (authored by kalali).
Ensure color components to be <= 1.0f
Aug 3 2020, 1:13 PM
kalali committed rMITK3accc287f87d: Add more const-correctness (authored by kalali).
Add more const-correctness
Aug 3 2020, 1:13 PM
kalali committed rMITK0b78143eecdf: Simplify function and make it more readable (authored by kalali).
Simplify function and make it more readable
Aug 3 2020, 1:13 PM
kalali committed rMITKd074f7074a76: Simplify condition to enable UI element (group box) (authored by kalali).
Simplify condition to enable UI element (group box)
Aug 3 2020, 1:13 PM
kalali committed rMITK52360025467c: Simplify for-loop and change style (authored by kalali).
Simplify for-loop and change style
Aug 3 2020, 1:13 PM
kalali committed rMITK9443f151d240: Make nullptr check more visible (authored by kalali).
Make nullptr check more visible
Aug 3 2020, 1:13 PM
kalali committed rMITKc63c38d0ab16: Use auto (authored by kalali).
Use auto
Aug 3 2020, 1:13 PM
kalali committed rMITK41eed2598243: Fix missing "this" pointer (authored by kalali).
Fix missing "this" pointer
Aug 3 2020, 1:13 PM
kalali committed rMITK13e2b28d1f68: Use mitk numeric constant (authored by kalali).
Use mitk numeric constant
Aug 3 2020, 1:12 PM
kalali committed rMITK130dcde2604e: Move controls initialization to constructor initializer list (authored by kalali).
Move controls initialization to constructor initializer list
Aug 3 2020, 1:12 PM
kalali committed rMITK27164bacf476: Simplify string comparison (authored by kalali).
Simplify string comparison
Aug 3 2020, 1:12 PM
kalali committed rMITK1a203b8744af: Use const ref value for the list of nodes (authored by kalali).
Use const ref value for the list of nodes
Aug 3 2020, 1:12 PM
kalali updated the task description for T24775: Refactor plugins to use the new node selection widgets.
Aug 3 2020, 1:12 PM · MITK, Restricted Project, Cleared
kalali committed rMITKc0bab37190df: Change include type (authored by kalali).
Change include type
Aug 3 2020, 1:12 PM