Page MenuHomePhabricator | MITK

kalali (Amir Kalali)
Developer

Projects

User Details

User Since
Aug 1 2016, 12:10 PM (123 w, 1 d)

Recent Activity

Today

kalali closed T25735: Fix bugs introduced by fe6c92bc6319 as Resolved.
Tue, Dec 11, 2:05 PM · MITK
kalali closed T25735: Fix bugs introduced by fe6c92bc6319, a subtask of T25056: Refactor data manager context menu, as Resolved.
Tue, Dec 11, 2:05 PM · MITK
kalali committed rMITK9aff5ec6cf80: Merge branch 'T25735-Fix-bugs-with-render-window-strategy' (authored by kalali).
Merge branch 'T25735-Fix-bugs-with-render-window-strategy'
Tue, Dec 11, 2:04 PM
kalali committed rMITK2d3e9820de40: Fix bugs introduced by fe6c92bc6319 (authored by kalali).
Fix bugs introduced by fe6c92bc6319
Tue, Dec 11, 2:04 PM
kalali added a comment to T25735: Fix bugs introduced by fe6c92bc6319.

Pushed new branch T25735-Fix-bugs-with-render-window-strategy.

Tue, Dec 11, 2:03 PM · MITK
kalali updated the task description for T25735: Fix bugs introduced by fe6c92bc6319.
Tue, Dec 11, 2:01 PM · MITK
kalali triaged T25735: Fix bugs introduced by fe6c92bc6319 as Normal priority.
Tue, Dec 11, 2:00 PM · MITK
kalali committed rMITKee0934cf2cc7: Merge branch 'T25699-Context-menu-with-data-node-selection' (authored by kalali).
Merge branch 'T25699-Context-menu-with-data-node-selection'
Tue, Dec 11, 11:49 AM
kalali committed rMITKa466b9ef9d16: Fix gcc errors (authored by kalali).
Fix gcc errors
Tue, Dec 11, 11:41 AM

Yesterday

kalali closed T25699: Explicitly set data node selection of the context menu (actions) as Resolved.
Mon, Dec 10, 3:14 PM · MITK
kalali closed T25699: Explicitly set data node selection of the context menu (actions), a subtask of T25056: Refactor data manager context menu, as Resolved.
Mon, Dec 10, 3:13 PM · MITK
kalali committed rMITK0b5d923e02f5: Merge branch 'T25699-Context-menu-with-data-node-selection' into HEAD (authored by kalali).
Merge branch 'T25699-Context-menu-with-data-node-selection' into HEAD
Mon, Dec 10, 3:10 PM
kalali claimed T25699: Explicitly set data node selection of the context menu (actions).
Mon, Dec 10, 2:56 PM · MITK
kalali committed rMITKfc0b9f8e8732: Add possibility to set selected nodes for the data node context menu (actions) (authored by kalali).
Add possibility to set selected nodes for the data node context menu (actions)
Mon, Dec 10, 2:56 PM
kalali committed rMITK5b20f950ad1f: Use selected nodes for the hotkey actions (authored by kalali).
Use selected nodes for the hotkey actions
Mon, Dec 10, 2:56 PM
kalali added a comment to T25699: Explicitly set data node selection of the context menu (actions).

Pushed new branch T25699-Context-menu-with-data-node-selection.

Mon, Dec 10, 2:56 PM · MITK

Thu, Dec 6

kalali closed T25726: Fix GCC errors as Resolved.
Thu, Dec 6, 6:01 PM · MITK
kalali closed T25726: Fix GCC errors, a subtask of T25688: Render window manager with custom multi widget: beta version, as Resolved.
Thu, Dec 6, 6:01 PM · Noteworthy, Restricted Project, MITK
kalali committed rMITK102b2affe1e9: Merge branch 'T25726-Fix-GCC-errors' into T25688-Render-window-manager-with… (authored by kalali).
Merge branch 'T25726-Fix-GCC-errors' into T25688-Render-window-manager-with…
Thu, Dec 6, 4:23 PM
kalali committed rMITKc0f8b16b8dfd: Merge branch 'T23764-Crosshair-for-single-render-windows' into T25688-Render… (authored by kalali).
Merge branch 'T23764-Crosshair-for-single-render-windows' into T25688-Render…
Thu, Dec 6, 4:23 PM
kalali updated the task description for T25688: Render window manager with custom multi widget: beta version.
Thu, Dec 6, 4:00 PM · Noteworthy, Restricted Project, MITK
kalali removed a project from T25726: Fix GCC errors: Restricted Project.
Thu, Dec 6, 3:59 PM · MITK
kalali committed rMITKb609c49bcf8c: Fix gcc errors (authored by kalali).
Fix gcc errors
Thu, Dec 6, 3:59 PM
kalali added a comment to T25726: Fix GCC errors.

Pushed new branch T25726-Fix-GCC-errors.

Thu, Dec 6, 3:59 PM · MITK
kalali triaged T25726: Fix GCC errors as Normal priority.
Thu, Dec 6, 3:45 PM · MITK

Wed, Dec 5

kalali closed T23764: Create crosshair for single render windows as Resolved.
Wed, Dec 5, 5:46 PM · MITK
kalali closed T23764: Create crosshair for single render windows, a subtask of T23758: Introduction of custom multi widget editor, as Resolved.
Wed, Dec 5, 5:46 PM · Restricted Project, MITK
kalali committed rMITK4e1e267724ab: Add function to (de-)activate the crosshair point set of a render window widget (authored by kalali).
Add function to (de-)activate the crosshair point set of a render window widget
Wed, Dec 5, 5:45 PM
kalali committed rMITKebc82ec8102d: Make StdMultiWidget the default editor (authored by kalali).
Make StdMultiWidget the default editor
Wed, Dec 5, 5:45 PM
kalali committed rMITK5015f5323320: Remove leftovers of 'show_in' action (authored by kalali).
Remove leftovers of 'show_in' action
Wed, Dec 5, 5:45 PM
kalali committed rMITK487b4d96bdd0: Refactor comments (authored by kalali).
Refactor comments
Wed, Dec 5, 5:45 PM
kalali committed rMITKe92a0c51b290: Remove unnecessary code (authored by kalali).
Remove unnecessary code
Wed, Dec 5, 5:45 PM
kalali added a comment to T23764: Create crosshair for single render windows.

Pushed new branch T23764-Crosshair-for-single-render-windows.

Wed, Dec 5, 5:45 PM · MITK
kalali added a comment to T23764: Create crosshair for single render windows.

Custom multi widget editor knows when it is being (de-)activated and will (de-)activate (add / remove) the crosshair point set nodes accordingly (similar to the StdMultiWidget, where the planes where added or removed to or from the data storage).

Wed, Dec 5, 5:44 PM · MITK
kalali closed T22876: Crosshair disappears if the anatomical planes in a render window are changed as Resolved.

This branch has not been merged. Some parts of the code has been taken and used in T23764 to create a new crosshair for the custom multi widget editor.
This task will be closed as resolved, since T23764 will be merged into mater.

Wed, Dec 5, 5:39 PM · Restricted Project, MITK
kalali closed T22876: Crosshair disappears if the anatomical planes in a render window are changed, a subtask of T25603: Combine render window manager with custom multi widget, as Resolved.
Wed, Dec 5, 5:38 PM · Restricted Project, MITK
kalali triaged T25725: "Show in" action is currently not implemented as Normal priority.
Wed, Dec 5, 4:22 PM · MITK

Tue, Dec 4

kalali updated the task description for T25688: Render window manager with custom multi widget: beta version.
Tue, Dec 4, 5:57 PM · Noteworthy, Restricted Project, MITK
kalali closed T25705: Workbench crashes with custom and std multi widget as Resolved.
Tue, Dec 4, 5:51 PM · MITK
kalali closed T25705: Workbench crashes with custom and std multi widget, a subtask of T25688: Render window manager with custom multi widget: beta version, as Resolved.
Tue, Dec 4, 5:51 PM · Noteworthy, Restricted Project, MITK
kalali committed rMITKf47b902bbc3f: Merge branch 'T25705-Workbench-crash-on-display-switch' into T25688-Render… (authored by kalali).
Merge branch 'T25705-Workbench-crash-on-display-switch' into T25688-Render…
Tue, Dec 4, 5:51 PM
kalali committed rMITK66c35ba1233c: Use WeakPointer to prevent a crash on render window editor switch (authored by kalali).
Use WeakPointer to prevent a crash on render window editor switch
Tue, Dec 4, 5:50 PM
kalali claimed T25705: Workbench crashes with custom and std multi widget.
Tue, Dec 4, 5:49 PM · MITK
kalali added a comment to T25705: Workbench crashes with custom and std multi widget.

Pushed new branch T25705-Workbench-crash-on-display-switch.

Tue, Dec 4, 5:49 PM · MITK
kalali added a comment to T25705: Workbench crashes with custom and std multi widget.

Dangling pointer detected. Was changed to a WeakPointer.

Tue, Dec 4, 5:47 PM · MITK
kalali closed T25706: Workbench crashes when opening the Standard display as Resolved.
Tue, Dec 4, 3:43 PM · MITK
kalali closed T25706: Workbench crashes when opening the Standard display, a subtask of T25688: Render window manager with custom multi widget: beta version, as Resolved.
Tue, Dec 4, 3:43 PM · Noteworthy, Restricted Project, MITK
kalali committed rMITK6dbc3a5e9b14: Merge branch 'T25706-Workbench-crash-with-two-displays' into T25688-Render… (authored by kalali).
Merge branch 'T25706-Workbench-crash-with-two-displays' into T25688-Render…
Tue, Dec 4, 3:43 PM
kalali committed rMITK10bdd0678d26: Use weak-pointer for base renderer member (authored by kalali).
Use weak-pointer for base renderer member
Tue, Dec 4, 3:06 PM
kalali added a comment to T25706: Workbench crashes when opening the Standard display.

Pushed new branch T25706-Workbench-crash-with-two-displays.

Tue, Dec 4, 3:06 PM · MITK
kalali claimed T25706: Workbench crashes when opening the Standard display.
Tue, Dec 4, 3:04 PM · MITK
kalali added a comment to T25706: Workbench crashes when opening the Standard display.

QmitkDataStorageRenderWindowListModel was holding a SmartPointer to a base renderer, which was removed when the Custom display is closed.

Tue, Dec 4, 3:03 PM · MITK
kalali committed rMITK3d5d934e4e73: Change renderer vector type; change setting the controlled renderer (authored by kalali).
Change renderer vector type; change setting the controlled renderer
Tue, Dec 4, 12:43 PM
kalali committed rMITK1d92b09b8210: Remove view direction change button from the configuration tool bar of the… (authored by kalali).
Remove view direction change button from the configuration tool bar of the…
Tue, Dec 4, 12:43 PM
kalali committed rMITK7107092e6338: Add changes that have been detected in other related branches (refactoring… (authored by kalali).
Add changes that have been detected in other related branches (refactoring…
Tue, Dec 4, 12:43 PM
kalali committed rMITKdaa00f032ce8: Fix initialization bugs (authored by kalali).
Fix initialization bugs
Tue, Dec 4, 12:43 PM
kalali added a comment to T25688: Render window manager with custom multi widget: beta version.

Pushed new branch T25688-Render-window-manager-with-custom-multi-widget-beta.

Tue, Dec 4, 12:43 PM · Noteworthy, Restricted Project, MITK
kalali added a comment to T25595: Make ImageNavigator work with the custom multi widget editor.

Similar problem in QmitkSegmentationView:
Here we have an error in RenderWindowPartActivated (called in CreateQtPartControl): A specific QmitkRenderWindow is retriebed (e.g. by id = "axial") and its slice navigation controller should be returned. However, no check s done to see if the render window is != nullptr.

Tue, Dec 4, 12:17 PM · MITK
kalali added a comment to T25056: Refactor data manager context menu.

Needed to fix some GCC errors.
Happened in 80840ba702d9.

Tue, Dec 4, 11:53 AM · MITK

Fri, Nov 30

kalali updated the task description for T25688: Render window manager with custom multi widget: beta version.
Fri, Nov 30, 6:08 PM · Noteworthy, Restricted Project, MITK
kalali placed T25706: Workbench crashes when opening the Standard display up for grabs.
Fri, Nov 30, 6:08 PM · MITK
kalali triaged T25706: Workbench crashes when opening the Standard display as Normal priority.
Fri, Nov 30, 6:03 PM · MITK
kalali triaged T25705: Workbench crashes with custom and std multi widget as Normal priority.
Fri, Nov 30, 5:58 PM · MITK
kalali placed T25699: Explicitly set data node selection of the context menu (actions) up for grabs.
Fri, Nov 30, 12:14 PM · MITK
kalali updated the task description for T25688: Render window manager with custom multi widget: beta version.
Fri, Nov 30, 12:14 PM · Noteworthy, Restricted Project, MITK
kalali added a comment to T25699: Explicitly set data node selection of the context menu (actions).

We should also investigate if the workbenchpartsite needs to be optional (may not be accessible).

Fri, Nov 30, 11:51 AM · MITK
kalali triaged T25699: Explicitly set data node selection of the context menu (actions) as Normal priority.
Fri, Nov 30, 11:48 AM · MITK
kalali updated the task description for T25688: Render window manager with custom multi widget: beta version.
Fri, Nov 30, 10:53 AM · Noteworthy, Restricted Project, MITK

Thu, Nov 29

kalali updated the task description for T25688: Render window manager with custom multi widget: beta version.
Thu, Nov 29, 5:42 PM · Noteworthy, Restricted Project, MITK
kalali added a task to rMITKdde37068f92d: Refactor data manager; create action classes and data node context menu;: T22435: QmitkDataManager checks for deprecated QmitkStatisticsAction.
Thu, Nov 29, 5:31 PM
kalali added a task to rMITK677e2badb8fa: Refactor data manager: T22435: QmitkDataManager checks for deprecated QmitkStatisticsAction.
Thu, Nov 29, 5:31 PM
kalali added a task to rMITK677e2badb8fa: Refactor data manager: T25254: Propagate preference page options.
Thu, Nov 29, 5:31 PM
kalali added a commit to T22435: QmitkDataManager checks for deprecated QmitkStatisticsAction: rMITKdde37068f92d: Refactor data manager; create action classes and data node context menu;.
Thu, Nov 29, 5:31 PM · MITK
kalali added a commit to T22435: QmitkDataManager checks for deprecated QmitkStatisticsAction: rMITK677e2badb8fa: Refactor data manager.
Thu, Nov 29, 5:31 PM · MITK
kalali committed rMITK2123fa1e494a: Merge branch 'T25056-Master-integration' Enable hotkeys preference page in… (authored by kalali).
Merge branch 'T25056-Master-integration' Enable hotkeys preference page in…
Thu, Nov 29, 5:31 PM
kalali added a commit to T25254: Propagate preference page options: rMITK677e2badb8fa: Refactor data manager.
Thu, Nov 29, 5:31 PM · MITK
kalali committed rMITK7836da9ac4ff: Merge remote-tracking branch 'origin/T25171-Hotkeys-preference-page-crash' into… (authored by kalali).
Merge remote-tracking branch 'origin/T25171-Hotkeys-preference-page-crash' into…
Thu, Nov 29, 4:56 PM
kalali committed rMITK8de786a10547: Merge branch 'T25694-Enable-data-manager-hotkeys' into T25056-Master-integration (authored by kalali).
Merge branch 'T25694-Enable-data-manager-hotkeys' into T25056-Master-integration
Thu, Nov 29, 4:56 PM
kalali added a comment to T25056: Refactor data manager context menu.

Master-integration contains T23590, T25643 and T25694 as a first stable working version.

Thu, Nov 29, 4:56 PM · MITK
kalali added a comment to T25056: Refactor data manager context menu.

Pushed new branch T25056-Master-integration.

Thu, Nov 29, 4:56 PM · MITK
kalali closed T25694: Enable data manager hotkeys as Resolved.

Contained in T25056

Thu, Nov 29, 4:53 PM · MITK
kalali closed T25694: Enable data manager hotkeys, a subtask of T25056: Refactor data manager context menu, as Resolved.
Thu, Nov 29, 4:53 PM · MITK
kalali closed T25171: Workbench crashes when accessing the "Hotkeys"-Preference page for the data manager (only debug) as Resolved.

Contained in T25056

Thu, Nov 29, 4:52 PM · Restricted Project, MITK
kalali claimed T25171: Workbench crashes when accessing the "Hotkeys"-Preference page for the data manager (only debug).
Thu, Nov 29, 4:28 PM · Restricted Project, MITK
kalali committed rMITK36dc69d97670: Remove needless classes (authored by kalali).
Remove needless classes
Thu, Nov 29, 4:22 PM
kalali committed rMITK7f874e19ffe1: Add hotkeys preference page and key filter; make actions globally accessible (authored by kalali).
Add hotkeys preference page and key filter; make actions globally accessible
Thu, Nov 29, 4:22 PM
kalali committed rMITK258e0e5ae890: Merge remote-tracking branch 'origin/T25643-Context-menu-actions-added-multiple… (authored by kalali).
Merge remote-tracking branch 'origin/T25643-Context-menu-actions-added-multiple…
Thu, Nov 29, 4:22 PM
kalali committed rMITK190ff81df40b: Apply changes of T23590 to the new decoupled context menu (actions) (authored by kalali).
Apply changes of T23590 to the new decoupled context menu (actions)
Thu, Nov 29, 4:22 PM
kalali committed rMITKb28e35f456af: Merge branch 'T25056-Refactor-data-manager-context-menu' into T25056-Master… (authored by kalali).
Merge branch 'T25056-Refactor-data-manager-context-menu' into T25056-Master…
Thu, Nov 29, 4:22 PM
kalali added a comment to T25694: Enable data manager hotkeys.

Pushed new branch T25694-Enable-data-manager-hotkeys.

Thu, Nov 29, 4:22 PM · MITK
kalali updated the task description for T25688: Render window manager with custom multi widget: beta version.
Thu, Nov 29, 12:16 PM · Noteworthy, Restricted Project, MITK
kalali triaged T25694: Enable data manager hotkeys as Normal priority.
Thu, Nov 29, 10:09 AM · MITK

Wed, Nov 28

kalali updated the task description for T25688: Render window manager with custom multi widget: beta version.
Wed, Nov 28, 6:00 PM · Noteworthy, Restricted Project, MITK
kalali updated the task description for T25688: Render window manager with custom multi widget: beta version.
Wed, Nov 28, 1:56 PM · Noteworthy, Restricted Project, MITK

Tue, Nov 27

kalali moved T25688: Render window manager with custom multi widget: beta version from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Tue, Nov 27, 4:52 PM · Noteworthy, Restricted Project, MITK
kalali updated the task description for T25688: Render window manager with custom multi widget: beta version.
Tue, Nov 27, 4:51 PM · Noteworthy, Restricted Project, MITK
kalali triaged T25688: Render window manager with custom multi widget: beta version as Normal priority.
Tue, Nov 27, 4:51 PM · Noteworthy, Restricted Project, MITK
kalali added a comment to T23764: Create crosshair for single render windows.

T25602 changed the render window manager to be a data storage inspector. Therefore data nodes don't have to be added or removed by the user but the render window manager will always provide a filtered view on the data storage (filtered by the currently active base renderer).

Tue, Nov 27, 4:08 PM · MITK
kalali added a comment to T25056: Refactor data manager context menu.

Consider T25645 (already included in T25601 via T24936).

Tue, Nov 27, 3:57 PM · MITK
kalali added a comment to T25683: Chart Example Plugin.

Tue, Nov 27, 1:34 PM · MITK