Page MenuHomePhabricator

kalali (Amir Kalali)
Developer

Projects (6)

User Details

User Since
Aug 1 2016, 12:10 PM (191 w, 5 d)

Recent Activity

Yesterday

kalali updated subscribers of T27289: Different coverage results with OpenCppCoverage and Gcov.

Unfortunately I cannot see any colored lines in the CDash html but it's ok since I'm able to see the output in the provided link.
@nolden can you shed any light on this?

Fri, Apr 3, 2:01 PM · MITK

Fri, Mar 13

kalali assigned T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel to floca.

Sorry.

Fri, Mar 13, 3:29 PM · MITK (2020), Unknown Object (Project)
kalali placed T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel up for grabs.
Fri, Mar 13, 3:29 PM · MITK (2020), Unknown Object (Project)
kalali committed rMITK7982aa6e060f: Format clipboard statistics data (authored by kalali).
Format clipboard statistics data
Fri, Mar 13, 3:28 PM
kalali committed rMITKd0415d55e1de: Rename member variables, remove extra whitespace (authored by kalali).
Rename member variables, remove extra whitespace
Fri, Mar 13, 3:27 PM
kalali committed rMITK58f58183c54d: Clear clipboard before use (authored by kalali).
Clear clipboard before use
Fri, Mar 13, 3:27 PM
kalali committed rMITK3e0e315eaccc: Change column delimiter to tab (authored by kalali).
Change column delimiter to tab
Fri, Mar 13, 3:27 PM
kalali added a revision to T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel: Unknown Object (Differential Revision).
Fri, Mar 13, 2:23 PM · MITK (2020), Unknown Object (Project)
kalali updated the task description for T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel.
Fri, Mar 13, 2:12 PM · MITK (2020), Unknown Object (Project)
kalali renamed T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel from ImageStatistic: copy to clipboard from statistic table should be directly usabel in Excel to [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel.
Fri, Mar 13, 2:10 PM · MITK (2020), Unknown Object (Project)
kalali added a comment to T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel.

How did you encounter the different decimal separator?

Fri, Mar 13, 2:08 PM · MITK (2020), Unknown Object (Project)
kalali added a comment to T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel.

There is also something wrong when having multiple images with masks (commas are put at the end of the mask-values):

Fri, Mar 13, 1:37 PM · MITK (2020), Unknown Object (Project)

Mon, Mar 9

kalali added a comment to T27206: Use new Qt5 signal-slot syntax.

Here are all four (five) variants mentioned and the explicit cast is used as an alternative as well:
https://doc.qt.io/qt-5/signalsandslots-syntaxes.html#selecting-overloaded-signals-and-slots

Mon, Mar 9, 1:01 PM · MITK
kalali added a comment to T27206: Use new Qt5 signal-slot syntax.

Oh, good to know. So QtOverload it is, I guess?

Mon, Mar 9, 10:26 AM · MITK

Sat, Mar 7

kalali added a comment to T27206: Use new Qt5 signal-slot syntax.

But I think in most cases it would increase the stability of our code base as it moves runtime errors to compile time errors.

Sat, Mar 7, 5:09 PM · MITK

Fri, Mar 6

kalali triaged T27206: Use new Qt5 signal-slot syntax as Wishlist priority.
Fri, Mar 6, 6:55 PM · MITK
kalali added a comment to T27183: New signal type signature leads to undefined signals.

Only for the CurrentSelectionChanged, since this lead to an error and if we fix it, we might use the new syntax anyway. I think refactoring all old style connections could be a task for a dedicated hacking day - maybe with some batch-refactoring?

Fri, Mar 6, 10:50 AM · MITK

Thu, Mar 5

kalali merged T27198: [MatchPoint] MatchPoint Registration Evaluator crashes with Color blend mode into T27143: Matchpoint Registration Evaluator- Colorblend Bug.
Thu, Mar 5, 9:14 PM · MITK (2020), Unknown Object (Project)
kalali merged task T27198: [MatchPoint] MatchPoint Registration Evaluator crashes with Color blend mode into T27143: Matchpoint Registration Evaluator- Colorblend Bug.
Thu, Mar 5, 9:14 PM · MITK (2020)
kalali added a comment to T27198: [MatchPoint] MatchPoint Registration Evaluator crashes with Color blend mode.

Ups, obviously my search results returned null *stupidphabricatorsearch*

Thu, Mar 5, 9:13 PM · MITK (2020)

Mar 5 2020

kalali triaged T27198: [MatchPoint] MatchPoint Registration Evaluator crashes with Color blend mode as Normal priority.
Mar 5 2020, 1:55 PM · MITK (2020)
kalali added projects to T27188: [ImageStatistics] Test failed and is not detected by CTest: Unknown Object (Project), Request for Discussion.
Mar 5 2020, 1:14 PM · Request for Discussion, Unknown Object (Project), CI, MITK
kalali renamed T27197: [Selection concept] Data storage inspector icons shift in node selection dialog from [Sdata storage inspector icons shift in node selection dialog to [Selection concept] Data storage inspector icons shift in node selection dialog.
Mar 5 2020, 1:12 PM · MITK
kalali triaged T27197: [Selection concept] Data storage inspector icons shift in node selection dialog as Normal priority.
Mar 5 2020, 1:11 PM · MITK

Mar 4 2020

kalali placed T27183: New signal type signature leads to undefined signals up for grabs.
Mar 4 2020, 12:21 PM · MITK
kalali closed T27185: Create new segmentation is sometimes disabled as Resolved.

Fixed by T27183 / D258

Mar 4 2020, 12:20 PM · MITK
kalali committed rMITKd565f94b0987: Merge branch 'T27183-Fix-segmentation-view' (authored by kalali).
Merge branch 'T27183-Fix-segmentation-view'
Mar 4 2020, 12:17 PM
kalali committed rMITK15b93b283446: Use new signal-slot syntax (authored by kalali).
Use new signal-slot syntax
Mar 4 2020, 12:12 PM
kalali committed rMITKf238324a0038: Remove / correct comments (authored by kalali).
Remove / correct comments
Mar 4 2020, 12:12 PM
kalali committed rMITK24ccd3eab6d5: Segmentation view does subclass the ILifecycleAwarePart anymore (authored by kalali).
Segmentation view does subclass the ILifecycleAwarePart anymore
Mar 4 2020, 12:12 PM
kalali committed rMITK19782783c908: Use new signal-slot syntax to work with diferent type signature (authored by kalali).
Use new signal-slot syntax to work with diferent type signature
Mar 4 2020, 12:12 PM
kalali added a comment to T27183: New signal type signature leads to undefined signals.

Pushed new branch T27183-Fix-segmentation-view.

Mar 4 2020, 12:11 PM · MITK
kalali claimed T27183: New signal type signature leads to undefined signals.
Mar 4 2020, 10:42 AM · MITK
kalali added a revision to T27183: New signal type signature leads to undefined signals: Unknown Object (Differential Revision).
Mar 4 2020, 10:42 AM · MITK
kalali added a comment to T27189: REST API for data storage.

I'm not a REST expert neither but I will look into it.

Mar 4 2020, 10:15 AM · Unknown Object (Project), Request for Discussion, MITK
kalali added a comment to T27185: Create new segmentation is sometimes disabled.

Probably related to T27183

Mar 4 2020, 10:09 AM · MITK

Mar 3 2020

kalali triaged T27188: [ImageStatistics] Test failed and is not detected by CTest as Normal priority.
Mar 3 2020, 5:07 PM · Request for Discussion, Unknown Object (Project), CI, MITK
kalali triaged T27183: New signal type signature leads to undefined signals as Unbreak Now! priority.
Mar 3 2020, 2:12 PM · MITK
kalali added a project to T25105: UpdateStatusBar duplicates business logic: Request for Discussion.

Related: T19470: Cleanup DisplayInteractor

Mar 3 2020, 11:59 AM · Request for Discussion, MITK
kalali added a project to T27061: Planar figures crash if drawn with empty data storage: Request for Discussion.
Mar 3 2020, 11:55 AM · Request for Discussion, MITK

Feb 28 2020

kalali added a comment to T27154: Define clean workflow for segmentation copying.

Will test MatchPoint Mapper

Feb 28 2020, 1:46 PM · Request for Discussion, MITK
kalali closed T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry as Invalid.

I still can't reproduce the error.
However, in the meantime things have changed and it is now possible to define a static or dynamic masks. Since it was not clear, what to do, I tested both. In the static case I get an error

core.mod.sfcInterpolation.controller ERROR: Invalid time step requested for interpolation pipeline
Feb 28 2020, 1:35 PM · MITK, Restricted Project
kalali added a comment to T27061: Planar figures crash if drawn with empty data storage.

As noted, this was never a real issue since the broken code was never merged.
As D238#5458 stated, measurement options are only enabled if an image is selected.

Feb 28 2020, 1:11 PM · Request for Discussion, MITK
kalali added a revision to T27100: [MITKDoc] Revise DataManager Plugin Documentation: Unknown Object (Differential Revision).
Feb 28 2020, 12:05 PM · MITK

Feb 24 2020

kalali updated the task description for T27154: Define clean workflow for segmentation copying.
Feb 24 2020, 2:35 PM · Request for Discussion, MITK
kalali triaged T27154: Define clean workflow for segmentation copying as Normal priority.
Feb 24 2020, 2:34 PM · Request for Discussion, MITK

Feb 19 2020

kalali updated the task description for T24775: Refactor plugins to use the new node selection widgets.
Feb 19 2020, 1:21 PM · MITK
kalali closed T26269: [image statistics plugin] refactor to use new node selection widget as Resolved.
Feb 19 2020, 1:20 PM · MITK
kalali closed T26269: [image statistics plugin] refactor to use new node selection widget, a subtask of T24775: Refactor plugins to use the new node selection widgets, as Resolved.
Feb 19 2020, 1:20 PM · MITK
kalali moved T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry from Backlog to MITK Meeting on the Request for Discussion board.
Feb 19 2020, 1:04 PM · MITK, Restricted Project
kalali committed rMITKab535c9fc543: Merge branch 'T26269-ChangeSelectionInStatisticsPlugin' (authored by kalali).
Merge branch 'T26269-ChangeSelectionInStatisticsPlugin'
Feb 19 2020, 12:38 PM

Feb 18 2020

kalali committed rMITKe5f6a8cf63aa: Change copyright header (authored by kalali).
Change copyright header
Feb 18 2020, 6:49 PM
kalali committed rMITK37bd230a6351: fixed gcc compile errors. (authored by floca).
fixed gcc compile errors.
Feb 18 2020, 6:49 PM
kalali committed rMITKdb0c7afb7e66: Fixed T27078 (authored by floca).
Fixed T27078
Feb 18 2020, 6:49 PM
kalali committed rMITK27579deb0997: Finish revising the documentation (authored by kalali).
Finish revising the documentation
Feb 18 2020, 6:43 PM
kalali committed rMITKbae955d433b3: Add new screenshots (authored by kalali).
Add new screenshots
Feb 18 2020, 6:42 PM
kalali committed rMITK25b4962369c9: Remove old screenshots (authored by kalali).
Remove old screenshots
Feb 18 2020, 6:42 PM
kalali committed rMITK0443f636b6de: Start revising the documentation (authored by kalali).
Start revising the documentation
Feb 18 2020, 6:42 PM
kalali added a comment to T27100: [MITKDoc] Revise DataManager Plugin Documentation.

Pushed new branch T27100-Revise-DataManager-Plugin-Documentation.

Feb 18 2020, 6:42 PM · MITK
kalali reopened T27096: [MITKDoc] Revise MultiLabel Segmentation Utilities Plugin Documentation as "Open".

I think there was a typo in the task number of a commit that automatically closed this unrelated task.

Feb 18 2020, 6:40 PM · MITK
kalali triaged T27145: berrySingleNodeSelection.cpp not needed anymore as Low priority.
Feb 18 2020, 2:53 PM · MITK
kalali closed T27056: Refactor ImageCropper plugin to use the new node selection widgets as Resolved.
Feb 18 2020, 11:22 AM · MITK
kalali closed T27056: Refactor ImageCropper plugin to use the new node selection widgets, a subtask of T24775: Refactor plugins to use the new node selection widgets, as Resolved.
Feb 18 2020, 11:22 AM · MITK
kalali updated the task description for T24775: Refactor plugins to use the new node selection widgets.
Feb 18 2020, 11:20 AM · MITK
kalali committed rMITKe5804ec1be59: Merge branch 'T27056-Image-cropper-with-single-node-selection-widget' (authored by kalali).
Merge branch 'T27056-Image-cropper-with-single-node-selection-widget'
Feb 18 2020, 11:19 AM
kalali committed rMITK459157579f84: Rename image cropper (authored by kalali).
Rename image cropper
Feb 18 2020, 11:19 AM
kalali committed rMITK6aca2332b13f: Rename slots and relocate functions (authored by kalali).
Rename slots and relocate functions
Feb 18 2020, 11:19 AM
kalali committed rMITK5be92b3d728b: Define function as slot and move location (authored by kalali).
Define function as slot and move location
Feb 18 2020, 11:19 AM
kalali committed rMITKf7e5639ed128: Make lambda legibly (authored by kalali).
Make lambda legibly
Feb 18 2020, 11:19 AM
kalali committed rMITK252ed0e1d60f: Remove member variables for node selection (authored by kalali).
Remove member variables for node selection
Feb 18 2020, 11:19 AM
kalali committed rMITKcdd83d5e4ce5: Include checks for bounding box (authored by kalali).
Include checks for bounding box
Feb 18 2020, 11:19 AM
kalali committed rMITKb0dcc0601f28: Fix initialization order (authored by kalali).
Fix initialization order
Feb 18 2020, 11:19 AM
kalali committed rMITK3fa27d24d3a1: Remove unused member variables (authored by kalali).
Remove unused member variables
Feb 18 2020, 11:19 AM
kalali committed rMITK7fca490cd056: Fix .ui-file (authored by kalali).
Fix .ui-file
Feb 18 2020, 11:19 AM
kalali committed rMITK013cd4aaab55: Modify UI to include selection widgets (authored by kalali).
Modify UI to include selection widgets
Feb 18 2020, 11:18 AM
kalali committed rMITK9706eaf8f187: Remove warning-pragma (authored by kalali).
Remove warning-pragma
Feb 18 2020, 11:18 AM
kalali committed rMITK8b2accadb6f5: Rename plugin activator (authored by kalali).
Rename plugin activator
Feb 18 2020, 11:18 AM
kalali committed rMITKb1d3db7c4d1c: Remove unused function (authored by kalali).
Remove unused function
Feb 18 2020, 11:18 AM
kalali committed rMITK7da270983b97: Clean class: reorder functions, fix naming, remove unnecessary function (authored by kalali).
Clean class: reorder functions, fix naming, remove unnecessary function
Feb 18 2020, 11:18 AM
kalali committed rMITK158639eb3ffa: Remove unnecessary includes and comments (authored by kalali).
Remove unnecessary includes and comments
Feb 18 2020, 11:18 AM
kalali added a comment to T27056: Refactor ImageCropper plugin to use the new node selection widgets.

Pushed new branch T27056-Image-cropper-with-single-node-selection-widget.

Feb 18 2020, 11:18 AM · MITK

Feb 14 2020

kalali triaged T27134: [Image statistics] Refactor Calculation Job and Calculation Runnable as Normal priority.
Feb 14 2020, 7:38 PM · MITK
kalali triaged T27133: Is QmitkDataSelectionWidget needed anymore? as Normal priority.
Feb 14 2020, 7:35 PM · MITK
kalali awarded T27069: OpenGL error / crash when opening context menu a Like token.
Feb 14 2020, 5:59 PM · MITK
kalali updated the task description for T27100: [MITKDoc] Revise DataManager Plugin Documentation.
Feb 14 2020, 2:06 PM · MITK
kalali claimed T27100: [MITKDoc] Revise DataManager Plugin Documentation.
Feb 14 2020, 2:01 PM · MITK

Feb 13 2020

kalali renamed T27046: Segmentation View and Multilabel Segmentation must not be active together (toolmanager inconsistency) from Segmentation View and Multilabel Segmentation must not be active together (toolmanager inconsitency) to Segmentation View and Multilabel Segmentation must not be active together (toolmanager inconsistency).
Feb 13 2020, 11:09 AM · MITK

Feb 12 2020

kalali placed T26854: Unattended Qt installation up for grabs.
Feb 12 2020, 3:50 PM · CI, Restricted Project, MITK
kalali added a comment to T27016: Use OpenStack for our CI system.

@kislinsk Could you describe the current status?

Feb 12 2020, 3:40 PM · Restricted Project, CI

Feb 11 2020

kalali triaged T27090: Provide standard NodePredicates as Wishlist priority.
Feb 11 2020, 12:13 PM · Request for Discussion, MITK

Feb 10 2020

kalali added a comment to T27049: Refactor Measurement plugin to use the new node selection widgets.

What planar figures are currently shown. After this task. All? All child figures? Only one?
Depending on that, the new task would have a different priority. The last option would be an obvious regression so the priority to fix it before a releas would become certaintly higher.

Feb 10 2020, 12:28 PM · MITK
kalali updated the task description for T24775: Refactor plugins to use the new node selection widgets.
Feb 10 2020, 12:21 PM · MITK
kalali closed T27049: Refactor Measurement plugin to use the new node selection widgets, a subtask of T24775: Refactor plugins to use the new node selection widgets, as Resolved.
Feb 10 2020, 12:20 PM · MITK
kalali closed T27049: Refactor Measurement plugin to use the new node selection widgets as Resolved.
Feb 10 2020, 12:20 PM · MITK
kalali committed rMITKb818ca572609: Merge branch 'T27049-Measurement-view-with-single-node-selection-widget' (authored by kalali).
Merge branch 'T27049-Measurement-view-with-single-node-selection-widget'
Feb 10 2020, 12:20 PM
kalali committed rMITK218faa8d9a39: Disconnect selection service from the selection widget (authored by kalali).
Disconnect selection service from the selection widget
Feb 10 2020, 12:00 PM
kalali committed rMITKc7befa8af7f0: Use node predicate to only allow images for the selection widget (authored by kalali).
Use node predicate to only allow images for the selection widget
Feb 10 2020, 12:00 PM
kalali committed rMITK35ec40bc8042: Change selection widget strings (authored by kalali).
Change selection widget strings
Feb 10 2020, 11:59 AM
kalali committed rMITK9165f83688a2: Only enable measurement actions if an image node is selected (authored by kalali).
Only enable measurement actions if an image node is selected
Feb 10 2020, 11:59 AM
kalali committed rMITKf54787724cf0: Modernize functions (authored by kalali).
Modernize functions
Feb 10 2020, 11:59 AM