Page MenuHomePhabricator

kalali (Amir Kalali)
Developer

Projects (6)

User Details

User Since
Aug 1 2016, 12:10 PM (268 w, 4 d)

Recent Activity

Thu, Sep 23

kalali closed T24358: Rework QmitkMouseModeSwitcher, a subtask of T24356: Rework mouse mode switcher, as Resolved.
Thu, Sep 23, 10:01 PM · MITK
kalali closed T24358: Rework QmitkMouseModeSwitcher as Resolved.
Thu, Sep 23, 10:01 PM · MITK
kalali committed rMITK9fc6d9258f4e: Clean usage of QmitkInteractionSchemeToolBar and InteractionSchemeSwitcher (authored by kalali).
Clean usage of QmitkInteractionSchemeToolBar and InteractionSchemeSwitcher
Thu, Sep 23, 9:58 PM
kalali committed rMITK99775c5afe86: Remove member variable and create new variable on demand (authored by kalali).
Remove member variable and create new variable on demand
Thu, Sep 23, 9:58 PM
kalali committed rMITKa4b63edd857b: Do not set the interaction scheme (authored by kalali).
Do not set the interaction scheme
Thu, Sep 23, 9:58 PM
kalali committed rMITK556fc11aef9c: Do not explicitly set the visibility of the tool bar (authored by kalali).
Do not explicitly set the visibility of the tool bar
Thu, Sep 23, 9:58 PM
kalali committed rMITK8e756e71766c: Remove unnecessary function, member and header (authored by kalali).
Remove unnecessary function, member and header
Thu, Sep 23, 9:58 PM
kalali awarded T26485: [Segmentation] PACS mode is active while segmentation is drawn a Party Time token.
Thu, Sep 23, 2:39 PM · MITK (v2021.10)

Sun, Sep 19

kalali added a revision to T24358: Rework QmitkMouseModeSwitcher: Unknown Object (Differential Revision).
Sun, Sep 19, 6:29 PM · MITK
kalali reassigned T24368: Interaction scheme has different level of interaction from kalali to s434n.
Sun, Sep 19, 6:26 PM · MITK
kalali added a comment to T24368: Interaction scheme has different level of interaction.

We discussed this and came to the conclusion to abandon D535.
@s434n will take over and create split MITK config files to be consistent with the PACS config file style.
Generally, as mentioned in the previous comment, splitting the config files "into smaller chunks" [...] "allows to change only the aspects of interaction that are necessary".

Sun, Sep 19, 6:26 PM · MITK

Fri, Sep 17

kalali committed rMITK895486021524: Cherry-picked old changes: Remove-QmitkMouseModeSwitcher (authored by kalali).
Cherry-picked old changes: Remove-QmitkMouseModeSwitcher
Fri, Sep 17, 4:03 PM
kalali committed rMITK181d3c4e3fab: Fix wrong slot definition; use new connect-syntax (authored by kalali).
Fix wrong slot definition; use new connect-syntax
Fri, Sep 17, 4:03 PM
kalali committed rMITK4b84f9c383c9: Remove files (authored by kalali).
Remove files
Fri, Sep 17, 4:03 PM
kalali committed rMITK0e9839351823: Modify replacing QmitkInteractionSchemeToolBar (authored by kalali).
Modify replacing QmitkInteractionSchemeToolBar
Fri, Sep 17, 4:03 PM

Wed, Sep 15

kalali committed rMITK00f000b33f60: Do not request a rendering update twice (authored by kalali).
Do not request a rendering update twice
Wed, Sep 15, 5:49 PM
kalali committed rMITK55d690677914: Do not request a rendering update twice (authored by kalali).
Do not request a rendering update twice
Wed, Sep 15, 5:49 PM

Wed, Sep 8

kalali added a member for MIC: m907r.
Wed, Sep 8, 4:17 PM
kalali lowered the priority of T26486: PACS mouse mode does not allow scrolling with mouse wheel from High to Normal.
Wed, Sep 8, 3:42 PM · Request for Discussion, MITK
kalali updated subscribers of T26486: PACS mouse mode does not allow scrolling with mouse wheel.

We decided to talk to @nolden, @metzger or @reicht to learn more about the typical behavior of PACS scrolling. Could you help us here?
Two general questions:

  • in MITK you have to press the wheel and move the mouse to scroll through image slices
    • with this task / differential we change this behavior to simply use the mouse wheel to scroll through image slices
    • what is the typically expected PACS behavior?
Wed, Sep 8, 3:42 PM · Request for Discussion, MITK
kalali added a member for MITK: m907r.
Wed, Sep 8, 11:00 AM
kalali closed T24357: Rework mitkMouseModeSwitcher, a subtask of T24356: Rework mouse mode switcher, as Resolved.
Wed, Sep 8, 8:03 AM · MITK
kalali closed T24357: Rework mitkMouseModeSwitcher as Resolved.
Wed, Sep 8, 8:03 AM · MITK
kalali committed rMITKf9c2a71bbd48: Cherry-picked old changes: Remove-MouseModeSwitcher (authored by kalali).
Cherry-picked old changes: Remove-MouseModeSwitcher
Wed, Sep 8, 8:02 AM
kalali committed rMITKa60c5e2bbe43: Update documentation (authored by kalali).
Update documentation
Wed, Sep 8, 8:02 AM
kalali committed rMITKf5fcb97a9b9a: Remove QmitkMouseModeSwitcher (authored by kalali).
Remove QmitkMouseModeSwitcher
Wed, Sep 8, 8:02 AM
kalali committed rMITKc6b621d0ab99: Adjust test helper to directly work with an interaction observer (authored by kalali).
Adjust test helper to directly work with an interaction observer
Wed, Sep 8, 8:02 AM
kalali committed rMITKd7f117e6e229: Remove files (authored by kalali).
Remove files
Wed, Sep 8, 8:02 AM
kalali committed rMITKf4bda3336afa: Modify replacing mitkInteractionSchemeSwitcher (authored by kalali).
Modify replacing mitkInteractionSchemeSwitcher
Wed, Sep 8, 8:02 AM

Tue, Sep 7

kalali added a project to T26486: PACS mouse mode does not allow scrolling with mouse wheel: Request for Discussion.
Tue, Sep 7, 6:34 PM · Request for Discussion, MITK
kalali added a comment to T26492: [mxn multi widget] Send active render window.

Ok I don't really understand what the changes did and what to expect from the modified code. I just need to react on a mouse pressed event inside a render window. Currently I don't see how this is possible.
I tested building with QtCreator to debug into the Qt-code but that didn't help.

Tue, Sep 7, 6:30 PM · Request for Discussion, MITK
kalali updated the task description for T26496: [mxn multi widget] Re-initializations reset all render windows.
Tue, Sep 7, 9:19 AM · Restricted Project, MITK
kalali added a revision to T26496: [mxn multi widget] Re-initializations reset all render windows: Unknown Object (Differential Revision).
Tue, Sep 7, 9:17 AM · Restricted Project, MITK
kalali committed rMITK8236a73b22bf: Prevent stylesheet inheritance for active render window widgets (authored by kalali).
Prevent stylesheet inheritance for active render window widgets
Tue, Sep 7, 8:23 AM
kalali committed rMITKa4a16fb14597: Prevent stylesheet inheritance for active render window widgets (authored by kalali).
Prevent stylesheet inheritance for active render window widgets
Tue, Sep 7, 8:23 AM
kalali added a revision to T26496: [mxn multi widget] Re-initializations reset all render windows: Unknown Object (Differential Revision).
Tue, Sep 7, 8:19 AM · Restricted Project, MITK
kalali committed rMITKd3668fc1f1dc: Do not initialize views on preferences changes (authored by kalali).
Do not initialize views on preferences changes
Tue, Sep 7, 8:18 AM
kalali committed rMITKdcb5156ea22b: Do not initialize views on preferences changes (authored by kalali).
Do not initialize views on preferences changes
Tue, Sep 7, 8:18 AM

Mon, Sep 6

kalali lowered the priority of T26496: [mxn multi widget] Re-initializations reset all render windows from High to Normal.

I edited the task description since most of the issues do not occur anymore, due to the changed introduced by D523.
However, the general problem remains: It is not possible to re-initialize / reset the view and camera of individual render windows which is important for the MxNMultiWidget in order to fully unleash its potential.

Mon, Sep 6, 2:37 PM · Restricted Project, MITK
kalali updated the task description for T26496: [mxn multi widget] Re-initializations reset all render windows.
Mon, Sep 6, 2:15 PM · Restricted Project, MITK
kalali updated the task description for T26496: [mxn multi widget] Re-initializations reset all render windows.
Mon, Sep 6, 1:53 PM · Restricted Project, MITK
kalali updated the task description for T26496: [mxn multi widget] Re-initializations reset all render windows.
Mon, Sep 6, 1:44 PM · Restricted Project, MITK
kalali closed T28635: [Segmentation] Remove deprecated classes as Resolved.
Mon, Sep 6, 9:18 AM · Cleared, MITK (v2021.10)
kalali committed rMITKb963a9fe4f47: Remove deprecated classes related to segmentation. (authored by kalali).
Remove deprecated classes related to segmentation.
Mon, Sep 6, 9:17 AM
kalali committed rMITKb95801f76874: Remove unused QmitkThresholdAction (authored by kalali).
Remove unused QmitkThresholdAction
Mon, Sep 6, 9:17 AM
kalali committed rMITK696294086464: Update undo/redo description (authored by kalali).
Update undo/redo description
Mon, Sep 6, 9:17 AM
kalali committed rMITKc8043fb0b8bb: Remove deprecated QmitkOtsuAction (authored by kalali).
Remove deprecated QmitkOtsuAction
Mon, Sep 6, 9:17 AM
kalali committed rMITK2f4a2d1e5abc: Remove deprecated OverwriteDirectedPlaneImageFilter (authored by kalali).
Remove deprecated OverwriteDirectedPlaneImageFilter
Mon, Sep 6, 9:17 AM
kalali committed rMITK8431213e6e67: Remove deprecated OverwriteSliceImageFilter (authored by kalali).
Remove deprecated OverwriteSliceImageFilter
Mon, Sep 6, 9:17 AM
kalali closed T28650: [Selection concept] (Re)setting a data storage does not automatically check for matching nodes as Resolved.
Mon, Sep 6, 8:34 AM · MITK (v2021.10)
kalali committed rMITKf10eb4f425bc: Automatically check for matching nodes if data storage is (re)set (authored by kalali).
Automatically check for matching nodes if data storage is (re)set
Mon, Sep 6, 8:34 AM
kalali committed rMITKceb18be89c3c: Rename auto selection mode (authored by kalali).
Rename auto selection mode
Mon, Sep 6, 8:34 AM
kalali committed rMITK75a448132d59: Override `OnDataStorageChanged()` to auto select nodes on event (authored by kalali).
Override `OnDataStorageChanged()` to auto select nodes on event
Mon, Sep 6, 8:34 AM

Wed, Sep 1

kalali raised the priority of T28134: [Multilabel Segmentation] No warning triggered when using different mask geometries in Utilities View from Normal to High.
Wed, Sep 1, 10:35 AM · Restricted Project, Cleared, MITK (v2021.10)
kalali raised the priority of T27810: [Multilabel Segmentation] Inconsistencies and unclear functionality in operations of Utilities view from Normal to High.
Wed, Sep 1, 10:34 AM · Cleared, MITK (v2021.10), Restricted Project

Tue, Aug 31

kalali added a comment to T26492: [mxn multi widget] Send active render window.

I dug deeper into this:
Using the working develop branch (4baa3ceec4) results in return QVTKOpenGLWidget::event(e); being called (line 198 of QmitkRenderWindow.cpp). This leads to this->InteractorAdaptor->ProcessEvent(evt, this->RenderWindow->GetInteractor()); being called (line 610 of QVTKOpenGLWidget).
Debugging inside void QmitkStdMultiWidget::mousePressEvent(QMouseEvent* e) shows that the call is coming from void QmitkRenderWindowWidget::MouseEvent(QMouseEvent * _t1) (the moced signal-function for QmitkRenderWindowWidget::MouseEvent, which is connected inside the QmitkRenderWindowWidget as connect(m_RenderWindow, &QVTKOpenGLWidget::mouseEvent, this, &QmitkRenderWindowWidget::MouseEvent);

Tue, Aug 31, 1:42 PM · Request for Discussion, MITK
kalali added a comment to T26492: [mxn multi widget] Send active render window.

Debugging into e.g. QmitkRenderWindow::event(QEvent* e) or void QmitkStdMultiWidget::mousePressEvent(QMouseEvent* e) shows that the current sender cannot be retrieved.
Using auto sender = this->sender(); returns a nullptr.

Tue, Aug 31, 12:04 AM · Request for Discussion, MITK

Mon, Aug 30

kalali added a comment to T24672: Create decoration manager for render windows widgets.

This seemed to be introduced / not completely fixed with fbc49fc5c831. Fixed it by adding the QmitkRenderWindowWidget class name to explicitly define the border only for this class (as it was already partially done in the mentioned commit).

Mon, Aug 30, 3:18 PM · Restricted Project, MITK
kalali added a revision to T24672: Create decoration manager for render windows widgets: Unknown Object (Differential Revision).
Mon, Aug 30, 3:18 PM · Restricted Project, MITK

Thu, Aug 26

kalali moved T26492: [mxn multi widget] Send active render window from Backlog to MITK Meeting on the Request for Discussion board.
Thu, Aug 26, 6:07 PM · Request for Discussion, MITK
kalali added a project to T26492: [mxn multi widget] Send active render window: Request for Discussion.
Thu, Aug 26, 6:07 PM · Request for Discussion, MITK
kalali updated subscribers of T26492: [mxn multi widget] Send active render window.

This feature should have been merged into master with 70ff72dd6f36 resp. D212.
However, it is not working anymore, I guess this has something to do with b8b5dc64e48c. Just a quick guess, maybe @kislinsk can help.

Thu, Aug 26, 5:40 PM · Request for Discussion, MITK
kalali reopened T24635: PACS scroll leads to an infinite loop if no image is loaded, a subtask of T26486: PACS mouse mode does not allow scrolling with mouse wheel, as Open.
Thu, Aug 26, 4:32 PM · Request for Discussion, MITK
kalali reopened T24635: PACS scroll leads to an infinite loop if no image is loaded as "Open".

If D538 is accepted, 146a8d8 needs to be considered and cherry-picked, too.

Thu, Aug 26, 4:32 PM · MITK
kalali added a subtask for T26486: PACS mouse mode does not allow scrolling with mouse wheel: T24635: PACS scroll leads to an infinite loop if no image is loaded.
Thu, Aug 26, 4:30 PM · Request for Discussion, MITK
kalali added a parent task for T24635: PACS scroll leads to an infinite loop if no image is loaded: T26486: PACS mouse mode does not allow scrolling with mouse wheel.
Thu, Aug 26, 4:30 PM · MITK

Aug 25 2021

kalali added a revision to T26486: PACS mouse mode does not allow scrolling with mouse wheel: Unknown Object (Differential Revision).
Aug 25 2021, 2:27 PM · Request for Discussion, MITK
kalali removed a project from T26486: PACS mouse mode does not allow scrolling with mouse wheel: Restricted Project.
Aug 25 2021, 1:38 PM · Request for Discussion, MITK
kalali claimed T24358: Rework QmitkMouseModeSwitcher.
Aug 25 2021, 1:19 PM · MITK
kalali claimed T24357: Rework mitkMouseModeSwitcher.
Aug 25 2021, 1:19 PM · MITK
kalali added a revision to T24357: Rework mitkMouseModeSwitcher: Unknown Object (Differential Revision).
Aug 25 2021, 1:18 PM · MITK
kalali added a revision to T24358: Rework QmitkMouseModeSwitcher: Unknown Object (Differential Revision).
Aug 25 2021, 11:57 AM · MITK
kalali added a revision to T24368: Interaction scheme has different level of interaction: Unknown Object (Differential Revision).
Aug 25 2021, 11:33 AM · MITK
kalali reopened T26486: PACS mouse mode does not allow scrolling with mouse wheel, a subtask of T24356: Rework mouse mode switcher, as Open.
Aug 25 2021, 9:18 AM · MITK
kalali reopened T26486: PACS mouse mode does not allow scrolling with mouse wheel as "Open".

This task / branch was never merged into master.
For reasons of cleanliness I will open a new branch / differential containing just the changes related to this task such that we can merge the new branch into develop and close this task.
@s434n will help me evaluate the relevance / validity of the changes.

Aug 25 2021, 9:18 AM · Request for Discussion, MITK
kalali added a subtask for T24356: Rework mouse mode switcher: T26486: PACS mouse mode does not allow scrolling with mouse wheel.
Aug 25 2021, 9:17 AM · MITK
kalali edited parent tasks for T26486: PACS mouse mode does not allow scrolling with mouse wheel, added: T24356: Rework mouse mode switcher; removed: Unknown Object (Maniphest Task).
Aug 25 2021, 9:17 AM · Request for Discussion, MITK

Aug 24 2021

kalali updated subscribers of T24357: Rework mitkMouseModeSwitcher.

This task / branch was never merged into master; the mentioned BlackSwan task T26476 is still not contained in master / develop.
For reasons of cleanliness I will open a new branch / differential containing just the changes related to this task such that we can merge the new branch into develop and close this task.
@s434n will help me evaluate the relevance / validity of the changes.

Aug 24 2021, 5:43 PM · MITK
kalali updated subscribers of T24358: Rework QmitkMouseModeSwitcher.

This task / branch was never merged into master; the mentioned BlackSwan task T26476 is still not contained in master / develop.
For reasons of cleanliness I will open a new branch / differential containing just the changes related to this task such that we can merge the new branch into develop and close this task.
@s434n will help me evaluate the relevance / validity of the changes.

Aug 24 2021, 5:43 PM · MITK
kalali reopened T24368: Interaction scheme has different level of interaction as "Open".

This task / branch was never merged into master; the mentioned BlackSwan task T26476 is still not contained in master / develop.
For reasons of cleanliness I will open a new branch / differential containing just the changes related to this task such that we can merge the new branch into develop and close this task.
@s434n will help me evaluate the relevance / validity of the changes.

Aug 24 2021, 5:42 PM · MITK
kalali reopened T24368: Interaction scheme has different level of interaction, a subtask of T24356: Rework mouse mode switcher, as Open.
Aug 24 2021, 5:42 PM · MITK
kalali updated the task description for T24368: Interaction scheme has different level of interaction.
Aug 24 2021, 5:11 PM · MITK
kalali removed a parent task for T26492: [mxn multi widget] Send active render window: Unknown Object (Maniphest Task).
Aug 24 2021, 4:55 PM · Request for Discussion, MITK
kalali added a comment to T27713: [Segmentation] Disable "New" button when no image is selected.

I started working on T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation which makes this task and some mentioned bugs invalid. We can close this task, once D533 is landed. The "New"-button is correctly enabled / disabled using the mentioned changes / differential and some warning messages were removed / simplified.

Aug 24 2021, 4:53 PM · MITK (v2021.10), Request for Discussion
kalali updated subscribers of T24356: Rework mouse mode switcher.
Aug 24 2021, 3:54 PM · MITK
kalali added a comment to T28491: Slice interpolation 'confirm for all slices' not working for large images.

I looked into this using the latest Develop-branch on Windows. Using the Debug build I was able to see the stack trace after a crash (using the small, cropped image):

Exception Unhandled:
Unhandled exception at 0x00007FF96A63AFAC (ucrtbased.dll) in MitkWorkbench.exe: An invalid parameter was passed to a function that considers invalid parameters fatal.
Aug 24 2021, 2:57 PM · MITK (v2021.10)

Aug 23 2021

kalali claimed T28650: [Selection concept] (Re)setting a data storage does not automatically check for matching nodes.
Aug 23 2021, 5:24 PM · MITK (v2021.10)
kalali added a revision to T28650: [Selection concept] (Re)setting a data storage does not automatically check for matching nodes: Unknown Object (Differential Revision).
Aug 23 2021, 5:23 PM · MITK (v2021.10)
kalali added a revision to T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation: Unknown Object (Differential Revision).
Aug 23 2021, 1:17 PM · MITK (v2021.10)
kalali moved T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation from Segmentation to Cycle on the MITK (v2021.10) board.
Aug 23 2021, 1:16 PM · MITK (v2021.10)
kalali claimed T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation.
Aug 23 2021, 1:16 PM · MITK (v2021.10)

Aug 19 2021

kalali added a comment to T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation.

I refactored both views massively. What I did was to somehow bring both plugins in line with each other to see the differences and the similarities. This simplifies to understand how things are implemented and what needs to be done to remove redundancy. I will highlight some points that I find striking:

  • the multilabel plugin view did not compare the world geometry to the selected segmentation node
    • I was able to draw a mask which was then positioned somewhere else (jumped) because of this (e.g. using brain.nrrd)
  • hiding the selected segmentation node disables the tools for the segmentation plugin but not for the multilabel segmentation plugin
  • the auto selection mode for showing / hiding the selected / not selected nodes in the data manager / render windows if the node selection is changed does not work anymore for the segmentation plugin (was already mentioned in T28256: Auto-selection preference for Segmentation View was hijacked for something else)
  • the multilabel segmentation plugin did not listen to render window part changes (no subclass of IRenderWindowPartListener)
  • the multilabel segmentation plugin lists some segmentation tools that don't even exist (FastMarching2D, Two Thresholds Auto Threshold Multiple Otsu)
  • the multilabel segmentation view plugin is not able to accept binary images as a segmentation
Aug 19 2021, 9:24 AM · MITK (v2021.10)

Aug 13 2021

kalali placed T28650: [Selection concept] (Re)setting a data storage does not automatically check for matching nodes up for grabs.
Aug 13 2021, 10:35 AM · MITK (v2021.10)
kalali closed T28226: [Selection concept] Activate auto selection mode per default for the data selection widgets as Resolved.

T28650: [Selection concept] (Re)setting a data storage does not automatically check for matching nodes was opened during the review-process.

Aug 13 2021, 10:34 AM · MITK (v2021.10)
kalali added a comment to T26172: 2D interpolation in MultiLabelSegmentation Editor only works for 1. label .

For now, I wouldn't try to patch in multi-label support into the interpolation class. Instead I would ensure that only a label image (so an image that just contains the active label) is passed to the interpolation class.
I think that that is the most pragmatic approach to it, procure the current implementation will never work properly when multiple labels are present, due to the assumptions already stated by @kalali.

Aug 13 2021, 10:18 AM · Request for Discussion, MITK (v2021.10)

Aug 12 2021

kalali updated the task description for T28635: [Segmentation] Remove deprecated classes.
Aug 12 2021, 4:21 PM · Cleared, MITK (v2021.10)
kalali closed T28490: Segmentation plugin: "new" segmentation should not run reinit!, a subtask of T27613: Improve reinit behavior, as Resolved.
Aug 12 2021, 3:37 PM · MITK (v2021.10)
kalali closed T28490: Segmentation plugin: "new" segmentation should not run reinit! as Resolved.

Has been solved for the segmentation plugin and the multilabel segmentation plugin.
A general reformatting of the resetting-functionality will happen in T27613: Improve reinit behavior.

Aug 12 2021, 3:37 PM · Cleared, MITK (v2021.10)
kalali committed rMITK327fda395735: Preserve view position / do not reset camera / crosshair on new segmentation… (authored by kalali).
Preserve view position / do not reset camera / crosshair on new segmentation…
Aug 12 2021, 3:34 PM
kalali committed rMITK749614ce69af: Preserve view position in multi label plugin view (authored by kalali).
Preserve view position in multi label plugin view
Aug 12 2021, 3:34 PM