Page MenuHomePhabricator
Create Task
Maniphest T28144

CorrectorTool does not properly handle unlocked lables of LabelSet Images
Closed, ResolvedPublic
Actions

Description

How to reproduce:

  • Load an image (e.g. pic3D)
  • Start a ML segmentation
  • Mask a label A and segment some parts of the images (e.g. with Add tool)
  • Unlock label A
  • Make a label B and segment some parts of the images (e.g. with Add tool)
  • Use CorrectorTool to add additional label B areas. Draw the correct contour in such a way that it partially overlaps with label A.
  • Result: The complete area of label A is now also label B. Expected: Only parts of A that are covered by the correction contour should be changed.

Reason: I assume that the CorrectorFilter2D does not work properly and generates a correction result that is also completly includes label A as soon as it is touched. Then the when the result is transfered into the workingslice by WritePreviewOnWorkingImage() it correctly overwrites everything because A is not locked.

Event Timeline

floca triaged this task as Normal priority.Jan 5 2021, 4:41 PM
floca created this task.
floca edited projects, added MITK (v2021.10), Request for Discussion; removed MITK.Apr 12 2021, 9:16 PM

We should discuss if we should not deprecate the old CorrectorTool completly because of several issues and because it adds only very small value to using add/substract with hotkeys directly.

floca moved this task from Backlog to MITK Meeting on the Request for Discussion board.Apr 12 2021, 9:18 PM
floca moved this task from Backlog to Segmentation on the MITK (v2021.10) board.
kislinsk closed this task as Resolved.Jun 2 2021, 11:52 AM
kislinsk claimed this task.
kislinsk added a subscriber: kislinsk.

The tool was already removed from the last release because people tend to use the Add/Subtract tool for the same tasks anyway and we could reduce code/complexity.

MITK · MIC · IMSY · DKFZ