Page MenuHomePhabricator

[Segmentation] QmitkSlicesInterpolator and QmitkSliceBasedInterpolatorWidget seem to be redundant
Closed, ResolvedPublic


Both classes seem to have the same intention / purpose but they do some things slightly differently.
It's is conspicuous that a lot of the source code is duplicated so we should take a closer look into these two classes and merge them, if their purpose is actually the same.
Both classes have been touched and modified within the last year but with different modifications!


The following class has been removed completely

  • QmitkSliceBasedInterpolatorWidget

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision

Event Timeline

kalali triaged this task as Normal priority.Aug 11 2021, 12:44 PM
kalali created this task.
kalali added a subscriber: s349i.

I stumbled upon this again as I was working on an issue with the SliceNavigationController. I suggest to remove the QmitkSliceBasedInterpolatorWidget completely as it is not used anymore.
@s349i is making his changes inside QmitkSlicesInterpolator. As far as I remember QmitkSliceBasedInterpolatorWidget was the interpolation-widget used inside the QmitkMultiLabelSegmentationView, which was removed when the two segmentation views were merged (see 6582705bee86).

kalali added a revision: Restricted Differential Revision.Aug 25 2022, 2:41 PM
kalali edited projects, added MITK (v2022.10); removed MITK.
kalali moved this task from Backlog to Cycle on the MITK (v2022.10) board.
kalali updated the task description. (Show Details)