Page MenuHomePhabricator
Create Task
Maniphest T29089

[3D Segmentation] 3D Segmentation - Color cycle resets with the new layer.
Closed, ResolvedPublic
Actions

Description

From Fabian:

  • Color cycle should continue between layers so that we dont end up with labels of the same color! This is confusing
  • the default for new labels are pretty broken. When I create two labels (New Label 1 and 2), then delete ‘New Label 1’, then add another label I end up with two green ‘New Label 2’:

image.png (94×588 px, 7 KB)

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITKb73c37478dbe Improved generic naming and coloring of newly created labels

Related Objects

Event Timeline

• s349i renamed this task from Color cycle resets with the new layer. to 3D Segmentation - Color cycle resets with the new layer..Mar 30 2022, 2:43 PM
• s349i created this task.
• s349i renamed this task from 3D Segmentation - Color cycle resets with the new layer. to [Segmentation] 3D Segmentation - Color cycle resets with the new layer..Mar 30 2022, 2:55 PM
• s349i renamed this task from [Segmentation] 3D Segmentation - Color cycle resets with the new layer. to [3D Segmentation] 3D Segmentation - Color cycle resets with the new layer..Mar 30 2022, 4:17 PM
kislinsk claimed this task.Apr 1 2022, 9:21 AM
kislinsk triaged this task as Normal priority.
kislinsk added a comment.Apr 1 2022, 9:58 AM

Also: Changing the color of a label in layer != 0, requires a click in a render window to make the changed color visible.

kislinsk closed this task as Resolved.Apr 1 2022, 1:04 PM

Naming and coloring is now fixed in the release branch. Names and colors of new labels will be unique across all layers.

Gaps in generic names like in between two existing labels "New label 1" and "New label 3" after "New label 2" was deleted are not filled up but instead "New label 4" is chosen which mimics for example the naming behavior of Photoshop.

Also, the color still originates from the designated (recently revised!) Multilabel color map but a color is chosen that is not yet or not anymore in use. This of course only works to a certain degree and in extreme cases, after 25 failed attempts it is up to the colormap to come up with a dynamically generated color.

kalali added a subscriber: kalali.Apr 3 2022, 9:21 PM

@kislinsk Could you add commit-links or similar to show how this was resolved?

kislinsk added a commit: rMITKb73c37478dbe: Improved generic naming and coloring of newly created labels.Apr 4 2022, 9:50 AM

Good idea, done.

kislinsk mentioned this in T29110: [Segmentation] Optimize new segmentation view.Apr 4 2022, 9:51 AM
MITK · MIC · IMSY · DKFZ