Page MenuHomePhabricator
Create Task
Maniphest T29110

[Segmentation] Optimize new segmentation view
Closed, ResolvedPublic
Actions

Description

The newly introduced mechanism to automatically create new labels, give them a name and set a distinctive color needs to be improved.
Issues mentioned on the 2022.04 test day:

  • Green + yellow can be hard to distinguish. Default color cycle could be better
  • Maybe continue the color cycle across layers so that we don’t have multiple yellow labels in the image and may not remember what layer they belong to?
  • The color only updates once I interact with the view (click, scroll). It does not update immediately :-(
    • Color does not change immediately. Only after I draw a new mask, the color of all exiting masks with that label change.
  • A newly created label is automatically selected?
    • Was mentioned in a checklist and should be checked, as this is relevant when it comes to using the label and observing the drawn mask color

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITKbb5195b4587d Fix labelset widget issues
Restricted Differential RevisionrMITKe53bc4de30ff Do not explicitly react on label changes
Restricted Differential RevisionrMITK3fbd2c338e0b Get active label on active layer
Restricted Differential RevisionrMITKdfcef20e5356 Observe relevant event for new layers

Related Objects

Event Timeline

kalali triaged this task as High priority.Apr 3 2022, 9:32 PM
kalali created this task.
kislinsk added a subscriber: kislinsk.Apr 4 2022, 9:51 AM

Also see rMITKb73c37478dbe: Improved generic naming and coloring of newly created labels in T29089. I added the commit link there as suggested. :)

kislinsk added a comment.Apr 4 2022, 10:12 AM

BTW, if you are working on this, regarding the color updates that were reported not to be immediate, I can confirm that it only happens on layers != 0.

kislinsk added a comment.Apr 4 2022, 10:14 AM

Oh, I forgot, we should probably rename this task to reflect the things that are missing from the list above. Both label naming and color assignment are the ones that are fixed already.

kalali added a comment.Apr 4 2022, 10:24 AM
This comment was removed by kalali.
kalali renamed this task from [Segmentation] Label naming and automatic color assignment to [Segmentation] Optimize new segmentation view.Apr 4 2022, 10:24 AM
kalali updated the task description. (Show Details)Apr 21 2022, 4:01 PM
kalali added a comment.Apr 21 2022, 4:31 PM

For the labels on layer > 0 to react immediately the connections needed to be established. This is something that was also a problem in several others bugs and is fixed with either https://phabricator.mitk.org/differential/changeset/?ref=57639 or https://phabricator.mitk.org/differential/changeset/?ref=57588

kalali claimed this task.Apr 21 2022, 4:31 PM
kalali updated the task description. (Show Details)
kalali added a comment.Apr 25 2022, 5:12 PM
In T29110#236584, @kalali wrote:

For the labels on layer > 0 to react immediately the connections needed to be established. This is something that was also a problem in several others bugs and is fixed with either https://phabricator.mitk.org/differential/changeset/?ref=57639 or https://phabricator.mitk.org/differential/changeset/?ref=57588

Since both differentials didn't make it into the release we need to fix this manually.

kalali added projects: MITK (v2022.04), Checklist.Apr 25 2022, 5:13 PM
kalali added a revision: Restricted Differential Revision.Apr 25 2022, 10:50 PM
kislinsk edited projects, added Next Milestone, MITK; removed MITK (v2022.04).Apr 29 2022, 1:38 PM
floca edited projects, added MITK (v2022.10); removed MITK, Checklist.May 12 2022, 10:29 AM
floca removed a project: Next Milestone.May 12 2022, 10:42 AM
floca moved this task from Backlog to Segmentation on the MITK (v2022.10) board.May 12 2022, 11:07 AM
kalali moved this task from Segmentation to Cycle on the MITK (v2022.10) board.May 12 2022, 5:16 PM
kalali mentioned this in T29141: [Segmentation] Color change not immediately applied.May 13 2022, 11:46 AM
kalali added a commit: rMITKdfcef20e5356: Observe relevant event for new layers.May 17 2022, 12:55 PM
kalali added a commit: rMITK3fbd2c338e0b: Get active label on active layer.
kalali added a commit: rMITKe53bc4de30ff: Do not explicitly react on label changes.
kalali added a commit: rMITKbb5195b4587d: Fix labelset widget issues.
kalali added a subscriber: floca.EditedMay 17 2022, 1:26 PM
In T29110, @kalali wrote:
  • A newly created label is automatically selected?
    • Was mentioned in a checklist and should be checked, as this is relevant when it comes to using the label and observing the drawn mask color

@kislinsk, @floca Is this a problem? If not, the task can be closed.

Edit: This behavior is desired!

kalali closed this task as Resolved.Jun 1 2022, 2:38 PM
kislinsk mentioned this in T29226: 2022 Week 28 (Mid July).Jul 11 2022, 7:17 AM
MITK · MIC · IMSY · DKFZ