Page MenuHomePhabricator
Create Task
Maniphest T29127

USHardwareTelemed and other IGT classes do not compile because of usage of itkFastMutexLock
Closed, ResolvedPublic
Actions

Description

The (sub)module USHardwareTelemed is only compiled if the path to the Telemed SDK is given in Cmake. Currently, there is a compilation error when activating it. The file itkFastMutexLock.h is not found, e.g. in mitkUSTelemedImageSource.h (https://phabricator.mitk.org/source/mitk/browse/develop/Modules/US/USHardwareTelemed/mitkUSTelemedImageSource.h). Possibly this is because the ITK::FastMutexLock class is deprecated. Needs to be fixed if the telemed system should be used again.

Related Objects

Event Timeline

franza triaged this task as High priority.Apr 8 2022, 12:22 PM
franza created this task.
franza added a comment.Apr 8 2022, 5:53 PM

The same applies to the Polhemus tracker classes, these are only compiled if the Polhemus SDK is activated in Cmake. All this can be fixed with the ITK v5 upgrade (see https://phabricator.mitk.org/w/mitk/changelog/2022.12/). I propose we fix all the mutex problems of the IGT modules in this bug.

franza edited projects, added MITK (v2022.04); removed MITK.Apr 8 2022, 5:54 PM
franza renamed this task from USHardwareTelemed does not compile because of usage of itkFastMutexLock to USHardwareTelemed and other IGT classes do not compile because of usage of itkFastMutexLock.Apr 9 2022, 11:11 AM
franza added a comment.Apr 14 2022, 10:23 AM

A fix for this is available in this pull request: https://github.com/MITK/MITK/pull/257

franza added a project: Pull Request.Apr 14 2022, 10:24 AM
kislinsk closed this task as Resolved.Apr 14 2022, 10:52 AM
kislinsk claimed this task.
kislinsk added a subscriber: kislinsk.

Merged into current release branch.

kislinsk mentioned this in T29075: 2022 Week 17 (Very Late April).Apr 25 2022, 12:43 PM
kislinsk mentioned this in rMITK865b198e19b4: Merge remote-tracking branch 'Alfred-Franz/T29127-IGT-ITKMutexUpdates' into….Apr 25 2022, 3:24 PM
MITK · MIC · IMSY · DKFZ