Page MenuHomePhabricator

[SEG] Improve/correct button names of live wire/lasso tool.
Closed, ResolvedPublic


Wouldn’t “Create Segmentation” and “Clear Contour” be better button names?

Technically it’s not a segmentation if it’s not confirmed/created. I confused the “Clear Segmentation” button with the “Subtract mode” of the tool.

PS: There’s a typo – it’s Subtract and not “Substract”.

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

floca triaged this task as High priority.Oct 10 2022, 5:09 PM
floca created this task.
floca raised the priority of this task from High to Unbreak Now!.Oct 12 2022, 8:50 AM
floca lowered the priority of this task from Unbreak Now! to Needs Triage.
floca moved this task from Backlog to Segmentation on the MITK (v2022.10) board.
floca triaged this task as Normal priority.Oct 13 2022, 10:49 AM
floca added projects: Restricted Project, Cleared.

"Clear Contour" is a good propsal that should be changed.

kalali added a revision: Restricted Differential Revision.Oct 17 2022, 6:56 PM

I changed the strings according to the suggestions in this task.
However, your last comment only stated to rename the "Clear Segmentation" button.

I changed the "confirm"-strings as well but I'm not sure if we should revert this: Other tools also have "Confirm Segmentation" as GUI strings. And if we argue that in their case we already have a segmentation (a preview segmentation) but here we only have an "empty" contour, than we could also think about renaming it to "Confirm Contour"?

The confirm string should not be changed. Result of the discussion was only to change the clear string.