Page MenuHomePhabricator
Create Task
Maniphest T30392

[Segmentation] Totalsegmentator & Otsu is buggy
Closed, ResolvedPublic
Actions

Description

Multiple UI bugs spotted in Totalsegmentator tool on latest develop branch.

  1. After rendering preview segmentations by clicking on "Run totalsegmentator", "Confirm Segmentation" button doesn't get activated automatically. However, "Transfer all labels" radio button is selected by default.
  1. Cannot re-run Totalsegmentator for preview. Immediately, an error message pops up.

totalseg_error.png (913×1 px, 184 KB)

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITK7f413c922d0e Confirm Segmentation button bugfix
Restricted Differential RevisionrMITKfddfdc182dc2 IsPreviewGenerated set to false when tool is activated
Restricted Differential RevisionrMITKb884b24c25b4 TotalSeg nnUNet Confirm Segmentation button bugfix

Related Objects

Event Timeline

a178n created this task.Mon, Apr 8, 9:45 AM
a178n updated the task description. (Show Details)Mon, Apr 8, 9:52 AM
a178n added a comment.Mon, Apr 15, 10:26 AM

Further testing/debugging reveals that the error occurs in TotalSegmentatorTool::UpdatePrepare() method at preview->RemoveLabels(preview->GetAllLabelValues()). More precisely, the LabelSetImage::RemoveLabel method has this->InvokeEvent(LabelRemovedEvent(pixelValue)); which causes the exception. This issue is also applicable for Otsu tool (hence updating the title of this task).

a178n renamed this task from [Segmentation] Totalsegmentator is buggy to [Segmentation] Totalsegmentator & Otsu is buggy.Mon, Apr 15, 10:26 AM
floca claimed this task.Mon, Apr 15, 10:29 AM
floca triaged this task as High priority.
floca moved this task from Backlog to Cycle on the MITK (v2024.06) board.

ok. thanks for investigating. I will have a look.

floca mentioned this in rMITK77685e7bebfa: T30392 Totalsegmentator & Otsu crash with multi label refactor.Tue, Apr 23, 7:35 PM
a178n added a comment.Tue, Apr 23, 9:48 PM

Pushed new branch to rMITK MITK: bugfix/T30392-totalseg-nnunet-confirmbutton.

a178n added a revision: Restricted Differential Revision.Tue, Apr 23, 11:30 PM
a178n added a commit: rMITKb884b24c25b4: TotalSeg nnUNet Confirm Segmentation button bugfix.Wed, Apr 24, 4:27 PM
a178n added a commit: rMITKfddfdc182dc2: IsPreviewGenerated set to false when tool is activated.
a178n added a commit: rMITK7f413c922d0e: Confirm Segmentation button bugfix.
floca closed this task as Resolved.Thu, Apr 25, 9:22 PM
MITK · MIC · IMSY · DKFZ