Page MenuHomePhabricator
Create Task
Maniphest T3125

Remove PlanarFigure related code in CoreUI
Closed, ResolvedPublic
Actions

Description

QmitkNodeDescriptorManager is a CoreUI class.

QmitkNodeDescriptorManager::Initialize() adds NodeDescriptors for PlanarFigure classes, but PlanarFigures are part of MitkExt. NodeDescriptors should therefore be added in MitkExt or QmitkExt or a QmitkExtActivator class in a QmitkExt bundle, if that exists (analogous to DiffusionImaging).

This is nothing serious, but it will help to keep the Core clean.

Can be done by anyone at a bug squashing party.

Event Timeline

neuhaus added projects: MITK, Bugzilla.Dec 3 2009, 3:04 PM
muellerm added a subscriber: muellerm.Jan 13 2010, 4:03 PM

can be done by someone else during bugsquashing -> trivial

maleike added a subscriber: maleike.Jan 13 2010, 5:15 PM

I don't fully understand this. You say

  1. QmitkNodeDescriptorManager is a CoreUI class.
  2. QmitkNodeDescriptorManager::Initialize() adds NodeDescriptors for PlanarFigure

classes

  1. PlanarFigures are part of MitkExt

Unless you use strings to identify classes, these sentences contradict... if 1 and 2, then 3 should not be possible, should never compile...

Michi, could you clarify this and sketch a solution so that anybody would be able to fix this?

maleike added a comment.Jan 27 2010, 5:18 PM

[SVN revision 21137]
FIX (#3125): move registration of icons for planar figures from CoreUI to QmitkExt

maleike added a comment.Jan 27 2010, 5:42 PM

[SVN revision 21138]
FIX (#3125): remove image files from core to clear core of non-core references

maleike added a comment.Jan 27 2010, 6:10 PM

Should be fixed now.

MITK · MIC · IMSY · DKFZ