Page MenuHomePhabricator

maleike (Daniel Maleike)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2016, 12:10 PM (233 w, 3 d)

Recent Activity

Query Overheated

This query took too long, so only some results are shown. Learn More

Nov 4 2020

maleike committed rMITKba631f3b301b: Calculating gizmo translations based on 2D screen coords. (authored by maleike).
Calculating gizmo translations based on 2D screen coords.
Nov 4 2020, 8:05 AM
maleike committed rMITK8a6ed854d15b: Changing the way that QmitkRenderwindow treats incoming Qt events... (authored by maleike).
Changing the way that QmitkRenderwindow treats incoming Qt events...
Nov 4 2020, 7:59 AM
maleike committed rMITK3c0ca99ee601: Re-introduce call to enable render-window menus (removed without intention) (authored by maleike).
Re-introduce call to enable render-window menus (removed without intention)
Nov 4 2020, 7:59 AM

Dec 16 2019

maleike added a comment to T26835: Crash on change of Surface interpolation from Phong to Flat.

FYI: VTK integrated this fix:

Dec 16 2019, 8:40 AM · Pull Request, MITK

Nov 20 2019

maleike updated the task description for T26835: Crash on change of Surface interpolation from Phong to Flat.
Nov 20 2019, 12:23 PM · Pull Request, MITK
maleike assigned T26835: Crash on change of Surface interpolation from Phong to Flat to kislinsk.
Nov 20 2019, 12:23 PM · Pull Request, MITK
maleike added a comment to T26835: Crash on change of Surface interpolation from Phong to Flat.

Fix in https://github.com/MITK/MITK/pull/245, patches VTK

Nov 20 2019, 12:23 PM · Pull Request, MITK
maleike created T26835: Crash on change of Surface interpolation from Phong to Flat.
Nov 20 2019, 12:22 PM · Pull Request, MITK

Nov 19 2019

maleike added a comment to T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling).

@maleike

I re-enabled depth peeling support based on your pull request and also enabled depth peeling for volumes and FXAA. It works well for surfaces and volumes but totally breaks rendering of images/cross hair with opacity < 1. So this is not yet complete and I/we have to fix this before I am able to merge it.

Nov 19 2019, 2:16 PM · MITK, Noteworthy, Pull Request

Nov 13 2019

maleike committed rMITK5487c2164c30: Patch VTK to propagate property keys down VTK assemblies and prop assemblies (authored by maleike).
Patch VTK to propagate property keys down VTK assemblies and prop assemblies
Nov 13 2019, 12:37 PM
kislinsk awarded T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling) a Party Time token.
Nov 13 2019, 12:34 PM · MITK, Noteworthy, Pull Request

Nov 5 2019

maleike committed rMITK23a63241ccee: Forward vtkInformation objects to MITK mappers - enable VTK depth peeling (authored by maleike).
Forward vtkInformation objects to MITK mappers - enable VTK depth peeling
Nov 5 2019, 11:30 AM

Oct 16 2019

maleike added a comment to T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11).

Ok, just created https://github.com/MITK/MITK/pull/240

Oct 16 2019, 1:56 PM · MITK, Pull Request
maleike committed rMITKf435c5354609: Minor cleanup - adapting to review comment by S. Dinkelacker (authored by maleike).
Minor cleanup - adapting to review comment by S. Dinkelacker
Oct 16 2019, 12:02 PM
maleike committed rMITKa2d2c1fc6629: Check filename for invalid characters before attempting to save. (authored by maleike).
Check filename for invalid characters before attempting to save.
Oct 16 2019, 12:02 PM

Oct 15 2019

maleike added a comment to T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11).

I tried the idea described above today and it fixes the behavior of my interactor that uses the mouse wheel in a 3D window. With this patch the MITK interactor gets to see the event first and can decide whether or not is is handled.

Oct 15 2019, 5:47 PM · MITK, Pull Request

Oct 14 2019

maleike created T26745: MITK's interaction not the first to handle events anymore -- QVTKOpenGLWidget::event() changed since VTK 7.0.0 (MITK 2016.11).
Oct 14 2019, 5:28 PM · MITK, Pull Request

Aug 28 2019

maleike added a project to T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling): Noteworthy.
Aug 28 2019, 2:42 PM · MITK, Noteworthy, Pull Request
maleike created T26656: Gitlab pull request 238 (Avoid collapsing 'Properties' view when editing child-properties (e.g. "material.something")).
Aug 28 2019, 2:39 PM · MITK, Pull Request
maleike assigned T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal) to kislinsk.
Aug 28 2019, 2:38 PM · MITK, Pull Request
maleike created T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal).
Aug 28 2019, 2:38 PM · MITK, Pull Request
maleike created T26654: Github pull request 239 (Check filename for invalid characters before saving e.g. "a:b.obj").
Aug 28 2019, 2:37 PM · MITK, Pull Request
maleike created T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling).
Aug 28 2019, 2:35 PM · MITK, Noteworthy, Pull Request

Jun 26 2019

maleike committed rMITK0ab131ef16c4: Add options to skip building the Qt designer plugins (authored by maleike).
Add options to skip building the Qt designer plugins
Jun 26 2019, 10:51 AM
maleike committed rMITK642c83a462bf: Fix quoting (authored by maleike).
Fix quoting
Jun 26 2019, 10:51 AM

Jun 6 2019

maleike added a comment to T26356: Colored render window frames misaligned.

@kislinsk Thanks for your quick fix. I had a look into your changes, this looks very much like an overdue cleanup. Thanks again!

Jun 6 2019, 1:29 PM · MITK
maleike awarded T26356: Colored render window frames misaligned a Pterodactyl token.
Jun 6 2019, 1:27 PM · MITK
maleike awarded rMITK07bb5cafa74d: Align segments of colored render window frames a Orange Medal token.
Jun 6 2019, 1:27 PM

May 29 2019

maleike committed rMITKdd2878fc005d: Remove obsolete code (authored by maleike).
Remove obsolete code
May 29 2019, 9:55 AM
maleike committed rMITK9f0f39a1791b: Fix initialization logic of "levelwindow" (authored by maleike).
Fix initialization logic of "levelwindow"
May 29 2019, 9:55 AM

May 28 2019

maleike added a comment to T26356: Colored render window frames misaligned.

For illustration:

May 28 2019, 8:45 AM · MITK
maleike updated the task description for T26356: Colored render window frames misaligned.
May 28 2019, 8:40 AM · MITK
maleike created T26356: Colored render window frames misaligned.
May 28 2019, 8:39 AM · MITK

May 27 2019

maleike added a comment to T24860: MitkCore seems not to apply a default level/window property ("levelwindow").

I just looked into this again and provided a merge request (https://github.com/MITK/MITK/pull/233). This also merges into the current release/2018-xx branch

May 27 2019, 11:44 AM · MITK

Apr 30 2019

maleike added a comment to T26237: Improve performance for interactions in 2d widgets.

@maleike NV210? According to google this GPU was released in 2003.

Apr 30 2019, 1:57 PM · MITK
maleike added a comment to T26237: Improve performance for interactions in 2d widgets.

(Didn't see latest comments from yesterday evening, was typing the following while only the initial comments of Stefan were visible in my browser)

Apr 30 2019, 12:27 PM · MITK

Mar 29 2019

maleike committed rMITK549d9e53bc6f: Rename for better comprehension/debugging, loosen restrictions (authored by maleike).
Rename for better comprehension/debugging, loosen restrictions
Mar 29 2019, 2:05 PM
maleike committed rMITK5400da64e6f8: Fix 2D display of gizmo, adapt size better to render window and current zoom (authored by maleike).
Fix 2D display of gizmo, adapt size better to render window and current zoom
Mar 29 2019, 2:01 PM
maleike committed rMITK6f78505d55cb: Fix scale factor of gizmo movement (authored by maleike).
Fix scale factor of gizmo movement
Mar 29 2019, 2:01 PM
maleike committed rMITK765603638cb0: When the workbench window is out of the (default) screen, center it. (authored by maleike).
When the workbench window is out of the (default) screen, center it.
Mar 29 2019, 1:56 PM

Mar 13 2019

maleike created T26160: [PR232] Tiny refactoring of BoundingShapeVtkMapper2d.
Mar 13 2019, 12:36 PM · MITK, Pull Request

Mar 12 2019

maleike updated the task description for T26155: [PR231] Unusable window geometry after restart on non-default screen.
Mar 12 2019, 11:17 AM · MITK, Pull Request
maleike created T26156: [PR230] Fix gizmo display and moving.
Mar 12 2019, 11:16 AM · MITK, Pull Request
maleike renamed T26155: [PR231] Unusable window geometry after restart on non-default screen from Integrate github pull request 231 to Github pull request 231 (When the workbench window is out of the (default) screen, center it.).
Mar 12 2019, 11:15 AM · MITK, Pull Request
maleike created T26155: [PR231] Unusable window geometry after restart on non-default screen.
Mar 12 2019, 11:15 AM · MITK, Pull Request

Jun 26 2018

maleike added a comment to T24893: Image Cropper handles missing in 2D (non-axes-aligned image).

I think your idea to add a short notice to Image Croppers UI would already help with the problem. An additional 'reinit' button could also help. However, I would argue against an 'enforced' reinit because this would come as a surprise to the user, potentially unnoticed (objects outside the image would just disappear making some users doubt their perception ;-)

Jun 26 2018, 9:11 AM · Restricted Project, MITK

Jun 25 2018

maleike added a comment to T24893: Image Cropper handles missing in 2D (non-axes-aligned image).

Thanks for looking into this. I just generated a non-axes-aligned image for testing:

Jun 25 2018, 12:29 PM · Restricted Project, MITK

Jun 12 2018

maleike added a comment to T24893: Image Cropper handles missing in 2D (non-axes-aligned image).

@thomass : thanks, that would be great! I just stumbled upon that but won't find the time to analyze the problem (plus the code was a bit lengthy and looked kind of redundant with the 3D mapper's code)

Jun 12 2018, 3:14 PM · Restricted Project, MITK
maleike added a comment to T24893: Image Cropper handles missing in 2D (non-axes-aligned image).

Jun 12 2018, 2:27 PM · Restricted Project, MITK
maleike created T24893: Image Cropper handles missing in 2D (non-axes-aligned image).
Jun 12 2018, 2:26 PM · Restricted Project, MITK

Jun 4 2018

maleike created T24860: MitkCore seems not to apply a default level/window property ("levelwindow").
Jun 4 2018, 9:52 AM · MITK

May 16 2018

maleike created T24781: Integrate pull request #226.
May 16 2018, 10:59 AM · MITK (2018-04), Pull Request

May 7 2018

maleike added a comment to T24716: mitk::ImageDataItem::ComputeItemSize() has 4GB limit.

Great news! Honestly I am surprised that everything just works fine (since nobody every tried this), but this is just very good news! Thank you!

May 7 2018, 3:54 PM · MITK (2018-04)
maleike awarded T24716: mitk::ImageDataItem::ComputeItemSize() has 4GB limit a Doubloon token.
May 7 2018, 3:53 PM · MITK (2018-04)
maleike added a comment to T24716: mitk::ImageDataItem::ComputeItemSize() has 4GB limit.

Suggestion: use size_t instead which is used all over the standard library to denote memory sizes.
Plus: if you find the time, you could try to generate a random/fixed pattern image of 20GB and verify that MitkWorkbench is able to load _and_ display it. This might uncover a couple of related bugs - or just pass perfectly :-)

May 7 2018, 9:18 AM · MITK (2018-04)

Apr 26 2018

maleike created T24716: mitk::ImageDataItem::ComputeItemSize() has 4GB limit.
Apr 26 2018, 9:38 AM · MITK (2018-04)

Apr 24 2018

maleike added a comment to T2627: mitk::SurfaceVtkWriter: Add option for disabling transformation of poly data.

@goetzm: just out of curiosity: this looks like something where a bug + fix is available. Could you share why this is closed 'Wontfix'?

Apr 24 2018, 2:08 PM · Bugzilla, MITK

Apr 23 2018

maleike added a comment to T24333: Noteworthy new features since MITK 2016.11.

Not sure if this was considered a feature (at least I am not aware of documentation): whitelisting modules changed, whitelisting plugins was added since 2016.11.

Apr 23 2018, 1:35 PM · MITK (2018-04)

Mar 29 2018

maleike added a comment to T24519: Speed up CMake fixup bundle.

@goch No, I did not test the script on other platforms than Windows yet. I am surprised to see differences here because I am not aware of modifications other than that caching mechanism that should be working independent of the operation system. If you go through the changes, you might look out to any regex expressions that might be Windows specific..

Mar 29 2018, 11:06 AM · MITK (2018-04)

Mar 27 2018

maleike added a comment to T24519: Speed up CMake fixup bundle.

Good to have your feedback and I am glad that this fix could be helpful for your build. However, I do not fully understand what kind of adaption you would need. Just in case that your problem is that fixup_bundle() clears its cache on each call: I think it should be safe to remove the call to get_prerequisites_clear_cache() in fixup_bundle(). In the latest version the cached result is stored under a name using all parameters passed to get_prerequisites. That should be stable even withour clearing the cache. If this is not sufficient, I am curious to see your use case

Mar 27 2018, 8:21 AM · MITK (2018-04)

Mar 6 2018

maleike committed rMITKdad2acc0f823: Require at least one slice when initializing sliced geometry on objects with… (authored by maleike).
Require at least one slice when initializing sliced geometry on objects with…
Mar 6 2018, 11:51 AM

Sep 18 2017

maleike committed rMITKe5135118b9ff: Merge branch 'master' into gizmo-parts-highlighting-MASTER (authored by maleike).
Merge branch 'master' into gizmo-parts-highlighting-MASTER
Sep 18 2017, 5:51 PM
maleike committed rMITK59ae0b8579ec: Make gizmo track the mouse and highlight parts of the gizmo when under mouse (authored by maleike).
Make gizmo track the mouse and highlight parts of the gizmo when under mouse
Sep 18 2017, 5:51 PM
maleike committed rMITKfdf4846357c1: Merge branch 'master' into change-color-multi-selection-MASTER (authored by maleike).
Merge branch 'master' into change-color-multi-selection-MASTER
Sep 18 2017, 4:36 PM
maleike committed rMITK95ef854a5f6e: Make Data Manager's color button multi-selection-enabled (authored by maleike).
Make Data Manager's color button multi-selection-enabled
Sep 18 2017, 4:35 PM

Sep 14 2017

maleike added a comment to T23292: DataManager does not sort its custom context menu entries.
In T23292#109426, @goch wrote:

There are still a couple of entries that will not be sorted, as they are specifically added by the datamanager itself.


But the suggested solution is better than the current way.

Sep 14 2017, 8:37 PM · Pull Request, MITK

Aug 30 2017

maleike added a comment to T11113: MITK doesn't visualize normalized and thus very small meshes in the expected way..
In T11113#108062, @goch wrote:

However the displayed surface remains solid black for me despite changes in the rendering properties

Aug 30 2017, 2:57 PM · Pull Request, MITK, Bugzilla
maleike created T23317: Pull request 212: Make Data Manager's color button work on multi-selections.
Aug 30 2017, 1:01 PM · Pull Request, MITK

Aug 24 2017

maleike added a comment to T18922: Change VTK rendering backend to OpenGL2.

Hey Daniel, no worries. It wasn't meant to be banned from MITK. I even had to remove my baby MITK Simulation to get things up and running

Aug 24 2017, 4:30 PM · Bugzilla, MITK
maleike created T23295: Pull request 211: Make gizmo track the mouse and highlight parts of the gizmo when under mouse.
Aug 24 2017, 4:13 PM · Pull Request, MITK
maleike added a comment to T23292: DataManager does not sort its custom context menu entries.

Code/Pull request available here: https://github.com/MITK/MITK/pull/209

Aug 24 2017, 11:08 AM · Pull Request, MITK
maleike created T23292: DataManager does not sort its custom context menu entries.
Aug 24 2017, 10:38 AM · Pull Request, MITK
maleike added a comment to T18922: Change VTK rendering backend to OpenGL2.

Had to remove OpenViewCore and QmlItems modules. These modules are not compatible to the OpenGL2 backend. GLEW and QOpenGLFunctions are incompatible as well.

Aug 24 2017, 10:28 AM · Bugzilla, MITK

Aug 23 2017

maleike added a project to T11113: MITK doesn't visualize normalized and thus very small meshes in the expected way.: Pull Request.
Aug 23 2017, 9:19 AM · Pull Request, MITK, Bugzilla

Aug 22 2017

maleike added a comment to T11113: MITK doesn't visualize normalized and thus very small meshes in the expected way..

I also ran into this bug when loading attached small mesh:

Aug 22 2017, 7:01 PM · Pull Request, MITK, Bugzilla