Page MenuHomePhabricator

Measurement to PlanarFigure dependency
Closed, ResolvedPublic

Description

The Measurement bundle has no dependency to planar figure, i.e. it is possible to configure and build MITK with measurement bundle, where the figures are not drawn which makes it slightly unusable.

Event Timeline

planar figure means the bundle org.mitk.planarfigure located at

${MITK_SRC_ROOT}\mitk\Modules\Bundles\org.mitk.planarfigure\

Proposed bug-fix

Using the solution as in the attached patch, the BlueBerry.UI.wrkbncPlg complains about

LOG: Warning: Detected recursive attempt by part org.mitk.views.measurement to create itself

Bug branch pushed (fix based on the attached patch, slightly adapted). Added ChangeRequest since the bug-fix affect also the CoreObjectFactory.

[f40a53]: Merge branch 'bug-4769-MeasurementToPlanarFigureDependency'

Merged commits:

2011-07-29 13:08:43 Jan Hering [59248d]
Added PlanarFigureObjectFactory instantiation.

  • removed Register-call from mitkPlanarFigureActivator.cpp, is now obsolete
  • new static object registerPlanarFigureObjectFactory to ensure the factory get instantiated

2011-07-28 18:07:24 Jan Hering [28feae]
Added missing method for UnRegistering factory

[598d0b]: Merge branch 'bug-4769-MeasurementToPlanarFigureDependency'

Merged commits:

2011-08-11 14:39:04 Jan Hering [1eeae4]
COMP: Avoiding processing with unitialized objects

  • Simplified the implementation of PlanarFigureWriter::CanWriteBaseDataType()
  • avoiding creation of new DataNode using uninitialized data

[c775c6]: Merge branch 'bug-4769-MeasurementToPlanarFigureDependency'

Merged commits:

2011-08-11 14:44:23 Jan Hering [5a1814]
Changed ExtraFactory container to std::set

  • avoids multiple insertions of the same object by multiple calls to CoreObjectFactory::RegisterExtraFactory()