Page MenuHomePhabricator

Program crashes on right click in PointListView/PointListWidget
Closed, ResolvedPublic

Description

When clicking into the the ListWidget, while the SetPoint button is toggled, the program crashes.
Also the Widget doesn't show other time steps.

Event Timeline

Changelog for comming commit:

  • fixed crashing when clicking wrong, caused by an lost pointer on a StdMultiWidget
  • ListView is able to view timesteps (4D) as well. The tooltip and a small label show the change of the timestep.
  • the QmitkPointListView reacts on the mouse wheel event by changing the current timestep. The event has only effect, when the PointSet holds points with diffrent timesteps
  • a small context menue was implemented

[SVN revision 25370]
FIX (#4947): fixed crash caused by a not referenced pointer on the stdMultiWidget

[SVN revision 25373]
COMP (#4947): Added two icons for the move buttons

[SVN revision 25374]
COMP (#4947): fixed warnings

[SVN revision 25376]
COMP (#4947): try to fix failed test

[SVN revision 25377]
COMP (#4947): fixed warnings

[SVN revision 25378]
COMP (#4947): fixed warnings

Found a bug, that the interactor will be unchanged if a point is deleted by the list. I will change it to send an event to interactor rather than to pointset.
+ For this a change in PointListModel is necessary: it needs to hold a smartpointer onto the node to also access the interactor.
+ Furthermore change to not instanciate a new interactor on OnBtnAddPoint but to check if there already is one. Only to create a new in case there is none.
+ Update of widgets on loading new points.
+Remove crash on startup of PointSetInteraction bundle due to segfault

[SVN revision 25519]
FIX (#4947): change a member within PointListModel from mitk::PointSet to mitk::DataNode to also access the interactor. By this change, removing a point via interactor is possible and thus statemachine is not corrupted as before. See T4947 for further documentation

PointListWidget still has a bug: Warning of multiple selected points is displayed if points are selected in widget and then selected in list. Selection of multiple points is a bug! Check to not by-pass the interaction mechanism.

Another Bug: Selecting a point in the list, then moving the same point by mouse interaction and then pressing Del-key doesn't delete the point. It works if the point was selected by mouse.

[SVN revision 25765]
ENH (#4947): Adding support to delete points if no interactor is set to node. See T4947 for further documentation

initial 4D pointset interaction for Widget

[SVN revision 25800]
FIX (#4947): the observer wich observes the delete event of the pointsetnode will now be removed in the destructor.

*Temporal management bug: one timestep to many is shown (data contains timesteps from 0-3 and Widget from 0-4).
*Bug: when removing a pointset from data storage, the button for interaction is still activated. Deactivate on setNewNode

Currently the PointListWidget crashes while trying to set an image fiducial.

m_MultiWidget in QmitkPointListWidget::OnBtnAddPoint() causes the problem. The variable m_MultiWidget is set but only partly initialized...

[SVN revision 26382]
FIX (#4947): Fixed the crash caused by the PoinListWidget in the FiducialRegistrationWidget. The StdMultiWidget has to be set before a PointSet gets passed to the PointListWidget. Also an expander was removed in the view for a clear look.

[SVN revision 26384]
COMP (#4947): Changed initialization order.

The FiducialRegistrationWidget doesn't have a pointset at start.
If the PointListWidget doesn't hold a PointSetNode, all buttons except the save button is disabled. Clicking on it causes a crash.

[SVN revision 26637]
FIX (#4947): Same problem as in the FiducialRegistrationWidget (see revision 26382) was solved here. Before passing a PointSetNode to the PointListWidget the MultiWidget needs to be set.