Page MenuHomePhabricator

Configure errors if source directory path contains spaces
Closed, ResolvedPublic

Description

From the mitk-users list:

CMake Error at C:/Program Files/MITK/src/CMake/CoreHelpers.cmake:138
(INCLUDE):

include could not find load file:

MacroParseArguments

Call Stack (most recent call first):

C:/Program Files/MITK/bin/MITKConfig.cmake:37 (INCLUDE)

CMakeLists.txt:8 (FIND_PACKAGE)

CMake Error at C:/Program Files/MITK/src/CMake/CoreHelpers.cmake:347
(INCLUDE):

include could not find load file:

MITK_ITK_Config

Call Stack (most recent call first):

CMakeLists.txt:10 (MITK_USE_MODULE)

CMake Error at C:/Program Files/MITK/src/CMake/CoreHelpers.cmake:347
(INCLUDE):

include could not find load file:

MITK_Poco_Config

Call Stack (most recent call first):

CMakeLists.txt:10 (MITK_USE_MODULE)

CMake Error at C:/Program Files/MITK/src/CMake/CoreHelpers.cmake:347
(INCLUDE):

include could not find load file:

MITK_QT_Config

Call Stack (most recent call first):

CMakeLists.txt:10 (MITK_USE_MODULE)

CMake Error at C:/Program Files/MITK/src/CMake/CoreHelpers.cmake:347
(INCLUDE):

include could not find load file:

MITK_QVTK_Config

Call Stack (most recent call first):

CMakeLists.txt:10 (MITK_USE_MODULE)

CMake Error at C:/Program Files/MITK/src/CMake/CoreHelpers.cmake:347
(INCLUDE):

include could not find load file:

MITK_VTK_Config

Call Stack (most recent call first):

CMakeLists.txt:10 (MITK_USE_MODULE)

Event Timeline

[SVN revision 27214]
FIX (#5912): configure errors when source path contains blanks

Dart client running with blanks in the path showed following error:

http://cdash.mitk.org/viewBuildError.php?buildid=8044

[SVN revision 27306]
FIX (#5912): Quoting paths in doxygen config file

[SVN revision 27308]
FIX (#5912): Quote paths in cache variables

Dart client successfully configured and built but serval tests failed to pass.

It seems that there still is an unquoted path "somewhere" in the IO Factory...

http://cdash.mitk.org/viewTest.php?onlyfailed&buildid=8092

Resetting all bugs without active assignee flag to "CONFIRMED". Change status to IN_PROGRESS if you are working on it.

I think we have a dartclient now checking this

Re-opening because the problem reappeared. It seems we do not have a dartclient checking this (any more?).

The new continuous dartclients will have spaces in their source and binary trees.

User zelzer has pushed new remote branch:

bug-5912-fix-spaces-in-paths-configure-errors

[b7dd57]: Merge branch 'bug-5912-fix-spaces-in-paths-configure-errors'

Merged commits:

2014-02-19 20:09:53 Sascha Zelzer [497cde]
Merge commit 'a37bb3d71a1230b37d6398844ff01e6dc07a0333' into bug-5912-fix-spaces-in-paths-configure-errors


2014-02-19 20:09:52 Sascha Zelzer [a37bb3]
Squashed 'Core/CppMicroServices/' changes from 5dc70e7..5c3cb00

5c3cb00 Added more quotes and removed internal variable from config file.
0f663b0 Added missing quotes around include statement

git-subtree-dir: Core/CppMicroServices
git-subtree-split: 5c3cb00129750be34596d0589e6ce3a07319a302


2014-02-19 20:08:18 Sascha Zelzer [d6b836]
Added more quotes and small fixes for whitespace support.


2014-02-19 16:18:13 Sascha Zelzer [6673cb]
Merge commit '9fa40430b06b17552c72966cb8b2453785772f4b' into bug-5912-fix-spaces-in-paths-configure-errors


2014-02-19 16:18:12 Sascha Zelzer [9fa404]
Squashed 'Core/CppMicroServices/' changes from 13080ed..5dc70e7

5dc70e7 Properly quote strings for whitespace support in source and binary dirs.
6d140dc Changed CMake directory to lower case.
afdf3f2 Restructured source tree and build system to accommodate additional modules.
2a6417a Another changed coverity variable name
77ab040 Coverity env var names seem to have changed
c50fddc Prepend generated source files for better pch support
e3b4879 Try to suppress non-global environment variables.
33a3d62 Trying cleaner Travis script and added Coverity badge.
bd30c20 Change Travis matrix include statement to array.
a01c36a Added Coverity support to the Travis configuration.
c7b1ed1 Merge branch 'hotfix-11-usResourceCompiler-CMake-variables' into development
6a08b30 Change minor version to development version.
460e806 Merge branch 'release-2.1.0' into development
REVERT: 13080ed Merge branch 'hotfix-11-usResourceCompiler-CMake-variables'

git-subtree-dir: Core/CppMicroServices
git-subtree-split: 5dc70e7e8f46c0b2cd02193884596c5dbed2ad48


2014-02-19 16:09:49 Sascha Zelzer [5c6952]
Fixed white-space issues in the MITK superbuild.

[f9d66c]: COMP: Merge branch 'bug-5912-fix-spaces-in-paths-configure-errors'

Merged commits:

2014-02-19 22:50:12 Sascha Zelzer [bc4905]
Merge commit '4faea21108a28e375660aadb0f527f908f645c6b' into bug-5912-fix-spaces-in-paths-configure-errors


2014-02-19 22:50:12 Sascha Zelzer [4faea2]
Squashed 'Core/CppMicroServices/' changes from 5c3cb00..987e528

987e528 Fixed wrong header include.

git-subtree-dir: Core/CppMicroServices
git-subtree-split: 987e528466d3279dcdf7f955f1595867eaa39e5e

[426264]: COMP: Merge branch 'bug-5912-fix-spaces-in-paths-configure-errors'

Merged commits:

2014-02-20 04:19:38 Sascha Zelzer [50ba29]
Merge commit '03543d80234ed99907f848f296df5409aea6f4ce' into bug-5912-fix-spaces-in-paths-configure-errors


2014-02-20 04:19:38 Sascha Zelzer [03543d]
Squashed 'Core/CppMicroServices/' changes from 987e528..02b3d50

02b3d50 TO_NATIVE_PATH escapes white-space on Linux. Do manual conversion.
50941b3 Don't use -fvisibility=hidden with non-gcc compilers.
289c6d4 Guard against variable name clashes.
fc48252 Use the correct version information in the unit test.
37159dd Use native paths again when passing them to the resource compiler.

git-subtree-dir: Core/CppMicroServices
git-subtree-split: 02b3d50b9764fb698d704b234d14f26ff6da0a8f

[194c44]: COMP: Merge branch 'bug-5912-fix-spaces-in-paths-configure-errors'

Merged commits:

2014-02-20 05:39:38 Sascha Zelzer [65c0f6]
Merge commit '47a2c4b7a9395b9ddd58e5a7286487a36855a8a0' into bug-5912-fix-spaces-in-paths-configure-errors


2014-02-20 05:39:38 Sascha Zelzer [47a2c4]
Squashed 'Core/CppMicroServices/' changes from 02b3d50..6bf9dd4

6bf9dd4 Always set US_HAVE_VISIBILITY_ATTRIBUTE if flags are understood.

git-subtree-dir: Core/CppMicroServices
git-subtree-split: 6bf9dd4e930bcdd60a89ec6098877cfba4741efa

[bcf1c9]: Merge branch 'bug-5912-fix-spaces-in-paths-configure-errors'

Merged commits:

2014-02-21 16:49:32 Sascha Zelzer [62ccf2]
Merge commit '4353da678d86f740980f8b578480b4248049d306' into bug-5912-fix-spaces-in-paths-configure-errors


2014-02-21 16:49:32 Sascha Zelzer [4353da]
Squashed 'Core/CppMicroServices/' changes from 6bf9dd4..21f878f

21f878f Standardize on US_RCC_EXECUTABLE variable naming.

git-subtree-dir: Core/CppMicroServices
git-subtree-split: 21f878fcab8ca385b238f29c5d86e72f993000cc

Current release is finished. Resetting target milestone

Dartclients which test this are up and running