Page MenuHomePhabricator

NSIS_MAKENSIS cmake option not available -> PACKAGE Project missing. Installer generation impossible
Closed, ResolvedPublic

Description

I checked out the repository last Friday (26.11). After generation I could not find the Package project in Visual Studio (XP and Win7). INSTALL is present and creates everything in c:/ProgramFiles/mitk but it is impossible to create an installer. Has anything changed for Win deployment?

Reproduce: With NSIS installed checkout code in a new source folder, create a new bin folder, start cmake and generate with default parameters (activated Boost). ->No NSIS_MAKENSIS option / path in cmake.
Generate and no project PACKAGE is present.

Event Timeline

lot of reports on issues with the installer on windows, will have a look at it now

MITK CPack config was only included for open source builds OR if the 3mapplication bundle is activated. will fix that now. one more note: with the new installer script it is only possible to create installers from Release builds, debug wont work

cc klaus, he also complained about issues with the installer

[SVN revision 28268]
FIX (#6334): making installer available again no matter if 3mapplication bundle is built or not

please test and confirm solution, then close the bug

I made a svn update and let cmake reconfigure the existing project-> No Package project appears. How to add it?

hmm strange. the first workaround is to activate the 3mapplication bundle. this should show up the nsis_makensis option. i will try a new checkout and test again (i test it with an already existing checkout)

ok I made a complete new checkout and ran cmake. after the first configuration run cmake showed me the NSIS_MAKENSIS option. so maybe deleting the cmake cache can help or the previously mentioned workaround

ok the nsis option is available but no package project is visible in the solution, i will have a further look at it

[SVN revision 28286]
COMP (#6334): INCLUDE(CPACK) command which creates the PACKAGE target in the end is now called in every case. INSTALLER SHOULD NOW BE AVAILABLE AGAIN

cc alfred, also had issues. Installer should now work again with the last commit

after update I get the following error in cmake:
CMake Error at C:/Programme/CMake 2.6/share/cmake-2.6/Modules/CPack.cmake:686 (message):

CPack package description file:
"...SOURCEORDNER/MITKCopyright.txt" could not be found.

Call Stack (most recent call first):

C:/Programme/CMake 2.6/share/cmake-2.6/Modules/CPack.cmake:690 (cpack_check_file_exists)
CMakeLists.txt:127 (INCLUDE)

(I replaced the folder structure with SOURCEORDNER...)

when i copy the file from source/mitk/ to source/ then there are no cmake errors and there is a PACKAGE project in VS.

jap same error on the continuous dartclient i`ll have a look ...

[SVN revision 28287]
COMP (#6334): adapted some cpack options to match folder structure of a sandbox checkout

ok some paths needed to be adapted for a sandbox checkout. pls test again

not suitable yet, installs by default in directory ".." with name ... and after installation, there is no startApp Icon, only Uninstall...

yap problem is also known. i will fix this today

[SVN revision 28357]
FIX (#6334): set some values for sandbox app installer hard coded. this will solve the installer problem for now but it is no satisfying solution. to be reviewed in bugsquashing

cc marco, bug scheduled for bugsquashing

[SVN revision 28457]
FIX (#6334): correct revision numbers for Sandbox install

ok tested installer again with the changes. everythin works fine: install with reasonable paths, started sandbox app without problems, uninstall->everything removed.
i`ll close this next week if there are no more issues