HomePhabricator
Diffusion MITK 165ad5f01412

T28356 Make_use_of_coordinate_precision_check

Description

T28356 Make_use_of_coordinate_precision_check

Summary:
BREAKING!!!

What:

  • removed GetCheckPrecision() from mitk::NodePredicateGeometry

and mitk::NodePredicateSubGeometry.

  • removed constant NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION

Why:
The equality functions of geometries (equal and isSubGeometry) do support
coordinate precision and direction precision. This feature was not used
by the predicates so far. But it is needed to allow the predicates to be
a bit less pedantic with differences in coordinate comparisons. These
kind of differences happen with real world data, but have no practical
impact for normal medical imaging, thus should not impact UX.

How to adapt:

  • GetCheckPrecision: Use GetCheckCoordinatePrecision or GetCheckDirectionPrecision instead, depending of which aspect you need.
  • NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION: Use NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_COORDINATE_PRECISION or NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_DIRECTION_PRECISION instead, depending of which aspect you need.

Additionally:
+ Fixed T28356

Test Plan: code review, unit test, check with example data of T28356

Reviewers: O1 MITK Reviewer Group I, kislinsk

Reviewed By: O1 MITK Reviewer Group I, kislinsk

Subscribers: kislinsk

Maniphest Tasks: T28356

Differential Revision: https://phabricator.mitk.org/D476

Details

Provenance
flocaAuthored on Mar 26 2021, 12:40 PM
flocaPushed on Mar 26 2021, 12:41 PM
Reviewer
O1: MITK Reviewer Group I
Differential Revision
Restricted Differential Revision
Parents
rMITK453b6b57f01c: Fixe review remarks (typos)
rMITK2f8b1fac95e7: Patch ITK/OpenJPEG to work with MSVC 16.9
Branches
Unknown
Tags
Unknown
Tasks
T28356: MITK v2021.02 does not recognize loaded mask as segmentation