Fixed pendantic error (T27122)
214ffadee986
Actions

Description

Fixed pendantic error (T27122)

Summary:
Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Corrected predicate checks to work with planar figures.

+ Optimized/corrected the usage of NodeSelectionDialog
+ Checked for T27123. Cannot be repreduced after I have corrected the NodeSelectionDialog usage and internal states.

Signed-off-by: Ralf Floca <r.floca@dkfz-heidelberg.de>

Test Plan: Review and test with problematic data

Reviewers: kalali, O1 MITK Reviewer Group I

Reviewed By: kalali, O1 MITK Reviewer Group I

Maniphest Tasks: T27122

Differential Revision: https://phabricator.mitk.org/D256

Details

Provenance

floca	Authored on Mar 6 2020, 9:47 AM
floca	Pushed on Mar 6 2020, 9:55 AM

Reviewer

O1: MITK Reviewer Group I

Differential Revision

Restricted Differential Revision

Parents

rMITK56f2a0591f22: Optimized NodeSelectionDialog layout.
rMITK42355e69db60: Merge branch 'T27170-MinimalBuild'

Branches

Unknown

Tags

Unknown

Tasks

T27122: PlanarFigureMaskGenerator::GetPrincipalAxis() is too pedantic

Event Timeline

floca committed rMITK214ffadee986: Fixed pendantic error (T27122) (authored by floca).Mar 6 2020, 9:55 AM

floca added a task: T27122: PlanarFigureMaskGenerator::GetPrincipalAxis() is too pedantic.

floca added an edge: Restricted Differential Revision.Apr 30 2020, 9:44 PM

Merged Changes

56f2a0591f22 Optimized NodeSelectionDialog layout.
Author
floca
Browse Repository
No Builds
No Audits
89bc18340d60 Merge remote-tracking branch 'origin/master' into T27122…
Author
floca
Browse Repository
No Builds
No Audits
d3eb1e3950b8 Fixed review remarks
Author
floca
Browse Repository
No Builds
No Audits
1bc874ca325f Fixed mac os compile error
Author
floca
Browse Repository
No Builds
No Audits
22f4683f45cd Fixed review remark
Author
floca
Browse Repository
No Builds
No Audits
e6f056adcbf9 Corrected predicate checks to work with planar figures.
Author
floca
Browse Repository
No Builds
No Audits
d9810797a94b Fixed pendantic error (T27122)
Author
floca
Browse Repository
No Builds
No Audits

Changes (8)

Path

Size

Packages

Modules/

Core/

include/

mitkNodePredicateGeometry.h

O1: MITK Reviewer Group I

ImageStatistics/

mitkPlanarFigureMaskGenerator.cpp

O1: MITK Reviewer Group I

mitkPlanarFigureMaskGenerator.h

O1: MITK Reviewer Group I

Plugins/

org.mitk.gui.qt.common/

src/

QmitkNodeSelectionDialog.cpp

O1: MITK Reviewer Group I

QmitkNodeSelectionDialog.h

O1: MITK Reviewer Group I

QmitkNodeSelectionDialog.ui

O1: MITK Reviewer Group I

org.mitk.gui.qt.measurementtoolbox/

src/

internal/

QmitkImageStatisticsView.cpp

O1: MITK Reviewer Group I

QmitkImageStatisticsView.h

O1: MITK Reviewer Group I

rMITK214ffadee986

View Options

Modules/Core/include/mitkNodePredicateGeometry.h

View Options

Modules/ImageStatistics/mitkPlanarFigureMaskGenerator.cpp

View Options

Modules/ImageStatistics/mitkPlanarFigureMaskGenerator.h

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionDialog.cpp

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionDialog.h

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionDialog.ui

View Options

Plugins/org.mitk.gui.qt.measurementtoolbox/src/internal/QmitkImageStatisticsView.cpp

View Options

Plugins/org.mitk.gui.qt.measurementtoolbox/src/internal/QmitkImageStatisticsView.h

Fixed pendantic error (T27122)214ffadee986Actions

Description

Details

Event Timeline

Merged Changes

Changes (8)

rMITK214ffadee986

Modules/Core/include/mitkNodePredicateGeometry.h

Modules/ImageStatistics/mitkPlanarFigureMaskGenerator.cpp

Modules/ImageStatistics/mitkPlanarFigureMaskGenerator.h

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionDialog.cpp

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionDialog.h

Plugins/org.mitk.gui.qt.common/src/QmitkNodeSelectionDialog.ui

Plugins/org.mitk.gui.qt.measurementtoolbox/src/internal/QmitkImageStatisticsView.cpp

Plugins/org.mitk.gui.qt.measurementtoolbox/src/internal/QmitkImageStatisticsView.h

Fixed pendantic error (T27122)
214ffadee986
Actions