Page MenuHomePhabricator

PlanarFigureMaskGenerator::GetPrincipalAxis() is too pedantic
Open, NormalPublic

Description

Status: Currently we have data sets that are not able to generate the statistics with planar figures.

Reason: PlanarFigureMaskGenerator::GetPrincipalAxis() (Line 369) compares the result (crossmultiplication between the normal vector of the planar and the axis of the image) against 1 and only allows a differencw of mitk::eps (which could be very pedantic).

In the concrete case the result was 0.99995574500963513 instead of 1.

The question is, if this is not close enough for the PlanarFigureMaskGenerator?

Related Objects

StatusAssignedTask
OpenNone

Event Timeline

floca created this task.Wed, Feb 12, 6:37 PM
floca added a parent task: Restricted Maniphest Task.
kislinsk renamed this task from PlanarFigureMaskGenerator::GetPrincipalAxis() is to pedantic to PlanarFigureMaskGenerator::GetPrincipalAxis() is too pedantic.Wed, Feb 12, 6:40 PM
kislinsk triaged this task as Normal priority.

discussion result: Use a larger epsilon in the generator. Document the reason why mitk::eps was not used and refere to this task.