Page MenuHomePhabricator
Create Task
Maniphest T27122

PlanarFigureMaskGenerator::GetPrincipalAxis() is too pedantic
Closed, ResolvedPublic
Actions

Description

Status: Currently we have data sets that are not able to generate the statistics with planar figures.

Reason: PlanarFigureMaskGenerator::GetPrincipalAxis() (Line 369) compares the result (crossmultiplication between the normal vector of the planar and the axis of the image) against 1 and only allows a differencw of mitk::eps (which could be very pedantic).

In the concrete case the result was 0.99995574500963513 instead of 1.

The question is, if this is not close enough for the PlanarFigureMaskGenerator?

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITK214ffadee986 Fixed pendantic error (T27122)
Restricted Differential RevisionrMITK56f2a0591f22 Optimized NodeSelectionDialog layout.
Restricted Differential RevisionrMITK89bc18340d60 Merge remote-tracking branch 'origin/master' into T27122…
Restricted Differential RevisionrMITKd3eb1e3950b8 Fixed review remarks
Restricted Differential RevisionrMITK1bc874ca325f Fixed mac os compile error
Restricted Differential RevisionrMITK22f4683f45cd Fixed review remark
Restricted Differential RevisionrMITKe6f056adcbf9 Corrected predicate checks to work with planar figures.
Restricted Differential RevisionrMITKd9810797a94b Fixed pendantic error (T27122)

Related Objects
Search...

StatusAssignedTask
Restricted Maniphest Task
 ResolvedflocaT27122 PlanarFigureMaskGenerator::GetPrincipalAxis() is too pedantic

Event Timeline

floca created this task.Feb 12 2020, 6:37 PM
floca added a parent task: Restricted Maniphest Task.
kislinsk renamed this task from PlanarFigureMaskGenerator::GetPrincipalAxis() is to pedantic to PlanarFigureMaskGenerator::GetPrincipalAxis() is too pedantic.Feb 12 2020, 6:40 PM
kislinsk triaged this task as Normal priority.
floca moved this task from Backlog to MITK Meeting on the Request for Discussion board.Feb 13 2020, 9:44 PM
floca removed a project: Request for Discussion.Feb 14 2020, 11:54 AM

discussion result: Use a larger epsilon in the generator. Document the reason why mitk::eps was not used and refere to this task.

floca claimed this task.Feb 28 2020, 2:53 PM
floca added a revision: Restricted Differential Revision.Feb 28 2020, 5:37 PM
floca mentioned this in T27123: Wrong value in statistic view for some PlanarFigures constellation.Feb 28 2020, 5:38 PM
floca added a comment.Mar 5 2020, 4:43 PM

Pushed new branch T27122-PlanarFigure_to_pedantic.

floca added a commit: rMITKd9810797a94b: Fixed pendantic error (T27122).Mar 5 2020, 4:43 PM
floca added a commit: rMITKe6f056adcbf9: Corrected predicate checks to work with planar figures..
floca added a commit: rMITK22f4683f45cd: Fixed review remark.
floca added a commit: rMITK1bc874ca325f: Fixed mac os compile error.
floca added a commit: rMITKd3eb1e3950b8: Fixed review remarks.
floca added a commit: rMITK89bc18340d60: Merge remote-tracking branch 'origin/master' into T27122….Mar 6 2020, 9:55 AM
floca added a commit: rMITK56f2a0591f22: Optimized NodeSelectionDialog layout..
floca added a commit: rMITK214ffadee986: Fixed pendantic error (T27122).
floca closed this task as Resolved.Mar 6 2020, 9:56 AM
MITK · MIC · IMSY · DKFZ