HomePhabricator
Diffusion MITK 22173bffdaea

T30287-DICOM_inspector_init
22173bffdaea
Actions

Description

T30287-DICOM_inspector_init

Summary:

  • fixed T30287 - also fixed crash due to dangeling observers by refactoring the view to use QmitkSliceNavigationListener

...change)

Test Plan: code review, test in UI (problems described in T30287 do not happen, behavior is like the property view; Application does not crash if you close dicom inspector again and load a new image)

Reviewers: O3 MITK Reviewer Group II, O1 MITK Reviewer Group I, kislinsk

Reviewed By: O3 MITK Reviewer Group II, O1 MITK Reviewer Group I, kislinsk

Maniphest Tasks: T30287

Differential Revision: https://phabricator.mitk.org/D892

Details

Provenance
flocaAuthored on Nov 29 2023, 4:31 PM
flocaPushed on Nov 29 2023, 5:59 PM
Reviewer
O3: MITK Reviewer Group II
Differential Revision
Restricted Differential Revision
Parents
rMITKd40973bca0c3: - fixed regression in QmitkSliceNavigationListener that was
rMITKb67a466662c0: Merge branch 'arcpatch-D888' into develop
Branches
Unknown
Tags
Unknown
Tasks
Restricted Maniphest Task

Event Timeline

floca committed rMITK22173bffdaea: T30287-DICOM_inspector_init (authored by floca).Nov 29 2023, 5:59 PM
floca added a task: Restricted Maniphest Task.
floca added an edge: Restricted Differential Revision.
kislinsk mentioned this in T30291: 2023 Week 48 (Very Late November).Nov 30 2023, 12:06 AM

Merged Changes

Changes (3)

PathSizePackages
Plugins/
org.mitk.gui.qt.common/
src/
O1: MITK Reviewer Group I
org.mitk.gui.qt.dicominspector/
src/
internal/
O3: MITK Reviewer Group II
O3: MITK Reviewer Group II

rMITK22173bffdaea

View Options

Plugins/org.mitk.gui.qt.common/src/QmitkSliceNavigationListener.cpp

Loading...
View Options

Plugins/org.mitk.gui.qt.dicominspector/src/internal/QmitkDicomInspectorView.cpp

Loading...
View Options

Plugins/org.mitk.gui.qt.dicominspector/src/internal/QmitkDicomInspectorView.h

Loading...
MITK · MIC · IMSY · DKFZ