DicomEventHandler: add generic string handler method (maybe outsource that)
416526d0c3ae
Actions

Description

DicomEventHandler: add generic string handler method (maybe outsource that)

Details

Provenance

• steint	Authored on Apr 9 2018, 3:29 PM
• steint	Pushed on Apr 9 2018, 3:30 PM

Parents

rMITK5fe224ed3442: Merge branch 'T24588-pointlist-fix-multiple-selection-error' Closes T24587

Branches

Tags

Event Timeline

• steint committed rMITK416526d0c3ae: DicomEventHandler: add generic string handler method (maybe outsource that) (authored by • steint).Apr 9 2018, 3:29 PM

See my inline comments. I'm not sure if we should fix the issue like this in general, though. We should do some more checks on how this could be solved platform independent and then try to implement it at a more central place of MITK, as well as writing a test for ensuring the functionality.

/Plugins/org.mitk.gui.qt.dicom/src/internal/DicomEventHandler.cpp
249–256	This doesn't cover Linux for example.
/Plugins/org.mitk.gui.qt.dicom/src/internal/DicomEventHandler.h
66	Instead of a private member function, a static free function in the implementation file would be better encapsulation, i. e. a free function in an anonymous namespace. Also the function name is a bit off, as alone from the name one would expect to receive a ingle character. Why not `getUTF8String()`?