Add chartExistance boolean to avoid #T26790
Audited4fe5206d5ca9
Actions

Description

Add chartExistance boolean to avoid #T26790

Details

Auditors

Provenance

j762e	Authored on Nov 25 2019, 4:46 PM
j762e	Pushed on Nov 25 2019, 5:04 PM

Parents

rMITK9f3eccc8c4ae: Add test driver

Branches

Tags

Event Timeline

j762e committed rMITK4fe5206d5ca9: Add chartExistance boolean to avoid #T26790 (authored by j762e).Nov 25 2019, 4:46 PM

kalali mentioned this in T26790: Workbench crashes when clearing chart data in ChartExample.Nov 27 2019, 10:21 AM

I get two errors:

Modules\ImageStatisticsUI\Qmitk\QmitkHistogramVisualizationWidget.cpp(49): error C2660: 'QmitkChartWidget::Clear': function does not take 0 arguments
Modules\Chart\include\QmitkChartWidget.h(271): note: see declaration of 'QmitkChartWidget::Clear' (compiling source file D:\MITK-BSQ\src\Modules\ImageStatisticsUI\Qmitk\QmitkHistogramVisualizationWidget.cpp)
Modules\ImageStatisticsUI\Qmitk\QmitkIntensityProfileVisualizationWidget.cpp(50): error C2660: 'QmitkChartWidget::Clear': function does not take 0 arguments
Modules\Chart\include\QmitkChartWidget.h(271): note: see declaration of 'QmitkChartWidget::Clear' (compiling source file D:\MITK-BSQ\src\Modules\ImageStatisticsUI\Qmitk\QmitkIntensityProfileVisualizationWidget.cpp)

Could you please check that?
Also, I'm not sure if this bool is still necessary. With all the changes you made I couldn't reproduce the problem when I removed all the chartExistence variables / parameters.

This commit now has outstanding concerns.Nov 27 2019, 11:49 AM

If I remove them the workbench crashed at my computer, but only in Debug Mode

Still an open issue: T26790

All concerns with this commit have now been addressed.Jan 17 2020, 12:28 PM