Page MenuHomePhabricator

j762e (Jan Sahrhage)
User

Projects

User Details

User Since
Sep 9 2019, 1:19 PM (159 w, 6 d)

Recent Activity

Fri, Sep 23

j762e added a comment to T28851: [SEG] Add ITK GrowCut as segmentation tool.

Pushed new branch to rMITK MITK: feature/T28851-AddITKGrowCutTool.

Fri, Sep 23, 5:49 PM · MITK (v2022.10)
j762e added a comment to T29313: Add a Test to check if the GrowCut algorithm produces a different output.

What do you mean with removed? Is the code still somewhere? If it was functional it would make no sense if someone has to write a new test from scratch.

Tests work again. So if the DLL-Exception/failing tests was the reason for removing it, you can add it again.

Fri, Sep 23, 5:46 PM · MITK (v2022.10)
j762e attached a referenced file: F2572275: mitkGrowCutFilterTest.cpp.
Fri, Sep 23, 5:37 PM · MITK (v2022.10)
j762e attached a referenced file: F2572274: files.cmake.
Fri, Sep 23, 5:37 PM · MITK (v2022.10)
j762e attached a referenced file: F2572277: ExpectedResultImage.nrrd.
Fri, Sep 23, 5:37 PM · MITK (v2022.10)
j762e attached a referenced file: F2572276: InputSeedImage.nrrd.
Fri, Sep 23, 5:37 PM · MITK (v2022.10)

Thu, Sep 22

j762e added a comment to T29311: Further observation of the GrowCut segmentation tool on 4D images.

I have added a checklist for growcut into Checklist Segmentation – 3D Segmentation_EN.docx in Nextcloud.
There are no specific test cases (checklists) for other tools on 4D images as far as I know/have seen.
I think this Task should just kept in mind because the growcut tool is new.

Thu, Sep 22, 3:57 PM · MITK (v2022.10)
j762e added a comment to T29313: Add a Test to check if the GrowCut algorithm produces a different output.

I already wrote a test, but removed it for now so I could create the Diff (D712).
Now the Diff needs to be accepted and the T28851-AddImagesForGrowCutSegmentationTest Branch needs to be merged into the mitkdata repository (https://phabricator.mitk.org/source/mitkdata/browse/T28851-AddImagesForGrowCutSegmentationTest/) so that the test does not fail.
I add the files here in case the process is not through before I leave.

Thu, Sep 22, 3:36 PM · MITK (v2022.10)

Wed, Sep 21

j762e triaged T29313: Add a Test to check if the GrowCut algorithm produces a different output as Normal priority.
Wed, Sep 21, 1:39 PM · MITK (v2022.10)
j762e renamed T28851: [SEG] Add ITK GrowCut as segmentation tool from [SEG] Add ITK Growcut as segmentation tool to [SEG] Add ITK GrowCut as segmentation tool.
Wed, Sep 21, 1:33 PM · MITK (v2022.10)
j762e renamed T28851: [SEG] Add ITK GrowCut as segmentation tool from [SEG] Evaluate if we should add itkGrowCut as a tool to [SEG] Add ITK Growcut as segmentation tool.
Wed, Sep 21, 1:33 PM · MITK (v2022.10)
j762e triaged T29312: Add support for using layers other than layer 0 of the current LabelSetImage as Wishlist priority.
Wed, Sep 21, 1:29 PM · MITK (v2022.10)
j762e triaged T29311: Further observation of the GrowCut segmentation tool on 4D images as Normal priority.
Wed, Sep 21, 1:26 PM · MITK (v2022.10)
j762e triaged T29310: [ITK] Check if ITK 5.3 adds the GrowCut remote module by default as Normal priority.
Wed, Sep 21, 1:24 PM · MITK (v2022.10)
j762e triaged T29309: [GrowCut] Further remarks regarding GrowCut as Low priority.
Wed, Sep 21, 1:22 PM · MITK (v2022.10)

Tue, Sep 20

j762e added a comment to T28851: [SEG] Add ITK GrowCut as segmentation tool.

Some further remarks as I am leaving DKFZ:

Tue, Sep 20, 3:33 PM · MITK (v2022.10)

Tue, Sep 13

j762e added a comment to T28851: [SEG] Add ITK GrowCut as segmentation tool.

Deleted branch from rMITK MITK: feature/T28851-AddITKGrowCutTool.

Tue, Sep 13, 2:59 PM · MITK (v2022.10)

Tue, Sep 6

j762e triaged T29284: Refactor segmentation plugin user manual documentation as Low priority.
Tue, Sep 6, 3:08 PM · MITK (v2022.10)

Jun 24 2022

j762e claimed T28851: [SEG] Add ITK GrowCut as segmentation tool.
Jun 24 2022, 3:46 PM · MITK (v2022.10)
j762e added a comment to T28851: [SEG] Add ITK GrowCut as segmentation tool.

In newer versions of ITK the GrowCut.remote.cmake is added by default to Remote Modules (eg. https://github.com/InsightSoftwareConsortium/ITK/tree/master/Modules/Remote).
Our version of ITK (https://www.mitk.org/download/thirdparty/) doesn't include that yet.
rMITKc94224c7fe81 is a "workaround" to still add the Remote Module without changing the present version of ITK on our server and might be reverted in future.

Jun 24 2022, 1:28 PM · MITK (v2022.10)
j762e added a comment to T28851: [SEG] Add ITK GrowCut as segmentation tool.

Pushed new branch to rMITK MITK: feature/T28851-AddITKGrowCutTool.

Jun 24 2022, 12:55 PM · MITK (v2022.10)

Jan 10 2022

j762e triaged T28923: Superbuild wont build if path is either too long or contains special character as Normal priority.
Jan 10 2022, 12:11 PM · MITK, Next Milestone

Apr 30 2020

j762e closed T27297: Add tests for ImageStatisticsContainer, a subtask of T27296: [ImageStatistics] Code coverage intensification, as Resolved.
Apr 30 2020, 10:28 AM · Auto-closed, MITK
j762e closed T27297: Add tests for ImageStatisticsContainer as Resolved.
Apr 30 2020, 10:28 AM · MITK

Apr 28 2020

j762e committed rMITKd0e4d5a6dfa5: Add test to files.cmake (authored by j762e).
Add test to files.cmake
Apr 28 2020, 10:29 PM
j762e committed rMITKb95689472b9d: Add newline (authored by j762e).
Add newline
Apr 28 2020, 10:29 PM
j762e committed rMITK988cdb5c7311: Fix concern (authored by j762e).
Fix concern
Apr 28 2020, 8:38 PM

Apr 26 2020

j762e committed rMITK9564428ee562: Correct AllStatisticNamesForContainer() Test (authored by j762e).
Correct AllStatisticNamesForContainer() Test
Apr 26 2020, 2:26 PM
j762e committed rMITKe359edec272e: Add check for print function for empty container (authored by j762e).
Add check for print function for empty container
Apr 26 2020, 2:26 PM

Apr 17 2020

j762e committed rMITKcf0a116956c7: Expand TimeStepsTest (authored by j762e).
Expand TimeStepsTest
Apr 17 2020, 3:33 PM
j762e committed rMITK970e0ca6af82: Extend InternalCloneTest (authored by j762e).
Extend InternalCloneTest
Apr 17 2020, 3:33 PM
j762e committed rMITKda6b13dcd728: Add a test to check if empty container trigger an exception if… (authored by j762e).
Add a test to check if empty container trigger an exception if…
Apr 17 2020, 3:33 PM
j762e committed rMITK318208495e06: Adapt printTest to just check if no exception is thrown (authored by j762e).
Adapt printTest to just check if no exception is thrown
Apr 17 2020, 3:33 PM
j762e committed rMITK2c8733588d91: Correct StatisticNamesTest (authored by j762e).
Correct StatisticNamesTest
Apr 17 2020, 3:33 PM
j762e committed rMITKe80ab3d3159d: Add a test to check if an existing statistic is overwritten (authored by j762e).
Add a test to check if an existing statistic is overwritten
Apr 17 2020, 3:33 PM
j762e committed rMITK667ed2c554cd: Remove unnecessary includes (authored by j762e).
Remove unnecessary includes
Apr 17 2020, 3:33 PM
j762e committed rMITKcb38c6bc0e52: Apply naming convention (authored by j762e).
Apply naming convention
Apr 17 2020, 3:33 PM
j762e committed rMITK3437886b97c8: Remove CreateNodeRelationImage function (authored by j762e).
Remove CreateNodeRelationImage function
Apr 17 2020, 3:33 PM

Apr 14 2020

j762e added a comment to T27297: Add tests for ImageStatisticsContainer.

Pushed new branch T27297-Add_tests_for_ImageStatisticsContainer.

Apr 14 2020, 5:03 PM · MITK

Apr 8 2020

j762e added a comment to T27289: Different coverage results with OpenCppCoverage and Gcov.

I executed all tests in files.cmake, which are: mitkImageStatisticsCalculatorTest, mitkPointSetStatisticsCalculatorTest, mitkPointSetDifferenceStatisticsCalculatorTest, mitkImageStatisticsTextureAnalysisTest, mitkImageStatisticsContainerManagerTest and mitkImageStatisticsHotspotTest.
But I think the reason for the different results might be that opencppcoverage does not use any testfiles and cannot load pictures because it cannot find these and there is no option to pass them to opencppcoverage.

Apr 8 2020, 11:59 AM · Auto-closed, Restricted Project, MITK

Apr 6 2020

j762e updated the task description for T27296: [ImageStatistics] Code coverage intensification.
Apr 6 2020, 10:48 AM · Auto-closed, MITK
j762e triaged T27297: Add tests for ImageStatisticsContainer as Normal priority.
Apr 6 2020, 10:47 AM · MITK
j762e added a parent task for T26098: [ImageStatistics] Histogram Statistics need to be tested: T27296: [ImageStatistics] Code coverage intensification.
Apr 6 2020, 10:43 AM · MITK, Next Milestone, Restricted Project
j762e added a subtask for T27296: [ImageStatistics] Code coverage intensification: T26098: [ImageStatistics] Histogram Statistics need to be tested.
Apr 6 2020, 10:43 AM · Auto-closed, MITK
j762e triaged T27296: [ImageStatistics] Code coverage intensification as Normal priority.
Apr 6 2020, 10:41 AM · Auto-closed, MITK
j762e created T27296: [ImageStatistics] Code coverage intensification.
Apr 6 2020, 10:41 AM · Auto-closed, MITK

Apr 3 2020

j762e triaged T27289: Different coverage results with OpenCppCoverage and Gcov as Normal priority.
Apr 3 2020, 1:47 PM · Auto-closed, Restricted Project, MITK
j762e created T27289: Different coverage results with OpenCppCoverage and Gcov.
Apr 3 2020, 1:47 PM · Auto-closed, Restricted Project, MITK

Dec 3 2019

j762e committed rMITK4b80587b8479: Merge branch 'T26777-GCC-Fix' (authored by j762e).
Merge branch 'T26777-GCC-Fix'
Dec 3 2019, 4:08 PM
j762e committed rMITK3b1048ef882d: Disable ChartTestDriver due to incomplete test definition (authored by j762e).
Disable ChartTestDriver due to incomplete test definition
Dec 3 2019, 4:05 PM
j762e committed rMITK1d8cd949d16c: Merge branch 'T26777-GCC-Fix' (authored by j762e).
Merge branch 'T26777-GCC-Fix'
Dec 3 2019, 11:13 AM
j762e committed rMITKe577df4c1b0e: Fix compiler error (authored by j762e).
Fix compiler error
Dec 3 2019, 11:13 AM

Dec 2 2019

j762e committed rMITKf546a2e440ef: Merge branch 'T26777-GCC-Fix' (authored by j762e).
Merge branch 'T26777-GCC-Fix'
Dec 2 2019, 6:03 PM
j762e committed rMITK74c7f8746848: Correct use of map.insert() (authored by j762e).
Correct use of map.insert()
Dec 2 2019, 6:02 PM
j762e committed rMITKb75db92e40e1: Merge branch 'T26777-GCC-Fix' (authored by j762e).
Merge branch 'T26777-GCC-Fix'
Dec 2 2019, 5:22 PM
j762e committed rMITKd2b7f66cc1e2: std::map::insert_or_assign is only in C++ starting from C++17 (authored by j762e).
std::map::insert_or_assign is only in C++ starting from C++17
Dec 2 2019, 5:21 PM
j762e added a comment to T26777: Refactoring QmitkChartExample.

Pushed new branch T26777-GCC-Fix.

Dec 2 2019, 5:20 PM · Auto-closed, MITK
j762e committed rMITK9a7b5772bc79: Merge branch 'T26777-Refactor-QmitkChartWidget' (authored by j762e).
Merge branch 'T26777-Refactor-QmitkChartWidget'
Dec 2 2019, 5:00 PM
j762e committed rMITK4f7ded44047a: Refactor save of pieLabels (authored by j762e).
Refactor save of pieLabels
Dec 2 2019, 1:23 PM
j762e committed rMITK23366ca51ce4: SetCurrentText of comboBoxes directly by string (authored by j762e).
SetCurrentText of comboBoxes directly by string
Dec 2 2019, 1:23 PM
j762e committed rMITK3b358cae68b9: Adapt hardcoded comparison of strings (authored by j762e).
Adapt hardcoded comparison of strings
Dec 2 2019, 1:23 PM
j762e committed rMITKa7b4e993e201: Adapt the updateData function by adding a UpdateChartExampleData() function to… (authored by j762e).
Adapt the updateData function by adding a UpdateChartExampleData() function to…
Dec 2 2019, 1:23 PM
j762e committed rMITK99c91aa4e660: Remove .toLower() because its already lower in the .ui file (authored by j762e).
Remove .toLower() because its already lower in the .ui file
Dec 2 2019, 1:23 PM
j762e committed rMITK7b1c7eccf730: Adapt Include-Guard due to renaming the file (authored by j762e).
Adapt Include-Guard due to renaming the file
Dec 2 2019, 1:23 PM
j762e committed rMITK30066636fdc1: Add ConvertToText function that takes QVariantList (authored by j762e).
Add ConvertToText function that takes QVariantList
Dec 2 2019, 1:22 PM
j762e committed rMITK9d9cae87f8be: Re-Add override and nullptr instead of 0 (authored by j762e).
Re-Add override and nullptr instead of 0
Dec 2 2019, 1:22 PM
j762e committed rMITK4998d268a7ff: Erase GetIndexByString function and depending string vectors (authored by j762e).
Erase GetIndexByString function and depending string vectors
Dec 2 2019, 1:22 PM
j762e committed rMITK8a54f26a0988: Change comboBox items of color, type and linestyle to lower due to conflicts… (authored by j762e).
Change comboBox items of color, type and linestyle to lower due to conflicts…
Dec 2 2019, 1:22 PM

Nov 27 2019

j762e committed rMITKb6992664bb45: Remove emplacement for lineType & clarify naming of it (authored by j762e).
Remove emplacement for lineType & clarify naming of it
Nov 27 2019, 5:45 PM
j762e committed rMITKbb4e83cc238f: Remove unnecessary variables (authored by j762e).
Remove unnecessary variables
Nov 27 2019, 5:22 PM
j762e committed rMITK7cff462e7484: Change name to QmitkChartExampleView (authored by j762e).
Change name to QmitkChartExampleView
Nov 27 2019, 2:25 PM
j762e committed rMITK6ca3be5448eb: Rename ChartExample to QmitkChartExampleView (authored by j762e).
Rename ChartExample to QmitkChartExampleView
Nov 27 2019, 2:25 PM
j762e committed rMITKb1bf2fd99dff: Removing unnecessary dependencies and set() (authored by j762e).
Removing unnecessary dependencies and set()
Nov 27 2019, 2:25 PM
j762e committed rMITK7217229045df: Remove chartExistence boolean to avoid workaround (authored by j762e).
Remove chartExistence boolean to avoid workaround
Nov 27 2019, 2:25 PM
j762e placed T26790: Workbench crashes when clearing chart data in ChartExample up for grabs.
Nov 27 2019, 1:15 PM · Restricted Project, MITK
j762e reopened T26790: Workbench crashes when clearing chart data in ChartExample as "Open".
Nov 27 2019, 1:14 PM · Restricted Project, MITK
j762e committed rMITKc77d3d4e6e74: Add newlines (authored by j762e).
Add newlines
Nov 27 2019, 12:33 PM
j762e committed rMITK45e3b8eabe97: Add default arguments for clear functions (authored by j762e).
Add default arguments for clear functions
Nov 27 2019, 12:31 PM
j762e committed rMITK2bb676acf3f1: Remove unnecessary emplacements (authored by j762e).
Remove unnecessary emplacements
Nov 27 2019, 12:31 PM
j762e added a comment to rMITK4fe5206d5ca9: Add chartExistance boolean to avoid #T26790.

If I remove them the workbench crashed at my computer, but only in Debug Mode

Nov 27 2019, 12:31 PM
j762e closed T26790: Workbench crashes when clearing chart data in ChartExample as Resolved.
Nov 27 2019, 10:59 AM · Restricted Project, MITK
j762e claimed T26790: Workbench crashes when clearing chart data in ChartExample.
Nov 27 2019, 10:59 AM · Restricted Project, MITK
j762e added a comment to T26790: Workbench crashes when clearing chart data in ChartExample.
Nov 27 2019, 10:59 AM · Restricted Project, MITK

Nov 25 2019

j762e committed rMITK56ef3218a034: Rearrange functions to an appropriate location (authored by j762e).
Rearrange functions to an appropriate location
Nov 25 2019, 5:05 PM
j762e committed rMITK3828ccbb401e: Make some unnecessarily public functions private (authored by j762e).
Make some unnecessarily public functions private
Nov 25 2019, 5:05 PM
j762e committed rMITK726b04a3e631: Refactor AddChartExampleData to avoid converting (authored by j762e).
Refactor AddChartExampleData to avoid converting
Nov 25 2019, 5:05 PM
j762e committed rMITK1283b8222c0e: Add setUp and tearDown functionality (authored by j762e).
Add setUp and tearDown functionality
Nov 25 2019, 5:05 PM
j762e committed rMITKde875065927d: Adapt CMake (authored by j762e).
Adapt CMake
Nov 25 2019, 5:05 PM
j762e committed rMITKcf13406d8478: Move TestExampleHelper outside of test dir (authored by j762e).
Move TestExampleHelper outside of test dir
Nov 25 2019, 5:05 PM
j762e committed rMITK5bdfc4c4048e: Avoid repeated converting (authored by j762e).
Avoid repeated converting
Nov 25 2019, 5:05 PM
j762e committed rMITKbe64b0e66a24: Re-add emplace functionality (authored by j762e).
Re-add emplace functionality
Nov 25 2019, 5:05 PM
j762e committed rMITK86d101c39ec2: Rearrange ::Impl::GetThemeName() function (authored by j762e).
Rearrange ::Impl::GetThemeName() function
Nov 25 2019, 5:05 PM
j762e committed rMITK4fe5206d5ca9: Add chartExistance boolean to avoid #T26790 (authored by j762e).
Add chartExistance boolean to avoid #T26790
Nov 25 2019, 5:04 PM
j762e committed rMITK9f3eccc8c4ae: Add test driver (authored by j762e).
Add test driver
Nov 25 2019, 5:04 PM
j762e committed rMITK0d7e89ce4c44: Reorder functions, improve readability (authored by j762e).
Reorder functions, improve readability
Nov 25 2019, 5:04 PM
j762e committed rMITK461d97787618: Re-add override (authored by j762e).
Re-add override
Nov 25 2019, 5:04 PM

Nov 6 2019

j762e updated subscribers of T26790: Workbench crashes when clearing chart data in ChartExample.
Nov 6 2019, 10:44 AM · Restricted Project, MITK

Nov 5 2019

j762e committed rMITK026358ce529e: Set LabelInfo text to red (authored by j762e).
Set LabelInfo text to red
Nov 5 2019, 2:25 PM
j762e triaged T26790: Workbench crashes when clearing chart data in ChartExample as Normal priority.
Nov 5 2019, 2:12 PM · Restricted Project, MITK
j762e committed rMITK2ef6a51b13de: Add emplace (authored by j762e).
Add emplace
Nov 5 2019, 1:57 PM