HomePhabricator
Diffusion MITK 9564428ee562

Correct AllStatisticNamesForContainer() Test
Audited9564428ee562
Actions

Description

Correct AllStatisticNamesForContainer() Test

Details

Auditors
kalali
Provenance
j762eAuthored on Apr 26 2020, 2:26 PM
j762ePushed on Apr 26 2020, 2:26 PM
Parents
rMITKe359edec272e: Add check for print function for empty container
Branches
Loading...
Tags
Loading...

Event Timeline

j762e committed rMITK9564428ee562: Correct AllStatisticNamesForContainer() Test (authored by j762e).Apr 26 2020, 2:26 PM
kalali raised a concern with this commit.Apr 27 2020, 1:22 PM
kalali added a subscriber: kalali.
kalali added inline comments.
/Modules/ImageStatistics/Testing/mitkImageStatisticsContainerTest.cpp
330

I still don't get it: With empty containers, do you mean m_StatisticsContainer2 and m_StatisticsContainer3 or containers?
I thought it would make sense to call mitk::GetAllStatisticNames(containers)); before any containers.push_back, so that the vector is empty.
And then you could push back statistics container, which are actually defined, but do not contain data. And then you could add the statistics container as in line 334, where you have some statistics data stored.

This commit now has outstanding concerns.Apr 27 2020, 1:22 PM
kalali accepted this commit.Dec 22 2020, 9:04 AM
All concerns with this commit have now been addressed.Dec 22 2020, 9:04 AM

Changes (1)

PathSizePackages
Modules/
ImageStatistics/
Testing/
O1: MITK Reviewer Group I

rMITK9564428ee562

View Options

Modules/ImageStatistics/Testing/mitkImageStatisticsContainerTest.cpp

Loading...
MITK · MIC · IMSY · DKFZ