Diffusion MITK 978e3fbf6328

Introduced ModelFitResultRelationRule
978e3fbf6328
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Introduced ModelFitResultRelationRule

Summary:
Corrected include guard

Corrected ModelFit property description

Added ModelFitResultRelationRule

Deprecated old modelfit UID scheme (now uses property rule)

renamed deprecated UID constants
removed code that was only needed for the old UID scheme (now covered by the rule)
refactored code and unittest accordingly

Fixed T26142 by adding persistency for needed PropertyRule properties.

Fixed business logic in the ModelFitInspectorView to also handle fit result correctly when the data nodes are not stored hierarchicaly in the data storage.

+ Fixed T27459

CONTAINES BREAKING CHANGES

Test Plan: Review, unit testing, Application test (check the different fit generators generic, MR perfusion, PET)

Reviewers: O3 MITK Reviewer Group II, O1 MITK Reviewer Group I, kompan, kalali

Reviewed By: O3 MITK Reviewer Group II, O1 MITK Reviewer Group I, kompan, kalali

Subscribers: kalali, kislinsk

Maniphest Tasks: T27459, T26142

Differential Revision: https://phabricator.mitk.org/D324

Details

Provenance

floca	Authored on Jul 24 2020, 2:54 PM
floca	Pushed on Jul 29 2020, 10:25 AM

Reviewer

O3: MITK Reviewer Group II

Differential Revision

Restricted Differential Revision

Parents

rMITKb9af16068179: Fixed review remarks
rMITK1b30808db9e5: Revise Movie Maker documentation

Branches

Unknown

Tags

Unknown

Tasks

T26142: Property persistence for property relation instance identifing (RII) properties
T27459: [Perfusion] Use PropertyReleationRules for referencing between input image and parameter maps

Event Timeline

floca committed rMITK978e3fbf6328: Introduced ModelFitResultRelationRule (authored by floca).Jul 29 2020, 10:26 AM

floca added an edge: Restricted Differential Revision.

floca added a task: T27459: [Perfusion] Use PropertyReleationRules for referencing between input image and parameter maps.

floca added a task: T26142: Property persistence for property relation instance identifing (RII) properties.

kislinsk mentioned this in T27638: 2020 Week 31.Jul 31 2020, 1:33 PM

Merged Changes

b9af16068179 Fixed review remarks
Author
floca
Browse Repository
No Builds
No Audits
1b57565cf609 Fixed gcc compile errors
Author
floca
Browse Repository
No Builds
No Audits
154cd9ee0f1c Improved test coverage of SourceImageRelationRule and ModelFitResultRelationRule
Author
floca
Browse Repository
No Builds
No Audits
a1f71ea0ee6f Fixed business logic in the ModelFitInspectorView
Author
floca
Browse Repository
No Builds
No Audits
58e8ee2b8bd9 Fixed T26142 by adding persistency for needed PropertyRule properties.
Author
floca
Browse Repository
No Builds
No Audits
98394bbae559 Deprecated old modelfit UID scheme (now uses property rule)
Author
floca
Browse Repository
No Builds
No Audits
826398b541aa Added ModelFitResultRelationRule
Author
floca
Browse Repository
No Builds
No Audits
bf292f6e9d09 Corrected ModelFit property description
Author
floca
Browse Repository
No Builds
No Audits
7648cacdc58c Corrected include guard
Author
floca
Browse Repository
No Builds
No Audits

Changes (32)

Path

Size

Packages

Modules/

Core/

include/

mitkPropertyRelationRuleBase.h

O1: MITK Reviewer Group I

mitkSourceImageRelationRule.h

O1: MITK Reviewer Group I

src/

DataManagement/

mitkPropertyRelationRuleBase.cpp

O1: MITK Reviewer Group I

mitkSourceImageRelationRule.cpp

O1: MITK Reviewer Group I

mitkCoreActivator.cpp

O1: MITK Reviewer Group I

test/

mitkPropertyRelationRuleBaseTest.cpp

O1: MITK Reviewer Group I

mitkSourceImageRelationRuleTest.cpp

O1: MITK Reviewer Group I

DICOMReader/

src/

mitkDICOMTagsOfInterestHelper.cpp

ModelFit/

autoload/

IO/

mitkModelFitIOActivator.cpp

O3: MITK Reviewer Group II

O3: MITK Reviewer Group II

include/

mitkModelFitConstants.h

O3: MITK Reviewer Group II

mitkModelFitInfo.h

O3: MITK Reviewer Group II

mitkModelFitParameter.h

O3: MITK Reviewer Group II

mitkModelFitResultRelationRule.h

O3: MITK Reviewer Group II

mitkModelFitUIDHelper.h

O3: MITK Reviewer Group II

src/

Common/

mitkModelFitConstants.cpp

O3: MITK Reviewer Group II

mitkModelFitInfo.cpp

O3: MITK Reviewer Group II

mitkModelFitPlotDataHelper.cpp

O3: MITK Reviewer Group II

mitkModelFitResultHelper.cpp

O3: MITK Reviewer Group II

mitkModelFitResultRelationRule.cpp

O3: MITK Reviewer Group II

mitkModelFitUIDHelper.cpp

O3: MITK Reviewer Group II

test/

O3: MITK Reviewer Group II

mitkModelFitInfoTest.cpp

O3: MITK Reviewer Group II

mitkModelFitUIDHelperTest.cpp

O3: MITK Reviewer Group II

	ModelFit/	test/
	Core/	test/

	mitkModelFitResultRelationRuleTest.cpp
	mitkSourceImageRelationRuleTest.cpp

O3: MITK Reviewer Group II

Pharmacokinetics/

cmdapps/

MRPerfusionMiniApp.cpp

O4: MITK Reviewer Group III

MRSignal2ConcentrationMiniApp.cpp

O4: MITK Reviewer Group III

Plugins/

org.mitk.gui.qt.fit.genericfitting/

src/

internal/

GenericDataFittingView.cpp

O3: MITK Reviewer Group II

org.mitk.gui.qt.fit.inspector/

src/

internal/

ModelFitInspectorView.cpp

O3: MITK Reviewer Group II

ModelFitInspectorView.h

O3: MITK Reviewer Group II

org.mitk.gui.qt.pharmacokinetics.mri/

src/

internal/

MRPerfusionView.cpp

O3: MITK Reviewer Group II

org.mitk.gui.qt.pharmacokinetics.pet/

src/

internal/

PETDynamicView.cpp

O3: MITK Reviewer Group II

rMITK978e3fbf6328

Modules/Core/include/mitkPropertyRelationRuleBase.h

Loading...

Modules/Core/include/mitkSourceImageRelationRule.h

Loading...

Modules/Core/src/DataManagement/mitkPropertyRelationRuleBase.cpp

Loading...

Modules/Core/src/DataManagement/mitkSourceImageRelationRule.cpp

Loading...

Modules/Core/src/mitkCoreActivator.cpp

Loading...

Modules/Core/test/mitkPropertyRelationRuleBaseTest.cpp

Loading...

Modules/Core/test/mitkSourceImageRelationRuleTest.cpp

Loading...

Modules/DICOMReader/src/mitkDICOMTagsOfInterestHelper.cpp

Loading...

Modules/ModelFit/autoload/IO/mitkModelFitIOActivator.cpp

Loading...

Modules/ModelFit/files.cmake

Loading...

Modules/ModelFit/include/mitkModelFitConstants.h

Loading...

Modules/ModelFit/include/mitkModelFitInfo.h

Loading...

Modules/ModelFit/include/mitkModelFitParameter.h

Loading...

Modules/ModelFit/include/mitkModelFitResultRelationRule.h

Loading...

Modules/ModelFit/include/mitkModelFitUIDHelper.h

Loading...

Modules/ModelFit/src/Common/mitkModelFitConstants.cpp

Loading...

Modules/ModelFit/src/Common/mitkModelFitInfo.cpp

Loading...

Modules/ModelFit/src/Common/mitkModelFitPlotDataHelper.cpp

Loading...

Modules/ModelFit/src/Common/mitkModelFitResultHelper.cpp

Loading...

Modules/ModelFit/src/Common/mitkModelFitResultRelationRule.cpp

Loading...

Modules/ModelFit/src/Common/mitkModelFitUIDHelper.cpp

Loading...

Modules/ModelFit/test/files.cmake

Loading...

Modules/ModelFit/test/mitkModelFitInfoTest.cpp

Loading...

Modules/ModelFit/test/mitkModelFitResultRelationRuleTest.cpp

Loading...

Modules/ModelFit/test/mitkModelFitUIDHelperTest.cpp

Loading...

Modules/Pharmacokinetics/cmdapps/MRPerfusionMiniApp.cpp

Loading...

Modules/Pharmacokinetics/cmdapps/MRSignal2ConcentrationMiniApp.cpp

Loading...

Plugins/org.mitk.gui.qt.fit.genericfitting/src/internal/GenericDataFittingView.cpp

Loading...

Plugins/org.mitk.gui.qt.fit.inspector/src/internal/ModelFitInspectorView.cpp

Loading...

Plugins/org.mitk.gui.qt.fit.inspector/src/internal/ModelFitInspectorView.h

Loading...

Plugins/org.mitk.gui.qt.pharmacokinetics.mri/src/internal/MRPerfusionView.cpp

Loading...

Plugins/org.mitk.gui.qt.pharmacokinetics.pet/src/internal/PETDynamicView.cpp

Loading...