Changes after review: define Tags for RTPLAN in DICOMTagsOfInterestHelper. Use DICOMTagsOfInterest service. Use proper DICOM property naming. Don't cast DICOM tag values. Adapt test.
Signed-off-by: Clemens Hentschke <c.hentschke@dkfz-heidelberg.de>
Description
Description
Details
Details
- Auditors
floca - Provenance
hentsch Authored on Dec 14 2016, 3:52 PM hentsch Pushed on Dec 14 2016, 3:53 PM - Parents
- rMITK6730f2bc195e: resolved T19783 (implement DICOM RTPlanReader)
- Branches
- Unknown
- Tags
Event Timeline
Comment Actions
I think I fixed everything you mentioned in the last review 😄
It's shorter and much more clean now!
Comment Actions
Besides one littel comment, fine! Thanks. :)
| /Modules/DicomRT/src/mitkRTPlanReader.cpp | ||
|---|---|---|
| 33–37 | FYI. Normally not necessary. The activator of the DicomTagsOfInterestService already registers the result of GetDefaultDICOMTagsOfInterest(). If you want to make sure that it is available what you want, I think it is better if you not use the whole default list but only a list with the tags specific for the reader. | |