HomePhabricator
Diffusion MITK bd257ec2ad33

Merge branch 'T22423-DashboardFix'

Description

Merge branch 'T22423-DashboardFix'

Details

Provenance
neherAuthored on Feb 27 2017, 10:20 AM
neherPushed on Feb 27 2017, 10:22 AM
Parents
rMITK80f734d83159: COMP: openmp fixes for windows
rMITK5500873631f1: Merge branch 'T22464-CrosshairRotation'
Branches
Unknown
Tags
Unknown

Event Timeline

Procrastinating...

/Modules/DiffusionImaging/FiberTracking/Algorithms/MLTracking/itkMLBSTrackingFilter.cpp
629

You could speed up the loop by retrieving the size of the seedpoints container only once before the actual loop. Currently, you query the value in every iteration. You're also using post-increment insted of pre-increment (also for progress below), which will generate other unnecessary temporary variables. You can prevent all of this stuff by using range-based for. This would make writing and reading the code more simple as well.

634–635

Do you really want to output something on the console in a critical parallel loop? That's like driving a super sports car in first gear only. :-)