BREAKING ContourModel (see below) + Fixed review remarks.
dbd00321b51a
Actions

Description

BREAKING ContourModel (see below) + Fixed review remarks.

+ fixed gcc compiler errors
+ Refactored ContourModel interface to use mitk::TimeStepType

instead of int/unsigned int for time steps. Code might break that
currently explictly casts timesteps (that where provided from code
using the correct type (TimeStepType)) to int/unsigned int. Correct
or remove (where appropriate) the cast.

Details

Provenance

floca	Authored on Jan 8 2021, 8:56 PM
floca	Pushed on Jan 25 2021, 4:00 PM
floca	Pushed on Jan 25 2021, 2:43 PM

Differential Revision

Restricted Differential Revision

Parents

rMITK8e28cfe9a419: Fixed gcc/clang errors

Branches

Unknown

Tags

Unknown

Tasks

T28129: Contour interactor do not handle time steps > 0 correctly and do not support time geometries correctly
T28128: ContourModels are not correctly rendered on time steps > 0
T27800: [Segmentation] Live Wire crashes with 4D image and static segmentation
T26975: 2D Fast Marching for 4D data intermediate state displays segmentation in other timesteps

Event Timeline

floca committed rMITKdbd00321b51a: BREAKING ContourModel (see below) + Fixed review remarks. (authored by floca).Jan 25 2021, 2:41 PM

floca added tasks: T26975: 2D Fast Marching for 4D data intermediate state displays segmentation in other timesteps, T27800: [Segmentation] Live Wire crashes with 4D image and static segmentation, T28128: ContourModels are not correctly rendered on time steps > 0, T28129: Contour interactor do not handle time steps > 0 correctly and do not support time geometries correctly.Jan 25 2021, 4:02 PM

floca added an edge: Restricted Differential Revision.

Changes (13)

Path

Size

Packages

Modules/

ContourModel/

Algorithms/

mitkContourModelSubDivisionFilter.cpp

O3: MITK Reviewer Group II

mitkContourModelUtils.cpp

O3: MITK Reviewer Group II

mitkContourModelUtils.h

O3: MITK Reviewer Group II

DataManagement/

mitkContourModel.cpp

O3: MITK Reviewer Group II

mitkContourModel.h

O3: MITK Reviewer Group II

Testing/

mitkContourModelTest.cpp

O3: MITK Reviewer Group II

Segmentation/

Interactions/

mitkFastMarchingBaseTool.cpp

O1: MITK Reviewer Group I

mitkFastMarchingBaseTool.h

O1: MITK Reviewer Group I

mitkFastMarchingTool.cpp

O1: MITK Reviewer Group I

mitkFastMarchingTool3D.cpp

O1: MITK Reviewer Group I

mitkFeedbackContourTool.cpp

O1: MITK Reviewer Group I

mitkLiveWireTool2D.h

O1: MITK Reviewer Group I

SegmentationUI/

Qmitk/

QmitkAutoSegmentationToolGUIBase.cpp

O1: MITK Reviewer Group I

rMITKdbd00321b51a

View Options

Modules/ContourModel/Algorithms/mitkContourModelSubDivisionFilter.cpp

View Options

Modules/ContourModel/Algorithms/mitkContourModelUtils.cpp

View Options

Modules/ContourModel/Algorithms/mitkContourModelUtils.h

View Options

Modules/ContourModel/DataManagement/mitkContourModel.cpp

View Options

Modules/ContourModel/DataManagement/mitkContourModel.h

View Options

Modules/ContourModel/Testing/mitkContourModelTest.cpp

View Options

Modules/Segmentation/Interactions/mitkFastMarchingBaseTool.cpp

View Options

Modules/Segmentation/Interactions/mitkFastMarchingBaseTool.h

View Options

Modules/Segmentation/Interactions/mitkFastMarchingTool.cpp

View Options

Modules/Segmentation/Interactions/mitkFastMarchingTool3D.cpp

View Options

Modules/Segmentation/Interactions/mitkFeedbackContourTool.cpp

View Options

Modules/Segmentation/Interactions/mitkLiveWireTool2D.h

View Options

Modules/SegmentationUI/Qmitk/QmitkAutoSegmentationToolGUIBase.cpp

BREAKING ContourModel (see below) + Fixed review remarks.dbd00321b51aActions

Description

Details

Event Timeline

Changes (13)

rMITKdbd00321b51a

Modules/ContourModel/Algorithms/mitkContourModelSubDivisionFilter.cpp

Modules/ContourModel/Algorithms/mitkContourModelUtils.cpp

Modules/ContourModel/Algorithms/mitkContourModelUtils.h

Modules/ContourModel/DataManagement/mitkContourModel.cpp

Modules/ContourModel/DataManagement/mitkContourModel.h

Modules/ContourModel/Testing/mitkContourModelTest.cpp

Modules/Segmentation/Interactions/mitkFastMarchingBaseTool.cpp

Modules/Segmentation/Interactions/mitkFastMarchingBaseTool.h

Modules/Segmentation/Interactions/mitkFastMarchingTool.cpp

Modules/Segmentation/Interactions/mitkFastMarchingTool3D.cpp

Modules/Segmentation/Interactions/mitkFeedbackContourTool.cpp

Modules/Segmentation/Interactions/mitkLiveWireTool2D.h

Modules/SegmentationUI/Qmitk/QmitkAutoSegmentationToolGUIBase.cpp

BREAKING ContourModel (see below) + Fixed review remarks.
dbd00321b51a
Actions