Page MenuHomePhabricator
Create Task
Maniphest T28129

Contour interactor do not handle time steps > 0 correctly and do not support time geometries correctly
Closed, ResolvedPublic
Actions

Description

  1. Contour interactor do not deduce time step correctly.
  2. Contours created by interactor do not keep the time geometry of the original data.

Revisions and Commits

rMITK MITK
Restricted Differential RevisionrMITKb6352d695ed7 T28118 Refactor SegTool2D and derived classes (1st batch)
Restricted Differential RevisionrMITK08a93f52a64d Fixed review remarks.
Restricted Differential RevisionrMITK71ec4042604b Fixed review remarks.
Restricted Differential RevisionrMITK92f6b39de002 Fixed missing export statement
Restricted Differential RevisionrMITK0f4f7a637fc7 Fixed review remarks
Restricted Differential RevisionrMITKe9d3294313ef Fixed review remarks
Restricted Differential RevisionrMITK3f20a6c350a0 fixed gcc/clang compiler issues
Restricted Differential RevisionrMITKff566295e723 Added missed explicit Point conversions (gcc complaint)
Restricted Differential RevisionrMITK5dfc1cc4a570 Fixed bug in ContourModel::AddVertex
Restricted Differential RevisionrMITK5fa4514a9658 Fixed implicit mitk::Point conversions in code base (that where issued by gcc).
Restricted Differential RevisionrMITK7d2784676c44 Fixed all implicit mitk::Point conversions in code base.
Concern RaisedRestricted Differential RevisionrMITK8ebd602023cf Fixed gcc compile errors
Concern RaisedRestricted Differential RevisionrMITK34fd4b11f4d8 Fixed review remarks
Restricted Differential RevisionrMITKa720f2bed6e1 BREAKING mitk::Point conversion constructor
Restricted Differential RevisionrMITKbc6114b56830 BREAKING ContourModel::AddVertex and refactored ContourElement and fixed memory…
Restricted Differential RevisionrMITK6513178ca95f Removed obsolete empty function
Restricted Differential RevisionrMITKdbd00321b51a BREAKING ContourModel (see below) + Fixed review remarks.
Restricted Differential RevisionrMITK8e28cfe9a419 Fixed gcc/clang errors
Restricted Differential RevisionrMITK7b29121c3ed2 Fixed glitch that would leed to a missed update if the tool
Restricted Differential RevisionrMITK1a1c5b9183f9 Fixed gcc/clang compile errors
Restricted Differential RevisionrMITK3ff6f52dbcc6 Fixed visibility of livewire contour in last time step of working images with
Restricted Differential RevisionrMITK6a717a69cc9f Refactored RegionGrowingTool, now uses new FeedbackContourTool functionality
Restricted Differential RevisionrMITK3055d3d21a2a Refactored SetRegionTool
Restricted Differential RevisionrMITKe9274d346bcb Refactored CorrectorTool, now uses new FeedbackContourTool functionality
Restricted Differential RevisionrMITKdb75f8bb2819 Refactored/cleaned PaintbrushTool to use new FeedbackContourTool
Restricted Differential RevisionrMITKe36abcd4bc6e BREAKING mitk::FeedbackContourTool
Restricted Differential RevisionrMITK9dad51c932c6 Refactored and cleaned up ContourTool
Restricted Differential RevisionrMITKf3ae7e5f8564 fixed time step management of mitk::SegmentationInteractor
Restricted Differential RevisionrMITKf30516d6fc0e BREAKING WriteSliceToVolume removed unused 5th parameter (time step).
Restricted Differential RevisionrMITK4f985a9b05f5 Fixed error in ContourModel::Clear(int)
Restricted Differential RevisionrMITK2cdf951077d5 Refactored QmitkWatershedToolGUI to use QmitkAutoMLSegmentationToolGUIBase
Restricted Differential RevisionrMITK41d2ec201655 Improve constness of contour classes
Restricted Differential RevisionrMITK2ff07928196d Finished refactoring of FastMarchingTool for 2D and 3D to use same code base
Restricted Differential RevisionrMITK0a3983610f13 Refactored QmitkOtsuTool3DGUI to use QmitkAutoMLSegmentationToolGUIBase
Restricted Differential RevisionrMITK047173d4e8a7 Start to remove redundancy in tool UIs
Restricted Differential RevisionrMITK1169ba49d61c Reworked GUI of 2D/3D FastMarchingTool to reduce redundant code and use…
Restricted Differential RevisionrMITKd8d3e82df1cc Improve constness
Restricted Differential RevisionrMITK8476cce81578 BREAKING behavior LiveWireTool2D
Restricted Differential RevisionrMITK12899a001e4a Corrected support of time geometries in contour interactors.
Restricted Differential RevisionrMITKcc7d061bf06a Fixed rendering of contours on time steps > 0.
Restricted Differential RevisionrMITK14a12898a884 Improved SegTool2D interface
Restricted Differential RevisionrMITK10095d92849f Added time point change support to SegTool2D
Restricted Differential RevisionrMITKb933b90720d5 improved parameter naming
Restricted Differential RevisionrMITKc7f54dfd1df1 BREAKING CHANGES!!!
Restricted Differential RevisionrMITK347f8da13e5b Improved const support of LabelSetImage
Restricted Differential RevisionrMITKb8e2d908dcbc BREAKING
Restricted Differential RevisionrMITK060d92290023 Corrected use of TimeStepType
Restricted Differential RevisionrMITK2667cf689439 Improved constness of ContourModelUtils
Restricted Differential RevisionrMITK64b3ff3b8a7a Refactored TimeStepType of DiffSliceOperation
Restricted Differential RevisionrMITKe84fe1cf7688 Added first draft for 2D/3D FastMarchingBaseTool
Restricted Differential RevisionrMITKa5101d9eda9e GetAffectedImageSliceAs2DImage is now static and public
Restricted Differential RevisionrMITKbcca91460daa Corrected comments, removed undefined constructor

Related Objects

Event Timeline

floca triaged this task as Normal priority.Dec 22 2020, 10:13 AM
floca created this task.
floca added a revision: Restricted Differential Revision.Jan 5 2021, 11:01 AM
floca closed this task as Resolved by committing rMITK12899a001e4a: Corrected support of time geometries in contour interactors..Jan 25 2021, 4:01 PM
floca added a commit: rMITKbcca91460daa: Corrected comments, removed undefined constructor.
floca added a commit: rMITKa5101d9eda9e: GetAffectedImageSliceAs2DImage is now static and public.
floca added a commit: rMITKe84fe1cf7688: Added first draft for 2D/3D FastMarchingBaseTool.
floca added a commit: rMITK64b3ff3b8a7a: Refactored TimeStepType of DiffSliceOperation.
floca added a commit: rMITK2667cf689439: Improved constness of ContourModelUtils.
floca added a commit: rMITK060d92290023: Corrected use of TimeStepType.
floca added a commit: rMITKb8e2d908dcbc: BREAKING.
floca added a commit: rMITK347f8da13e5b: Improved const support of LabelSetImage.
floca added a commit: rMITKc7f54dfd1df1: BREAKING CHANGES!!!.
floca added a commit: rMITK10095d92849f: Added time point change support to SegTool2D.
floca added a commit: rMITKb933b90720d5: improved parameter naming.
floca added a commit: rMITKcc7d061bf06a: Fixed rendering of contours on time steps > 0..
floca added a commit: rMITK12899a001e4a: Corrected support of time geometries in contour interactors..
floca added a commit: rMITK14a12898a884: Improved SegTool2D interface.
floca added a commit: rMITKd8d3e82df1cc: Improve constness.
floca added a commit: rMITK8476cce81578: BREAKING behavior LiveWireTool2D.
floca added a commit: rMITK047173d4e8a7: Start to remove redundancy in tool UIs.
floca added a commit: rMITK1169ba49d61c: Reworked GUI of 2D/3D FastMarchingTool to reduce redundant code and use….
floca added a commit: rMITK2ff07928196d: Finished refactoring of FastMarchingTool for 2D and 3D to use same code base.
floca added a commit: rMITK0a3983610f13: Refactored QmitkOtsuTool3DGUI to use QmitkAutoMLSegmentationToolGUIBase.
floca added a commit: rMITK41d2ec201655: Improve constness of contour classes.
floca added a commit: rMITK4f985a9b05f5: Fixed error in ContourModel::Clear(int).
floca added a commit: rMITK2cdf951077d5: Refactored QmitkWatershedToolGUI to use QmitkAutoMLSegmentationToolGUIBase.
floca added a commit: rMITKf30516d6fc0e: BREAKING WriteSliceToVolume removed unused 5th parameter (time step)..
floca added a commit: rMITKf3ae7e5f8564: fixed time step management of mitk::SegmentationInteractor.
floca added a commit: rMITK9dad51c932c6: Refactored and cleaned up ContourTool.
floca added a commit: rMITKe36abcd4bc6e: BREAKING mitk::FeedbackContourTool.
floca added a commit: rMITKdb75f8bb2819: Refactored/cleaned PaintbrushTool to use new FeedbackContourTool.
floca added a commit: rMITKe9274d346bcb: Refactored CorrectorTool, now uses new FeedbackContourTool functionality.
floca added a commit: rMITK3055d3d21a2a: Refactored SetRegionTool.
floca added a commit: rMITK6a717a69cc9f: Refactored RegionGrowingTool, now uses new FeedbackContourTool functionality.
floca added a commit: rMITK3ff6f52dbcc6: Fixed visibility of livewire contour in last time step of working images with.
floca added a commit: rMITK1a1c5b9183f9: Fixed gcc/clang compile errors.
floca added a commit: rMITK7b29121c3ed2: Fixed glitch that would leed to a missed update if the tool.
floca added a commit: rMITK8e28cfe9a419: Fixed gcc/clang errors.
floca added a commit: rMITKdbd00321b51a: BREAKING ContourModel (see below) + Fixed review remarks..
floca added a commit: rMITK6513178ca95f: Removed obsolete empty function.
floca added a commit: rMITKbc6114b56830: BREAKING ContourModel::AddVertex and refactored ContourElement and fixed memory….
floca added a commit: rMITKa720f2bed6e1: BREAKING mitk::Point conversion constructor.
floca added a commit: rMITK34fd4b11f4d8: Fixed review remarks.
floca added a commit: rMITK8ebd602023cf: Fixed gcc compile errors.
floca added a commit: rMITK7d2784676c44: Fixed all implicit mitk::Point conversions in code base..
floca added a commit: rMITK5fa4514a9658: Fixed implicit mitk::Point conversions in code base (that where issued by gcc)..
floca added a commit: rMITK5dfc1cc4a570: Fixed bug in ContourModel::AddVertex.
floca added a commit: rMITKff566295e723: Added missed explicit Point conversions (gcc complaint).
floca added a commit: rMITK3f20a6c350a0: fixed gcc/clang compiler issues.
floca added a commit: rMITKe9d3294313ef: Fixed review remarks.
floca added a commit: rMITK0f4f7a637fc7: Fixed review remarks.
floca added a commit: rMITK92f6b39de002: Fixed missing export statement.
floca added a commit: rMITK71ec4042604b: Fixed review remarks..
floca added a commit: rMITK08a93f52a64d: Fixed review remarks..
floca added a commit: rMITKb6352d695ed7: T28118 Refactor SegTool2D and derived classes (1st batch).
kislinsk mentioned this in T28197: 2021 Week 04 (Very Late January).Jan 25 2021, 5:33 PM
MITK · MIC · IMSY · DKFZ