Resolved T23466 added chart type parameter als data property
Signed-off-by: Clemens Hentschke <c.hentschke@dkfz-heidelberg.de>
Description
Description
Details
Details
- Auditors
• kleina hentsch - Provenance
hentsch Authored on Oct 13 2017, 2:38 PM hentsch Pushed on Oct 13 2017, 2:48 PM - Parents
- rMITK6989c8373849: Removed chartType parameter
- Branches
- Unknown
- Tags
- Tasks
- T23466: Display multiple Chart Types at the same time
Event Timeline
Comment Actions
Added chart type as a data property.
- This is needed to be able to display multiple chart types at the same time. (e.g. in MitkDiffusion)
- Therefore we must get rid of the "global" chart type.
- Chart type is now passed as a parameter in AddDataXd methods
I added a view recommendations, but mostly "naming" stuff. The rest is straight forward and looks fine to me.
| /Modules/Chart/include/QmitkChartWidget.h | ||
|---|---|---|
| 129 | Just from the signature, I have no idea what the "label" is for. Better name? Addition: Looking at the rest of the code, I realized, that we used "label" all the time to describe the data-lines. I think I'm ok with the name, just keep it. | |
| /Modules/Chart/src/QmitkChartWidget.cpp | ||
| 245 | So "label" is the name of a data row? And "element" is the data row itself? | |
| 252 | rename to chartType | |
| 253 | rename to chartType | |