HomePhabricator

Fixed T28333

Description

Fixed T28333

Introduced auto wrapping functionality for MPISolverWrapper.

Details

Auditors
kleina
Provenance
flocaAuthored on Feb 24 2021, 12:03 AM
Parents
rOBSHYPPOPY38bf9e41f9e5: Merge branch 'T26755_mpi4hyppopy'
Branches
Unknown
Tags
Unknown
References
feature/T28333-MPI_blackbox_auto_wrapping
Tasks
T28333: Allow auto wrapping of blackbox for MPI

Event Timeline

kleina added a subscriber: kleina.

The auto wrapping functionality for MPISolverWrapper looks correct and straightforward to me. A check for function type is already included in the HyppopySolver.

The cleanup of the mpiplayground makes sense for now. We need to convert it to a "proper example" and move into the right folder. Additionally the possibility to pass a custom comm should be explained. I spawned T28349 for this. This has no effect on this commit. Here everything looks fine.

All concerns with this commit have now been addressed.Mar 5 2021, 1:41 PM