Page MenuHomePhabricator

Double-click should always finish PlanarPolygon creation
Closed, ResolvedPublic

Description

When you create a PlanarPolygon you have to finish it with a double click into 'open' space. At that spot a new conntrol-point is created.

If you perform a double click onto another control point the polygon will NOT be finished. However it showed that many users are unable to cope with this and do not understand why their polygon is not finished up.

In order to fix this we will allow to finish polygon by double clicks, no matter if it has been performed on another control point or not.

Event Timeline

The problem has been solved as stated in the description. It is now possible to finish a planarPolygon by double clicking anywhere. Existing control-points are "ignored".

If you double click into open space, a new last control point is created. If you double click onto an existing control point, there will not be a new one added.

Fix seems reasonable; the only possibly annoying issue that we noticed is that when you double-click onto another control-point of the same polygon (placed somewhere completely else), polygon creation is also finished, and this last position of the mouse is ignored. This seems to be acceptable though, because it is highly unlikely that users interact with the polygon like this.

[d81632]: Merge branch 'bug-10784-polygon-finished-rebased'

Merged commits:

2012-01-20 13:43:13 Markus Engel [d97657]
allowing to finish polygon even if there already is a control point