Page MenuHomePhabricator

Threshold-Window is not closable on OSX
Closed, ResolvedPublic

Event Timeline

Hi Jonas,

I pushed some changes to the bug branch. Please test them on MacOS. The first dialog should be movable, stay on top of the main window (even when clicking in the main window), show a close button, and be resizable (fixing the height did not work out properly).

first dialog should be movable: OK
stay on top of the main window (even when clicking in the main window): OK
show a close button: OK
and be resizable: OK

looks pretty good.

i think it could be merged.

The minimize button is active. On OSX, you have no chance to maximize it again. In addition, the main application is not usable at this time. So if there is a way to turn it off, this should be done.

Hi Sascha, I've pushed the update to the branch. Can you take a look on it please, whether this is still running under Linux.

Didn't make a difference on Linux (the minimize button was also hidden before the change).

So it looks all good to me, ready for merge.

[db2d61]: Merge branch 'bug-12072-thresholdWindow'

Merged commits:

2012-06-07 14:01:37 Jonas Cordes [3f3da8]
disable minimize-button


2012-06-06 19:02:06 Sascha Zelzer [bfb00b]
Some GUI style fixes for the threshold dialog widget.

  • Using Qt::Window as window type as Qt::Dialog is strange on Linux
  • Fixing the height does not really work
  • Use QmitkToolGUI subclass QmitkBinaryThresholdToolGUI to get access to the "thresholdAccepted()" signal

2012-06-06 18:01:05 Jonas Cordes [dc6def]
Add thresholdAccepted and thresholdCanceled signals to QmitkBinaryThresholdGUI

QmitkThresholdAction now catching thresholdAccepted Signal to close threshold-dialog immediatly


2012-06-06 16:58:58 Jonas Cordes [cabaee]
Adapted the interaction-behaviour of the Threshold-Window

clean up QmitkThresholdAction
change label of QmitkBinaryThresholdToolGUI button (Ok to Create Segmentation)