[d3e84d]: Merge branch 'bug-13230-ImageAccessorIntegration'

Merged commits:

2012-09-27 18:27:17 Joseph Grres [f09e67]
Made former image access methods deprecated and integrated image accessors implicitly in itk cast- and access-methods.

+ refactored incorrect variable names
+ removed deprecated method calls from core, except the classes Image and SliceNavigationController

2012-09-25 17:13:37 Joseph Grres [03f5e4]
Add all image accessor classes and make them work by minor changes in image related classes

[2cae8e]: Merge branch 'bug-13230-ImageAccessorIntegration'

Merged commits:

2012-09-28 14:54:34 Joseph Grres [c33b23]
COMP: Dealt with compiler specific errors and repaired some class name conflicts

[1167c4]: Merge branch 'bug-13230-ImageAccessorIntegration'

Merged commits:

2012-09-28 18:09:45 Joseph Grres [63b786]
COMP: Repaired broken ImageAccessorTest

[282572]: Merge branch 'bug-13230-ImageAccessorIntegration'

Merged commits:

2012-09-28 18:33:12 Joseph Grres [15b27f]
COMP: Disabled OverwriteSliceImageFilterTest temporary: See T13309

I just had a quick look through the code because the dashboard is currently red due to last "COMP" commit. When looking through the changes in your branch I noticed the following:

1.) Methods declared deprecated (like in mitkImage.h) should also get a Doxygen "\deprecatedSince{2012_09} Use ... instead" line in their documentation block. See also http://bugs.mitk.org/show_bug.cgi?id=13081

2.) This is just "style", but please use a correct white-space count in mitkImageAccessByItk.h such that the "\" characters line up properly in the macro definitions.

Overall, everything looks very good.

[fb21f3]: Merge branch 'bug-13230-ImageAccessorIntegration'

Merged commits:

2012-10-01 10:02:58 Joseph Grres [c39326]
COMP: Disabled also mitkSegmentationInterpolationTest temporary (See T13309)

[32e796]: Merge branch 'bug-13230-ImageAccessorIntegration'

Merged commits:

2012-10-01 10:20:14 Joseph Grres [f911ce]
COMP: Prevent SegmentationInterpolationTest from execution

[42a4ff]: Merge branch 'bug-13230-ImageAccessorIntegration'

Merged commits:

2012-10-01 13:36:22 Joseph Grres [036ee5]
Added deprecatedSince tags to Doxygen and fixed some whitespace style issues

[2110d1]: Merge branch 'bug-13230-ImageAccessorDocumentation'

Merged commits:

2012-10-31 14:19:36 Joseph Grres [4659a9]
Example source code in concept page was not compilable

[00e4ed]: Merge branch 'bug-13230-ImageAccessorIntegrationFixes'

Merged commits:

2012-11-07 18:00:54 Joseph Grres [68a8e4]
Simplified redundant code and changed pixel type check to allow the use of compound pixel types

Need release fix because of T13935

New remote branch pushed: bug-13230-ImageAccessorIntegrationThreadIdIntegration

[07df08]: Merge branch 'bug-13230-ImageAccessorIntegrationThreadIdIntegration'

Merged commits:

2013-01-30 16:04:42 Joseph Görres [006a94]
Improved defs in ImageAccessorBase and changed to exception macro in ImageAccessorTest

2013-01-30 15:41:08 Joseph Görres [d25b4e]
optimized code and extended test to detect recursive mutex locking

2013-01-23 16:31:22 Joseph Görres [0111db]
Merge branch 'master' into bug-13230-ImageAccessorIntegrationThreadIdIntegration

2012-12-19 14:38:10 Joseph Görres [0d568f]
Merge branch 'bug-13230-ImageAccessorIntegration' into bug-13230-ImageAccessorIntegrationThreadIdIntegration

Conflicts:
Core/Code/Testing/mitkImageAccessorTest.cpp

2012-12-05 18:03:54 Joseph Görres [7308ea]
Further improvement of prevention of recursive mutex access. Needs to be tested on Windows.

2012-10-04 10:33:33 Justin Iszatt [846842]
Made thread-id check work on windows

2012-10-01 17:48:26 Joseph Görres [1162da]
Added thread-id check to prevent deadlocks when using image accessors inappropriately

The recent usage of the Windows API function "GetThreadId" broke our Windows XP compatibility. This function is only available for Windows Vista and Windows Server 2003 or newer (see the MSDN documentation).

I believe the 32bit MITK installers were build using Windows XP, so we should try to keep backwards compatibility (you could trying to argue against it in the next MITK meeting...).

Maybe you can find a Windows XP compatible alternative?

CC'ing Caspar since he is our Windows XP 32 bit release chief.

Yes compatibility is broken. The installer will build on WinXP but crash on execution of mitkWorkbench.

Support for Windows XP has been recovered with branch bug-13230-ImageAccessorIntegrationThreadIdIntegration. Release-Flag necessary for merging!

[f91aee]: Merge branch 'bug-13230-ImageAccessorIntegrationThreadIdIntegration'

Merged commits:

2013-03-13 17:39:00 Joseph Görres [287023]
Merge remote-tracking branch 'origin/master' into bug-13230-ImageAccessorIntegrationThreadIdIntegration

2013-03-13 16:45:56 Joseph Görres [8992c8]
ensured thread support for windows XP