Page MenuHomePhabricator
Create Task
Maniphest T14640

compile errors with g++ 4.1.2
Closed, ResolvedPublic
Actions

Description

Three easy-to-fix compile errors with gcc 4.1.2 on Slackware, 32 bit.

In file included from /build/niftk-release/CMakeExternals/Source/MITK/Core/Code/Algorithms/mitkExtractSliceFilter.cpp:23:
/build/niftk-release/CMakeExternals/Source/MITK/Core/Code/Algorithms/mitkPlaneClipping.h:141:7: error: no newline at end of file

[ 23%] Building CXX object Core/Code/CMakeFiles/Mitk.dir/Rendering/vtkMitkLevelWindowFilter.cpp.o
cc1plus: warnings being treated as errors
/build/niftk-release/CMakeExternals/Source/MITK/Core/Code/Rendering/vtkMitkLevelWindowFilter.cpp: In function 'void vtkApplyLookupTableOnRGBA(vtkMitkLevelWindowFilter*, vtkImageData*, vtkImageData*, int*, vtkFloatingPointType*, T*) [with T = vtkMitkLevelWindowFilter::ThreadedExecute::VTK_TT]':
/build/niftk-release/CMakeExternals/Source/MITK/Core/Code/Rendering/vtkMitkLevelWindowFilter.cpp:489: instantiated from here
/build/niftk-release/CMakeExternals/Source/MITK/Core/Code/Rendering/vtkMitkLevelWindowFilter.cpp:208: warning: converting to 'unsigned char' from 'double'
/build/niftk-release/CMakeExternals/Source/MITK/Core/Code/Rendering/vtkMitkLevelWindowFilter.cpp: In function 'void vtkApplyLookupTableOnRGBA(vtkMitkLevelWindowFilter*, vtkImageData*, vtkImageData*, int*, vtkFloatingPointType*, T*) [with T = vtkMitkLevelWindowFilter::ThreadedExecute::VTK_TT]':
/build/niftk-release/CMakeExternals/Source/MITK/Core/Code/Rendering/vtkMitkLevelWindowFilter.cpp:489: instantiated from here
/build/niftk-release/CMakeExternals/Source/MITK/Core/Code/Rendering/vtkMitkLevelWindowFilter.cpp:208: warning: converting to 'unsigned char' from 'vtkMitkLevelWindowFilter::ThreadedExecute::VTK_TT'

In vtkMitkLevelWindowFilter:208 there is a static_cast to T, but the leftvalue is declared as unsigned char. I think, either the declaration type of the variable should be changed to T, or the static cast to unsigned char, I don't know which is correct.

[ 23%] Building CXX object Core/Code/CMakeFiles/Mitk.dir/Rendering/mitkRenderingTestHelper.cpp.o
cc1plus: warnings being treated as errors
/build/niftk-release/CMakeExternals/Source/MITK/Core/Code/Rendering/mitkRenderingTestHelper.cpp: In member function 'void mitkRenderingTestHelper::SaveAsPNG(std::string)':
/build/niftk-release/CMakeExternals/Source/MITK/Core/Code/Rendering/mitkRenderingTestHelper.cpp:164: warning: passing 'double' for argument 1 to 'virtual void vtkRenderLargeImage::SetMagnification(int)'

1.0 should be changed to 1 in the call.

Related Objects

Event Timeline

espak added projects: MITK, Bugzilla.Mar 6 2013, 1:27 PM
zelzer added a subscriber: zelzer.Mar 7 2013, 6:04 PM

Thanks for your bug report. I merged your changes to the MITK master (see T8165).

I didn't verify if gcc 4.1.2 now compiles everything. If you find more errors, you could list them here. Otherwise please close the bug - thanks.

espak added a subscriber: espak.Mar 7 2013, 6:08 PM

I fixed these manually in my build and these were the only problems, so I close this.
Thanks for the fixes!

zelzer mentioned this in T14697: Now newline at end of files mitkExtractSliceFilter.cpp and mitkPlaneClipping.h.Mar 12 2013, 10:57 AM
MITK · MIC · IMSY · DKFZ