Page MenuHomePhabricator
Create Task
Maniphest T14954

MITK fails to load PALETTE_COLOR image from GDCM-Data as color image (ITK4)
Closed, ResolvedPublic
Actions

Assigned To
None
Authored By
maleike
Apr 12 2013, 4:55 PM
Tags
Referenced Files
F981: expected.dump
Jun 14 2013, 11:15 AM
F980: OT-PAL-8-face.png
Jun 14 2013, 10:37 AM
F979: OT-face.png
Jun 14 2013, 10:36 AM
Subscribers
maleike

Description

With the current ITK4 migration branch (bug-10925), MITK crashes when loading test image OT-PAL-8-face.dcm

The crash can be avoided by the patch in https://itk.icts.uiowa.edu/jira/browse/ITK-3024

Afterwards MITK still produces a gray image because it provides the wrong pixel type in DicomSeriesReader. When the pixel type is modified to RGBPixel<unsigned char>, it seems that ITK generates a correct image, but the MITK image is initialized in a wrong way. Attached screenshot shows the generated image information (most of all 3 bits per element).

I'll push a branch that makes DicomSeriesReader ask ITK for RGBPixel.

OT-face.png (1×1 px, 151 KB)

Related Objects

Event Timeline

maleike added projects: MITK, Bugzilla.Apr 12 2013, 4:55 PM
maleike added a subscriber: maleike.Apr 12 2013, 5:02 PM

New remote branch pushed: bug-14954-rgbpixel-in-dicom

maleike added a comment.Jun 13 2013, 5:52 PM

This ITK patch has been integrated into ITK master now: http://review.source.kitware.com/#/c/11500/, I'm not sure about the ITK release this will be integrated, but I'll keep watching.

maleike added a comment.Jun 14 2013, 10:36 AM

With minor modifications we can request to load images based on itk::RGBPixel (see branch). This leads to correctly colored images.

OT-face.png (1×1 px, 151 KB)

maleike added a comment.Jun 14 2013, 10:37 AM

I just uploaded the wrong image, this here is AFTER the fix

OT-PAL-8-face.png (1×1 px, 268 KB)

maleike added a comment.Jun 14 2013, 11:14 AM

To finish this ticket

  • we need to adapt test data to change expectations regarding OT-PAL-8-face, which is now RGB
  • we would have to wait for ITK 4.5 (or the next one containing the fix)

To acceleracte things, I propose to patch ITK unless it already contains the fix. A newly pushed branch contains such a patch already.

maleike added a comment.Jun 14 2013, 11:15 AM

For the change in MITK-Data: attached is the new test expectation

expected.dump268 BDownload

maleike added a comment.Jun 14 2013, 11:19 AM

New remote branch pushed: bug-14954-rgbpixel-in-dicom-proper

maleike added a comment.Jun 21 2013, 3:25 PM

[74c560]: Merge branch 'bug-14954-rgbpixel-in-dicom-proper'

Merged commits:

2013-06-21 14:28:07 Daniel Maleike [92720e]
Link new test data (expectations)

2013-06-14 11:17:44 Daniel Maleike [f53f77]
Activate test OT-PAL-8-face again

2013-06-14 11:17:12 Daniel Maleike [939fe4]
Patch ITK to remove wrong assertion

2013-06-12 18:01:28 Daniel Maleike [cd4b69]
Reformat fix, remove "TODO" comments

2013-04-12 17:01:15 Daniel Maleike [131de4]
Quick solution for RGBPixel types in DicomSeriesReader

maleike added a comment.Jun 21 2013, 3:50 PM

Fix is integrated, continuous clients for Mac, Windows, Linux all passed, including the reactivated test case.

maleike added a comment.Jul 3 2013, 6:10 PM

A minor TODO was missing, Andreas just noticed me that the Resampler::DefaultPixelValue for tilt correction was undefined since my changes.

I forgot to check all TODOs that I introduced. Solution is working locally already.

maleike added a comment.Jul 3 2013, 6:11 PM

New remote branch pushed: bug-14954-tilt-defaultpixelvalues

maleike added a comment.Jul 3 2013, 6:11 PM

[a99a18]: Merge branch 'bug-14954-tilt-defaultpixelvalues'

Merged commits:

2013-07-03 18:11:13 Daniel Maleike [c75608]
Use itk::NumbericTraits to determine smallest possible value

kislinsk edited projects, added MITK (2013-06); removed MITK.Aug 1 2016, 10:48 PM
kislinsk mentioned this in T27033: Clean up stale remote branches.Jan 25 2020, 9:01 PM
MITK · MIC · IMSY · DKFZ