Page MenuHomePhabricator
Create Task
Maniphest T15566

Fix minor issues with mitkEventConfig
Closed, ResolvedPublic
Actions

Description

During the adaption of my interactors to the new interaction framework I have found some issues with the mitk::EventConfig when building instances of EventConfig from PropertyLists and/or other EventConfigs:

EventConfig::EventConfig(const std::vector<PropertyList::Pointer>) does not support parameters. Only events are created from the PropertyLists, the parameter were not implemented, yet.

EventConfig::AddConfig(const EventConfig&) does not support EventConfigs without events. This may seem logical, but it is possible to have EventConfigs that only have parameters but no events.

Furthermore the EventConfig::AddConfig(const EventConfig&) does not copy the eventList but only the m_CurrEventMapping.
I have implemented a new method EventConfigPrivate::CopyMapping(const EventListType) that actually inserts all EventMappings of the given eventList.

Event Timeline

engelm added projects: MITK, Bugzilla.Jul 9 2013, 4:28 PM
engelm added a subscriber: engelm.Jul 9 2013, 5:00 PM

New remote branch pushed: bug-15566-build-eventconfig-from-properties

engelm added a comment.Jul 11 2013, 3:59 PM

[e48bb6]: Merge branch 'bug-15566-build-eventconfig-from-properties'

Merged commits:

2013-07-09 16:59:47 Markus Engel [6acea4]
EventConfigs are also valid if they have parameter and no events

2013-07-09 16:52:12 Markus Engel [24963a]
added support for interaction-parameters when creating config from propertyLists

2013-07-09 16:51:24 Markus Engel [024ecf]
added new method to copy all events during concatenation

engelm added a comment.Jul 11 2013, 4:00 PM

All issues have been fixed as proposed in the wiki specification...

engelm added a comment.Aug 14 2013, 11:54 AM

reopen for push of unittest

engelm added a comment.Aug 14 2013, 12:07 PM

I have extended the unittest to check if it is possible to have two events with the same name but different moifiers.

Cannot integrate to master right now as dashboard is red...

engelm added a comment.Aug 14 2013, 1:24 PM

[ddd0f8]: Merge branch 'bug-15566-build-eventconfig-from-properties'

Merged commits:

2013-08-14 11:54:52 Markus Engel [27338f]
extended unittest to check two events with the same name but different modifiers

engelm added a comment.Aug 14 2013, 1:46 PM

extended unittest has been integrated into master..

kislinsk edited projects, added MITK (2013-09); removed MITK.Aug 1 2016, 10:48 PM
MITK · MIC · IMSY · DKFZ