Page MenuHomePhabricator

SlicedGeometry3D does not reorient slices about correct center
Closed, InvalidPublic

Description

Center should be about m_ReferenceGeometry->GetCenter() -- which is currently commented out in the implementation of OpORIENT in mitk::SlicedGeometry3D::ExecuteOperation()

Event Timeline

To Basti since he has the most insight into this.

Basti what is the status of this bug? There is a pull request from Taylor. Did you already had a look at it?

I am very sorry for the late reply. Did not see that bug.

I looked at it now. Currently, the OpORIENT Operation in the mitkSlicedGeometry3D::ExecuteOperation(..) will cause a rotation around a given center point (defined by the operation).

In my opinion this is the desired behavior. The rotation center does not have to be the center of the image. In case you want to rotate it around the center of the reference geometry, you can define this point as rotation center in the Planeoperation.

Again sorry for the late reply. Talyor, if you still read this, i would decline your change request in this current state. If are not happy with this, please add some more additional information about what's bothering you.

kislinsk changed the task status from Invalid to Spite.Jun 27 2018, 1:31 PM
kislinsk added a project: Bulk Edit.
kislinsk changed the task status from Spite to Invalid.Jun 27 2018, 1:36 PM
kislinsk removed a project: Bulk Edit.