Page MenuHomePhabricator

Build error in MitkExt with Clang 3.4
Closed, ResolvedPublic

Description

The default arguments have to be removed from the friend declaration of the CutImageWithOutputTypeSelect function in

Modules/MitkExt/Algorithms/mitkBoundingObjectCutter.h

Event Timeline

Proposed fix

Comment to the attachment: we could actually go further in the fix and remove both arguments as they are not used in the function itself anyway.

I noticed that my pull request was wrong, so I corrected it.
Of course, if the arguments are not used then removing them completely is a better idea.

Hi Jan,

what's the status of this?
I see your proposed fix. Has it been merged to the master?

Thanks

Hi Miklos,

thank you for reminding, the fix is not yet in master, I will take a look at it on Wednesday this week.

Any update on this?
That's a trivial little bug, maybe already fixed? Should I close the pull request?

Cheers

Now just stumbled over this bug, i fixed this a while ago,
because i also couldn't compile using clang.

Whats left open is this:
Comment to the attachment: we could actually go further in the fix and remove both arguments as they are not used in the function itself anyway.

kislinsk claimed this task.
kislinsk added a subscriber: kislinsk.

MitkExt module doesn't exist anymore.