Page MenuHomePhabricator

mitkIOutil uses obsolete permission bit synonyms
Closed, ResolvedPublic

Description

mitk::IOUtil uses obsolete permission bit synonyms that are not available on all platforms.

Proposal:
replace mitk::IOUtil.cpp:160 S_IREAD|S_IWRITE with S_IRUSR|S_IWUSR

See documentation:
http://www.gnu.org/savannah-checkouts/gnu/libc/manual/html_node/Permission Bits.html

Event Timeline

The Link does not work.

The changes look fine to me. On which platform do you get the errors? Please adjust the bug flags appropriately.

Sorry for the broken link, the linebreak somehow removed the "-" when pasting it.
http://www.gnu.org/savannah-checkouts/gnu/libc/manual/html_node/Permission-Bits.html

Getting the error on Android. They won't add the obsolete flags to their system:
http://code.google.com/p/android/issues/detail?id=19710

On POSIX systems S_IREAD/S_IWRITE should be a define that points S_IRUSR/S_IWUSR anyway.

New remote branch pushed: bug-16771-mitkIO-permissionbits

[965620]: Merge branch 'bug-16771-mitkIO-permissionbits'

Merged commits:

2014-01-15 15:14:47 Eric Heim [20f562]
fixed typo


2014-01-15 14:29:47 Eric Heim [ade68c]
added defines to S_IRUSR S_IWUSR for windows compability


2014-01-15 14:03:39 Eric Heim [7ca53c]
replaced obsolete BSD style io permission bits S_IREAD and S_IWRITE with IRUSR and IWUSR

[141cad]: Merge branch 'bug-16771-mitkIO-permissionbits'

Merged commits:

2014-01-17 16:30:10 Eric Heim [277991]
move mitkIOUtilTest to cmake module test to run it on the dashboard