Page MenuHomePhabricator
Create Task
Maniphest T16880

Implicit DiffusionCoreObjectFacory registration
Closed, ResolvedPublic
Actions

Description

DiffusionCoreObjectFactory is not registered implicit

To Do:

  • remove all RegisterDiffusionCoreObjectFactory() calls and set the method as deprecated
  • add static RegisterDiffusionCoreObjectFactory registerDiffusionCoreObjectFactory;

for example take a look at 'mitkPlanarFigureObjectFactory'

Event Timeline

• cordes added projects: MITK, Bugzilla.Jan 22 2014, 4:30 PM
• cordes added a subscriber: • cordes.Jan 23 2014, 1:34 AM

New remote branch pushed: bug-16880-RemoveDiffusionCoreObjectFactoryRegisterCalls

• cordes added a comment.Jan 23 2014, 5:49 PM

[4904c3]: Merge branch 'bug-16880-RemoveDiffusionCoreObjectFactoryRegisterCalls'

Merged commits:

2014-01-23 10:20:49 Jonas Cordes [0d9399]
remove RegisterIOFactories call

2014-01-23 10:20:26 Jonas Cordes [aea5c9]
remove RegisterObjectFactoryCalls for FiberTrackingObjectFactory and ConnectomicsObjectFactory

2014-01-23 10:18:47 Jonas Cordes [2323e5]
remove RegisterFiberTrackingObjectFactory method

2014-01-23 10:17:56 Jonas Cordes [e313a5]
remove Connectomics RegisterObjectFactory method

2014-01-23 08:43:44 Jonas Cordes [9b32a4]
Merge branch 'master' into bug-16880-RemoveDiffusionCoreObjectFactoryRegisterCalls

2014-01-23 00:29:43 Jonas Cordes [d3b06b]
remove some more registercalls and includes

2014-01-23 00:29:19 Jonas Cordes [407c4f]
rename static registerFactory variable

2014-01-23 00:02:25 Jonas Cordes [601f33]
remove global diffusionCoreObjectFactory registration method calls and includes

2014-01-23 00:01:34 Jonas Cordes [370006]
remove global method for RegisterDiffusionCoreObjectFactory

• cordes added a comment.Jan 23 2014, 9:20 PM

[905669]: Merge branch 'bug-16880-RemoveDiffusionCoreObjectFactoryRegisterCalls'

Merged commits:

2014-01-23 21:19:28 Jonas Cordes [2c5e89]
COMP: remove old comment

zelzer added a subscriber: zelzer.Jan 23 2014, 9:58 PM

[5c5d49]: COMP: Merge branch 'bug-16880-RemoveDiffusionCoreObjectFactoryRegister

Merged commits:

2014-01-23 21:57:23 Sascha Zelzer [705104]
Unregister more diffusion factories.

2014-01-23 21:39:24 Sascha Zelzer [364f06]
Unregister diffusion object factories again.

2014-01-23 21:38:48 Sascha Zelzer [0c1df8]
Enable CppUnit if BUILD_TESTING is on.

zelzer added a comment.Jan 24 2014, 12:13 AM

[b1c12b]: COMP: Merge branch 'bug-16880-RemoveDiffusionCoreObjectFactoryRegister

Merged commits:

2014-01-24 00:05:30 Sascha Zelzer [146eaa]
Moved diffusion object factories into a new module for auto-loading.

zelzer added a comment.Jan 24 2014, 5:20 AM

[62ec73]: COMP: Merge branch 'bug-16880-RemoveDiffusionCoreObjectFactoryRegister

Merged commits:

2014-01-24 05:06:06 Sascha Zelzer [d0e461]
Moved more classes to the DiffusionIO module.

• cordes added a comment.Jan 24 2014, 11:45 AM

[0eb41e]: Merge branch 'bug-16880-RemoveDiffusionCoreObjectFactoryRegisterCalls'

Merged commits:

2014-01-24 11:44:29 Jonas Cordes [a6f788]
COMP: add DiffusionIO dependency to DI MiniApps

• goch added a subscriber: • goch.Jan 24 2014, 2:21 PM

New remote branch pushed: bug-16880-do-not-initialize-writer-explicitly

• goch added a comment.Jan 24 2014, 2:24 PM

[6d8ed3]: Merge branch 'bug-16880-do-not-initialize-writer-explicitly'

Merged commits:

2014-01-24 14:20:51 Caspar Goch [57c663]
COMP: Do not initialize qball writer explicitly

zelzer added a comment.Jan 24 2014, 3:07 PM

[675251]: COMP: Merge branch 'bug-16880-RemoveDiffusionCoreObjectFactoryRegister

Merged commits:

2014-01-24 15:01:53 Sascha Zelzer [36377d]
Don't depend on DiffusionIO directly

zelzer added a comment.Jan 24 2014, 9:35 PM

[e76c80]: Merge branch 'bug-16880-RemoveDiffusionCoreObjectFactoryRegisterCalls'

Merged commits:

2014-01-24 21:34:35 Sascha Zelzer [ce5642]
COMP: Remove Qt dependency.

Loading Qt libraries during static initialization (e.g. when a
module is auto-loaded and has a QtGui or QtCore dependency) can
lead to problems when other Qt code is also invoked during
static initializion. For example, QLocale related code uses
TLS which is generally not safe during static initialization.

zelzer added a comment.Jan 27 2014, 12:06 AM

[15d4dd]: Merge branch 'bug-16880-RemoveDiffusionCoreObjectFactoryRegisterCalls'

Merged commits:

2014-01-26 23:50:46 Sascha Zelzer [c1ea61]
Merge branch 'bug-16809-package-dependencies-with-components' into bug-16880-RemoveDiffusionCoreObjectFactoryRegisterCalls

Conflicts:
Modules/DiffusionImaging/FiberTracking/CMakeLists.txt

• cordes added a comment.Feb 25 2014, 2:22 PM

now diffusion is auto-loading object factories

MITK · MIC · IMSY · DKFZ