Page MenuHomePhabricator

Do not allow NULL in mitk::Equal
Closed, ResolvedPublic

Description

As Sascha, Jan, Stefan and I discussed in the last bug-squashing, change the interface of all mitk::Equal methods to:

bool mitk::Equal(const mitk::DataType& i1, const mitk::DataType&)

in order to avoid NULL inputs. Also declare the old interface deprecated e.g.:
DEPRECATED(bool mitk::Equal(const mitk::Image* i1, const mitk::Image*)).

This affects the following core header files:
mitkImage
mitkGeometry3D
mitkVector
mitkPointSet
mitkSurface

Corresponding EqualTests will be adapted.

Event Timeline

[96a7d4]: Merge branch 'bug-17173-NoNULLinMitkEqual'

Merged commits:

2014-02-19 16:20:43 Thomas Kilgus [66ea78]
Changed interface to const reference. Older method is deprecated. Fixed some warnings.

[6b955c]: Merge branch 'bug-17173-NoNULLinMitkEqual'

Merged commits:

2014-02-19 17:04:53 Thomas Kilgus [2b174e]
COMP: Fixed macros in Diffusion.