Page MenuHomePhabricator | MITK

kilgus (Thomas Kilgus)
Disabled

Projects

User does not belong to any projects.

User Details

User Since
Aug 1 2016, 12:10 PM (146 w, 3 d)
Roles
Disabled

Recent Activity

Aug 2 2016

kilgus added projects to T19171: Image transformation seems to be lost when converting to python: MITK, Bugzilla.
Aug 2 2016, 10:21 AM · Bugzilla, MITK
kilgus added projects to T19136: Building MITK OpenCL on Ubuntu 14.04 is super troublesome: MITK, Bugzilla.
Aug 2 2016, 10:20 AM · Bugzilla, MITK
kilgus added projects to T19115: Zooming and crosshair rotation: MITK, Bugzilla.
Aug 2 2016, 10:20 AM · Bugzilla, MITK
kilgus added a comment to T19099: 2D Streaming in mitkWorkbench/BlueBerry (?).

The Apps are pushed into:
personal/kilgus/StreamingTestApps

Aug 2 2016, 10:20 AM · Bugzilla, MITK
kilgus added a comment to T19099: 2D Streaming in mitkWorkbench/BlueBerry (?).

Closed. I explained all my findings to the MITK group on the last retreat.

Aug 2 2016, 10:20 AM · Bugzilla, MITK
kilgus added a comment to T19099: 2D Streaming in mitkWorkbench/BlueBerry (?).

To measure the FPS, I always used this code snipped:

Aug 2 2016, 10:20 AM · Bugzilla, MITK
kilgus added projects to T19099: 2D Streaming in mitkWorkbench/BlueBerry (?): MITK, Bugzilla.
Aug 2 2016, 10:20 AM · Bugzilla, MITK
kilgus added a comment to T19085: C++11 and OpenCL.

[909511]: Merge branch 'bug-19085-FixOpenCL'

Merged commits:

2015-05-20 13:28:59 Thomas Kilgus [245a8f]
Use correct macro for OclBinaryThresholdImageFilter.

Aug 2 2016, 10:20 AM · MITK (2015-03), Bugzilla
kilgus added projects to T19085: C++11 and OpenCL: MITK, Bugzilla.
Aug 2 2016, 10:20 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T19062: Loading image directly from command line while starting workbench does not load image.

If I start a second App via command line, the second one crashes instead of giving the focus to the first App.

Aug 2 2016, 10:20 AM · MITK (2016-11), Bugzilla
kilgus added a comment to T19042: Add another "jet" lookup table with transparency.

Although I did not look into the code, this should be pretty easy to implement. Did you do any work already or looked into it? Would you like to contribute it yourself? I would gladly do a code review and the merge.

Aug 2 2016, 10:20 AM · Bugzilla, MITK
kilgus added a comment to F1240: surfaceError.png.

Backface rendering of last release and current master

Aug 2 2016, 10:20 AM
kilgus added projects to T19025: Backface surface rendering is disabled: MITK, Bugzilla.
Aug 2 2016, 10:20 AM · MITK, Bugzilla
kilgus added a comment to T19025: Backface surface rendering is disabled.

Backface rendering of last release and current master

Aug 2 2016, 10:20 AM · MITK, Bugzilla
kilgus added projects to T18939: Antialiasing does not work (again): MITK, Bugzilla.
Aug 2 2016, 10:19 AM · MITK (2016-11), Bugzilla
kilgus added a comment to T18939: Antialiasing does not work (again).

This seems to be a VTK issue. I added a bug report in their Mantis bug tracker:
http://www.vtk.org/Bug/view.php?id=15433

Aug 2 2016, 10:19 AM · MITK (2016-11), Bugzilla
kilgus added a comment to T18939: Antialiasing does not work (again).

For the upcoming release (15-03) this will be declared as a known issue. Each user can temporarily fix the anti aliasing with his graphic driver settings.

Aug 2 2016, 10:19 AM · MITK (2016-11), Bugzilla
kilgus added a comment to T18939: Antialiasing does not work (again).

Bisect result:

Aug 2 2016, 10:19 AM · MITK (2016-11), Bugzilla
kilgus added a comment to T18841: vtkMitkLevelWindowFilter always treats multi component images as RGBA --> crash.

Stack trace of the crash

Aug 2 2016, 10:19 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18841: vtkMitkLevelWindowFilter always treats multi component images as RGBA --> crash.

I reproduced this bug with Peter by removing the line:

node->AddProperty("Image.Displayed Component", mitk::IntProperty::New(0), renderer, overwrite);

in mitkImageVtkMapper2D.cpp

Aug 2 2016, 10:19 AM · MITK (2015-03), Bugzilla
kilgus added a comment to F1233: stacktracebug18841.txt.

Stack trace of the crash

Aug 2 2016, 10:19 AM
kilgus added a comment to T18799: Delayed interaction due to event-loop bug in Qt5.

On which platforms does this occur? Only Arch Linux? I have no issues with Ubuntu 14.04.

Aug 2 2016, 10:19 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18762: geometry tools and igtlplugin are missing documentation and show up in top-level.

[96ce99]: Merge branch 'bug-18762-DocuGeometryTools'

Merged commits:

2015-02-24 13:02:29 Thomas Kilgus [0d7c4b]
Added docu for geometry tools plugin.

Aug 2 2016, 10:18 AM · Bugzilla, MITK
kilgus added a comment to T18762: geometry tools and igtlplugin are missing documentation and show up in top-level.

GeometryTools Plugin docu should be ok now.

Aug 2 2016, 10:18 AM · Bugzilla, MITK
kilgus added a comment to T18728: Create a Parameter Widget for Structure Sensor.

[179afe]: Merge branch 'bug-18728-FixExportMacro'

Merged commits:

2015-02-10 14:59:33 Thomas Kilgus [b47b41]
COMP: Fixed export macro.

Aug 2 2016, 10:18 AM · Bugzilla, MITK
kilgus added projects to T18728: Create a Parameter Widget for Structure Sensor: MITK, Bugzilla.
Aug 2 2016, 10:18 AM · Bugzilla, MITK
kilgus added a comment to T18728: Create a Parameter Widget for Structure Sensor.

[a2558b]: Merge branch 'bug-18728-StructureWidget'

Merged commits:

2015-02-10 10:02:41 Thomas Kilgus [65694d]
Added StructureParameterWidget.

Aug 2 2016, 10:18 AM · Bugzilla, MITK
kilgus added a comment to T18674: 2D surface mapper cannot handle empty surfaces.

I think we should add a NULL check in the Update() (e.g. if input->GetVtkPolyData() == NULL) return;), similar like the ImageVtkMapper2D does it. (I assumed there was also one in the surface mapper, but apparently there is not.)

Aug 2 2016, 10:18 AM · Bugzilla, MITK
kilgus added a comment to T18651: Remove LegacyIO dependency from PlanarFigure module.

I would like to merge this bug asap due to lots of potential for conflicts. Unfortunately, we modified the core (only mitkIOUtil).

Aug 2 2016, 10:18 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18651: Remove LegacyIO dependency from PlanarFigure module.

[b6d54e]: Merge branch 'bug-18651-RemoveLegacyIO'

Merged commits:

2015-01-29 13:12:45 Thomas Kilgus [4c2eb7]
Converted ManualSegmentationToSurfaceFilterTest to CPPUNIT and added reference data for the filter.

Aug 2 2016, 10:18 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18651: Remove LegacyIO dependency from PlanarFigure module.

On my branch the following tests still fail:

Aug 2 2016, 10:18 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18644: MITK cannot write png image.

Todo: Write a test for this feature. I remember it was broken once already and we still do not have any test.

Aug 2 2016, 10:18 AM · MITK (2015-03), Bugzilla
kilgus added projects to T18644: MITK cannot write png image: MITK, Bugzilla.
Aug 2 2016, 10:18 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18644: MITK cannot write png image.

I also tried to save Pic3D as .png. This should save everything as a set of 2D slices, however, the following occurs:

Aug 2 2016, 10:18 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18639: Default colors in preferences are different from initial default colors.

The old values are still (wrongly) set in:
void QmitkStdMultiWidgetEditorPreferencePage::Update()

Aug 2 2016, 10:18 AM · MITK, Bugzilla
kilgus added a comment to T18639: Default colors in preferences are different from initial default colors.

Very easy bug. Passing this to Andi in order to distribute it during our bugsquashing. This is a good starting bug for new people.

Aug 2 2016, 10:18 AM · MITK, Bugzilla
kilgus added a comment to T18622: mitkLookuptable get color uses int parameter instead of double.

I will take care of this.

Aug 2 2016, 10:18 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18622: mitkLookuptable get color uses int parameter instead of double.

Branch is ready to merge once the flags are set.

Aug 2 2016, 10:18 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18622: mitkLookuptable get color uses int parameter instead of double.

I changed the interface and added documentation.

Aug 2 2016, 10:18 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18622: mitkLookuptable get color uses int parameter instead of double.

[7029bd]: Merge branch 'bug-18622-FixGetValue'

Merged commits:

2015-04-08 15:47:19 Thomas Kilgus [1f2c8c]
Fixed the interface error and added documentation for the wrapper methods.

Aug 2 2016, 10:18 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18622: mitkLookuptable get color uses int parameter instead of double.

I made a mistake in my previous comment the interface is changed from:
void mitk::LookupTable::GetColor(int x, double rgba[3])
to
void mitk::LookupTable::GetColor(double x, double rgb[3])

Aug 2 2016, 10:18 AM · MITK (2015-03), Bugzilla
kilgus added projects to T18585: Synchronize ToFImageRecorder and Grabber: MITK, Bugzilla.
Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added a comment to T18585: Synchronize ToFImageRecorder and Grabber.

This is some serious issue in MITK-ToF, which never used to work. People should know that this bug exists. Passing to Eric.

Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added a comment to T18578: Surface 2D Mapper and Geometry (fun).

[e72c59]: Merge branch 'bug-18578-FixWarning'

Merged commits:

2015-01-16 10:48:41 Thomas Kilgus [3da38f]
COMP: removed unused member.

Aug 2 2016, 10:17 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18578: Surface 2D Mapper and Geometry (fun).

[90b332]: Merge branch 'bug-18578-FixWarning'

Merged commits:

2015-01-16 11:08:22 Thomas Kilgus [3fa666]
COMP: mitkSurfaceVtkMapper2DTest is only build if the cmake flag is set.

Aug 2 2016, 10:17 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18578: Surface 2D Mapper and Geometry (fun).

[68193a]: Merge branch 'bug-18578-AngleFix'

Merged commits:

2015-01-16 10:25:27 Thomas Kilgus [25425b]
Changing Ascii code to keyboard degree sign.

Aug 2 2016, 10:17 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18578: Surface 2D Mapper and Geometry (fun).

[84dd55]: Merge branch 'bug-18578-FixWarning'

Merged commits:

2015-01-16 12:11:49 Thomas Kilgus [d536ad]
COMP: Fixed UpdateVtkTransform.

Aug 2 2016, 10:17 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18578: Surface 2D Mapper and Geometry (fun).

I discovered that the PointSetVtkMapper2D has the same issues. There it is solved with a manual transformation of each point. This can be done via the UpdateVtkTransform method of VtkMapper if a vtkAssembly would be used. However, the vtkTextActors have to be replaced by some 3D actor in this case. Christoph and I will have a look at this next Wednesday.

Aug 2 2016, 10:17 AM · MITK (2015-03), Bugzilla
kilgus added projects to T18578: Surface 2D Mapper and Geometry (fun): MITK, Bugzilla.
Aug 2 2016, 10:17 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18578: Surface 2D Mapper and Geometry (fun).

The solution is explained in the core change request and in the documentation of the SurfaceVtkMapper2D.

Aug 2 2016, 10:17 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18578: Surface 2D Mapper and Geometry (fun).

I wrote a core change request and will push the solution now.

Aug 2 2016, 10:17 AM · MITK (2015-03), Bugzilla
kilgus added projects to T18574: Port naming concept Editor to QmitkStdMultiWidget: MITK, Bugzilla.
Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added a comment to T18573: Lines are not rendered smoothly anymore.

we recently switched from QVTKWidget to QVTKWidget2 and now by default anti-aliasing is disabled.

Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added a comment to T18573: Lines are not rendered smoothly anymore.

git bisect identified the following commit:

Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added a comment to T18574: Port naming concept Editor to QmitkStdMultiWidget.

Closed. Just a nice to have.

Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added projects to T18571: Convert CornerAnnotation, RectangleProp and GradientBackground to decoration concept: MITK, Bugzilla.
Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added a comment to T18571: Convert CornerAnnotation, RectangleProp and GradientBackground to decoration concept.

Closed. Just a nice to have.

Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added projects to T18564: Full Text Search for Doxygen: MITK, Bugzilla.
Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added a comment to T18533: Different lookup tables for different renderers broken (mitkImageVtkMapper2D).

This sounds like a nice add-on to me, however, that never worked, did it?

Aug 2 2016, 10:17 AM · MITK, Bugzilla
kilgus added a comment to T18533: Different lookup tables for different renderers broken (mitkImageVtkMapper2D).

Do you have any contribution regarding this?

Aug 2 2016, 10:17 AM · MITK, Bugzilla
kilgus added a comment to T18528: Hackfest: Make Core OpenGL free.

[77f574]: Merge branch 'bug-18528-UnifyStdMultiProperties'

Merged commits:

2014-12-22 13:28:29 Thomas Kilgus [7ba26c]
Even more multi widget refactoring.

Aug 2 2016, 10:17 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18528: Hackfest: Make Core OpenGL free.
  1. is done.
Aug 2 2016, 10:17 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18528: Hackfest: Make Core OpenGL free.

[77f327]: Merge branch 'bug-18528-GLMappersModule'

Merged commits:

2014-12-19 15:21:02 Thomas Kilgus [46fc06]
MultiWidget and gradientbackground refactoring.

Aug 2 2016, 10:17 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18528: Hackfest: Make Core OpenGL free.

I wrote a core change request.

Aug 2 2016, 10:17 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18528: Hackfest: Make Core OpenGL free.

mitkCoreGLfree

Aug 2 2016, 10:17 AM · MITK (2015-03), Bugzilla
kilgus added a comment to F1191: mitkCoreOpenGLFree.png.

mitkCoreGLfree

Aug 2 2016, 10:17 AM
kilgus added a comment to T18528: Hackfest: Make Core OpenGL free.

Todo:
-RenderWindowFrame uses a vtkMitkRectangleProp to render rectangles with OpenGL. Replace with VTK!

Aug 2 2016, 10:17 AM · MITK (2015-03), Bugzilla
kilgus added projects to T18528: Hackfest: Make Core OpenGL free: MITK, Bugzilla.
Aug 2 2016, 10:17 AM · MITK (2015-03), Bugzilla
kilgus added a comment to T18508: Create a geometry modification interactor and a plugin to apply the interactor.

[9f3384]: Merge branch 'bug-18508-FixTest'

Merged commits:

2015-08-19 16:45:57 Thomas Kilgus [6c4b4e]
COMP: Fixed base geometrytest.

Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added a comment to T18508: Create a geometry modification interactor and a plugin to apply the interactor.

[1fccae]: Merge branch 'bug-18508-CombineDifferentAffineInteractorIntoOne'

Merged commits:

2015-08-19 16:18:48 Thomas Kilgus [3650db]
Fixed rotation and translation in mouse mode. Rotation mode crashes for images.

Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added a comment to T18508: Create a geometry modification interactor and a plugin to apply the interactor.

Last todo's are:
-Scaling in mouse mode
-Fix crash of the rotation with images in mouse mode

Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added a comment to T18508: Create a geometry modification interactor and a plugin to apply the interactor.

Passing to Jasmin. We will try to finish this today :)!

Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added a comment to T18508: Create a geometry modification interactor and a plugin to apply the interactor.

[def5d4]: Merge branch 'bug-18508-GeoToolsIntegration'

Merged commits:

2014-12-22 14:43:44 Thomas Kilgus [9ac42e]
Cleaning up for first master merge.

Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added a comment to T18508: Create a geometry modification interactor and a plugin to apply the interactor.

Well its a feature. Check it out yourself in the plugin org.mitk.gui.qt.geometrytools. I wanted to add a little bit more stuff, but I am still not sure how to do it.

Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added a comment to T18508: Create a geometry modification interactor and a plugin to apply the interactor.

I added the following line to Core\Code\CMakeLists.txt and therefore need a core change request:

Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added projects to T18508: Create a geometry modification interactor and a plugin to apply the interactor: MITK, Bugzilla.
Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added a comment to T18508: Create a geometry modification interactor and a plugin to apply the interactor.

This bug was intended to (re)-write an interactor to modify geometry and make it accessible via a plugin for the user.

Aug 2 2016, 10:17 AM · Bugzilla, MITK
kilgus added projects to T18486: Last frames of sequential animations might be left out: MITK, Bugzilla.
Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added projects to T18423: View for saving screen shots of ToF images for calibration: MITK, Bugzilla.
Aug 2 2016, 10:16 AM · Bugzilla, MITK
kilgus added a comment to T18423: View for saving screen shots of ToF images for calibration.

[f52dba]: Merge branch 'bug-18423-ToFScreenShotMaker'

Merged commits:

2015-01-05 15:04:10 Thomas Kilgus [7257f2]
Cleaning up.

Aug 2 2016, 10:16 AM · Bugzilla, MITK
kilgus added a comment to T18405: Wrong colormap is set for images loaded as project file.

[ba1a25]: Merge branch 'bug-18405-TinyXMLPatch'

Merged commits:

2014-11-12 15:58:38 Thomas Kilgus [dd9d7a]
Added old tiny xml patch to the new patch.

Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added a comment to T18405: Wrong colormap is set for images loaded as project file.

I'm pretty sure that this related to changes in SceneIO (either reader/writer changes or compatibility changes I made a few months ago). So it's not Rendering ;).

Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added a comment to T18405: Wrong colormap is set for images loaded as project file.

I will have a look at this.

Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added projects to T18400: Statistic calculation for rotated closed planar figures: MITK, Bugzilla.
Aug 2 2016, 10:16 AM · Bugzilla, MITK
kilgus added a comment to T18384: Statistic calculation not possible for rotated closed planar figures.

[28ca1d]: Merge branch 'bug-18384-AdaptingErrorMsgForRotatedPlanarFigures'

Merged commits:

2014-11-05 16:02:05 Thomas Kilgus [9c6d27]
Adapted error message for rotated planar figure statistics.

Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added a comment to T18385: Planar figure display errors if in rotated views.

Works for me in Ubuntu 14.04 current master with two different data sets. Please re-open with detailed a description how to reproduce the bug.

Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added a comment to T18384: Statistic calculation not possible for rotated closed planar figures.

In the QmitkImageStatisticsCalculationThread there is already a concept for passing error messages from the calculating thread to the main GUI, however, it was removed in T15359 for some reason. I'm not sure if this concept can be used, so I adapt the default message to be a little more generic as quick fix from
"Planar figure is outside the images bounds."
to
"Planar figure is on a rotated image plane or outside the image bounds."

Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added a comment to T18384: Statistic calculation not possible for rotated closed planar figures.

As the feature never worked, I created a new feature request in T18400 for Andy's proposal.

Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added projects to T18350: Live wire tools has sometimes trouble on oblique slices: MITK, Bugzilla.
Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added projects to T18346: Remove console output "Got non-empty data-node: Image": MITK, Bugzilla.
Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added projects to T18336: Itk error during rigid registration: MITK, Bugzilla.
Aug 2 2016, 10:16 AM · Bugzilla, MITK
kilgus added a comment to T18337: Crash with bin size 0 in statistics.

Here is my stack trace:

Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added projects to T18337: Crash with bin size 0 in statistics: MITK, Bugzilla.
Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added a comment to T18331: "Force manifold" option crashes for many meshes.

I found more meshes on my machine where this option crashes. It works, however, with "ball.stl" from MITK-Data.

Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added projects to T18331: "Force manifold" option crashes for many meshes: MITK, Bugzilla.
Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added a comment to T18329: LiveWire does not work (no interaction after initial point) and crashes.

To be continued in T18350.

Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added a comment to T18331: "Force manifold" option crashes for many meshes.

Resolved -> Thirdparty

Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added a comment to T18329: LiveWire does not work (no interaction after initial point) and crashes.

Once this is merged, the bug here can be closed.

Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added a comment to T18331: "Force manifold" option crashes for many meshes.

Unfortunately, my QtCreator won't produce a stack trace and I don't know why.

Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla
kilgus added a comment to T18329: LiveWire does not work (no interaction after initial point) and crashes.

I pushed a simple fix for to avoid the crash. The live wire tool does still not work well on this data set.

Aug 2 2016, 10:16 AM · MITK (2014-10), Bugzilla