Page MenuHomePhabricator

Replacing PointSetInteractors with PointSetDataInteractor
Closed, ResolvedPublic

Description

Replacing all occurances of PointSetInteractors with PointSetDataInteractor.
Marking PointSetInteractors as deprecrated.

Event Timeline

User webechr has pushed new remote branch:

bug-17725-MigratePointSetInteractor

Some Interactors will not be migrated, those are marked deprecated in T17745 .

User webechr has pushed new remote branch:

bug-17725-MigratePointSetInteractor-2-DocuUpdate

To migrate QmitkPointList it is necessary to extend the PointSetDataInteractor to allow the following:

Select a point by Index (remain in this selected-by-index state),
and provide a delete-selected-index action on this state, implemented using internal events, since data interactor were not designed to be manipulated on plugin level.

Fixed PointSetInteractor
-re-enable moving of points
-support time steps

Progress update:

Implemented PointSetInteractor that deals with the case that only one single point is requested.

All PointSetInteractor uses have been migrated except the one listes in the internal progress page (which are for the most part, unused and can be removed in future releases) :

http://mitk.org/internal/MigrationInteraction

[cc3e05]: Merge branch 'bug-17725-MigratePointSetInteractor-2-DocuUpdate'

Merged commits:

2014-06-04 16:04:12 Christian Weber [02c461]
remove obsolete function in pointset data interactor


2014-06-04 15:33:31 Christian Weber [6d3feb]
implement delete point via widget directly in view


2014-05-28 17:33:56 Christian Weber [5e1822]
New PointSet Interactor to handle single points
updated adaptive region growing to new interactor


2014-05-28 14:09:21 Christian Weber [36876b]
Merge branch 'bug-17725-MigratePointSetInteractor' into bug-17725-MigratePointSetInteractor-2-DocuUpdate


2014-05-28 13:48:36 Christian Weber [cc0cef]
support different time steps with pointset interaction
move event description corrected in PointSet xml


2014-05-08 14:53:23 Christian Weber [6a37d2]
Replace Interactor - DataInteractor WIP


2014-04-30 15:47:00 Christian Weber [b932ca]
remove file only contained commented out code


2014-04-30 14:12:56 Christian Weber [501949]
Merge branch 'bug-17725-MigratePointSetInteractor' into bug-17725-MigratePointSetInteractor-2-DocuUpdate


2014-04-23 14:59:08 Christian Weber [2f8a72]
remove obsolete lines.


2014-04-16 16:02:53 Christian Weber [b6254b]
Replace the PointSetInteractor in SimpleMeasurement


2014-04-16 16:02:09 Christian Weber [7aa733]
Remove PointSetInteractor from DataNode Test

User webechr has pushed new remote branch:

bug-17725-MigratePointSetInteractor-3-Fix

[c10781]: Merge branch 'bug-17725-MigratePointSetInteractor-3-Fix'

Merged commits:

2014-06-04 18:54:37 Christian Weber [1b455e]
COMP: first add point set to datanode, else ps will be created and reference that is checked does not match actual results

[3b7d04]: Merge branch 'bug-17725-MigratePointSetInteractor-2-DocuUpdate'

Merged commits:

2014-06-05 17:20:39 Christian Weber [5ec396]
Merge branch 'bug-17725-MigratePointSetInteractor-3-Fix' into bug-17725-MigratePointSetInteractor-2-DocuUpdate

Conflicts:
Core/Code/Testing/mitkPointSetDataInteractorTest.cpp


2014-06-04 18:51:04 Christian Weber [a48022]
COMP: set point set first, because empty datanodes are filled with new point set and then testing failes
due to comparison of different point sets


2014-06-04 17:25:36 Jasmin Metzger [f139ac]
Migrated the PickingTool: Changed the PointSetInteractor to the new SinglePointDataInteractor

Re-Opening this bug, to add some documentation on how to use point-sets with PointSetDataInteractor

User webechr has pushed new remote branch:

bug-17725-AddInteractorDocu

[32b73f]: Merge branch 'bug-17725-AddInteractorDocu'

Merged commits:

2014-06-18 14:23:58 Christian Weber [ad6772]
add documentation about in which order point sets are added to data nodes,
which in turn are used in PointSetDataInteractors to avoid side effects


2014-06-18 14:23:22 Christian Weber [276544]
uncomment input parameter to silence warning

User webechr has pushed new remote branch:

bug-17725-UpdatePointSetXML

[d72b67]: Merge branch 'bug-17725-UpdatePointSetXML'

Merged commits:

2014-06-18 14:32:25 Christian Weber [aa52a4]
removed no longer used update action from XML, which caused warnings when using the new interactor

Extended documentation of PointSetDataInteractor to adress an usage issue that came up with the updates.
Also remove the update action from the Interaction xml, as this action became obsolte and therefore produces warnings.