Page MenuHomePhabricator

ImageDataItem has 4D support which leads to crashes in some filters
Closed, ResolvedPublic

Description

The test fails with the current MITK/MBI version and remains inactive until fixed.

Event Timeline

The bug may be related to the geometry redesign, but further investigation is necessary.

When running the test, the ExtractSlicesFilter returns a NULL pointer (see mitkSliceData.cpp #257)

User lichtenn has pushed new remote branch:

bug-18084-MItralAnnulusOptimizerTestFails

[56fe74]: COMP Merge branch 'bug-18084-MItralAnnulusOptimizerTestFails'

Merged commits:

2014-09-11 13:40:26 Nils Lichtenberg [3a0624]
Deactivated MitralAnnulusOptimizerTest

Problem is probably related to TimeGeometry changes (bug-17209).

mitk::Image::GetSlicedGeometry returns NULL for timesteps != 0.
(mitk::imageDataItem #233, mitk::SlicedData #250)

The AnnulusOptimizer fails during the AnnulusOptimizerTest only, not by usage with the workbench.

Further investigation revealed that mitk::Image::GetSlicedGeometry returns NULL for timesteps that are != 0 or have not been viewed/rendered before.

TODO:
Check ImageNavigator's time slider -> what happens when showing timesteps >0 ?
(Initialization of geometry?)

Deactivation of MitralAnnulusOptimizer Test

After writing an MITK test, we are sure that this is bug in MITK geometry.

User lichtenn has pushed new remote branch:

bug-18084-Geometry_not_initialized_properly_on_4DImages

(In reply to Git Admin from comment #8)

User lichtenn has pushed new remote branch:

bug-18084-Geometry_not_initialized_properly_on_4DImages

Test name: mitkSliceTest
The image loaded in this test is hardcoded, edit the path to a valid 3D+t image to run the test correctly.

ImageTimeSelector seems to use a direct reference on the relevant ImageDataItem (volume or slice) instead of using an additional ImageDataItem.

This can lead to problems concerning the corresponding image with 4D images regarding geometry and object destruction.

User engelhsa has pushed new remote branch:

bug-18084-Integration-Branch-SliceTest-4D

I removed the MITK_INFO output to console from the core classes that we introduce before committing the code.

Further steps to do are

  1. to add adequate input parameters to the test (still hard coded); a suitable image in MITK_DATA must be identified or the current TEE dicom data set must be made anonymous.
  2. implement test conditions
  3. renaming the test?

A new ultrasound image example has been added to MITK-Data (.../MITK-Data/UltrasoundImages/4D_TEE_Data_MitralValve.dcm and the MITK-Data-Hashtag has been updated.

This image can be used for the test.

User engelhsa has pushed new remote branch:

bug-18084-ImageDataItem-MITKUsersMeeting

User engelhsa has pushed new remote branch:

bug-18084-IntegrationBranchBeforeNewRelease

[722112]: Merge branch 'bug-18084-IntegrationBranchBeforeNewRelease'

Merged commits:

2015-05-20 17:00:04 Sandy Engelhardt [dad2a1]
Add test condition to test


2015-05-20 16:11:35 Sandy Engelhardt [61c754]
Update input for RotatedSlice4DTest


2015-05-20 16:10:25 Sandy Engelhardt [905abb]
Set Manage Memory to false for enabling ImageTimeSelectorTests


2015-05-13 15:46:52 Sandy Engelhardt [e5b3f5]
Merge remote-tracking branch 'origin/bug-18084-ImageDataItem-MITKUsersMeeting' into bug-18084-IntegrationBranchBeforeNewRelease

Conflicts:
Modules/Core/include/mitkImageDataItem.h
Modules/Core/src/DataManagement/mitkImageDataItem.cpp


2015-04-25 12:42:06 Sandy Engelhardt [0019ee]
Merge branch 'bug-18084-ImageDataItem-Integration' into bug-18084-ImageDataItem-MITKUsersMeeting


2015-04-16 13:05:26 Sandy Engelhardt [dd7511]
Merge remote-tracking branch 'origin/bug-18084-Integration-Branch-SliceTest-4D' into bug-18084-ImageDataItem-Integration


2015-04-15 17:52:30 Sandy Engelhardt [e4e31d]
fix timestep-related ImageDataItem issue

Has been integrated into 2015.05.02