Page MenuHomePhabricator

Small code improvements
Closed, ResolvedPublic

Description

Fix some warnings about non-existent include directories and unused variables

Event Timeline

User nolden has pushed new remote branch:

bug-18113-small-code-fixes

[593a3a]: Merge branch 'bug-18113-small-code-fixes'

Merged commits:

2014-09-17 16:11:59 Marco Nolden [cc9aa3]
Removed some non-existent directories from include dir lists


2014-09-17 16:11:20 Marco Nolden [7d35fc]
Catch exceptions in tests by const reference


2014-09-17 16:10:42 Marco Nolden [5e59af]
Missing initialization


2014-09-17 16:10:26 Marco Nolden [5da621]
Fix test methods that are not using argc/argv


2014-09-17 16:09:26 Marco Nolden [d1351a]
API fix: DataStorage cannot be stored in selection boxes anymore

[879527]: Merge branch 'bug-18113-small-code-fixes'

Merged commits:

2014-09-17 22:54:25 Marco Nolden [e9831a]
COMP: test main method signature


2014-09-17 22:26:32 Marco Nolden [9b9ba0]
COMP: fix unused catched exception references causing warnings


2014-09-17 22:25:18 Marco Nolden [fe8ca9]
COMP: variables weren't unused

Can I add a few small patches into this bug?

Pull request: https://github.com/MITK/MITK/pull/89

[6dfe41]: Merge branch 'bug-18113-small-code-improvements-tbj'

Merged commits:

2014-10-31 14:45:33 Sascha Zelzer [5b19ec]
Add used typedef again.


2014-10-31 14:16:17 Sascha Zelzer [4532d9]
Check if file exists before including it.


2014-08-30 20:46:24 Taylor Braun-Jones [8dea7b]
Fix missing and incorrect copyright header

Signed-off-by: Taylor Braun-Jones <taylor.braun-jones@ge.com>


2014-08-12 09:04:03 Taylor Braun-Jones [9e425a]
Minor changes to simplify implementation of mitkPropertyList

Signed-off-by: Taylor Braun-Jones <taylor.braun-jones@ge.com>


2014-05-23 19:28:42 Taylor Braun-Jones [30d78b]
Only include ToF hardware install rules if MitkToFHardware module is enabled

Signed-off-by: Taylor Braun-Jones <taylor.braun-jones@ge.com>


2014-09-12 19:21:19 Taylor Braun-Jones [216a51]
Cleanup logic in BaseRenderer

Signed-off-by: Taylor Braun-Jones <taylor.braun-jones@ge.com>

Sascha, Marco: What is the status of this bug? Can it be closed for the upcoming release?