Page MenuHomePhabricator
Create Task
Maniphest T18176

mitk::NavigationData uses Clone() method which is not correctly implemented yet
Closed, ResolvedPublic
Actions

Description

Because this class is quite old, mitk::NavigationData has a Graft() method instead of a Clone() method.

However, the method GetInverse() of NavigationData uses the Clone() method derived by ITK which leads to unexpected behaviour when calling the method GetInverse().

So:

  1. Extend the test of NavigationData to detect this problem.
  1. Implement the Clone() method for convenience reasons. This should be easy using the existing graft method.
  1. Fix the current use of the Clone() method.

Event Timeline

franza added projects: MITK, Bugzilla.Oct 6 2014, 4:41 PM
• git-user added a subscriber: • git-user.Oct 6 2014, 5:46 PM

User franza has pushed new remote branch:

bug-18176-CloneMethodNavigationData
franza added a subscriber: franza.Oct 6 2014, 5:48 PM

Clone method was already there but a test was missing and the call was wrong anyway.

Fixed this in the last branch. Also added a equals method for navigation data. Ready to merge...

franza added a comment.Oct 21 2014, 12:54 PM

Was merged to the master in T18182, so closing this bug.

kislinsk edited projects, added MITK (2014-10); removed MITK.Aug 1 2016, 10:49 PM
MITK · MIC · IMSY · DKFZ