Page MenuHomePhabricator

Perspective state is not saved upon closing the perspective
Closed, WontfixPublic

Description

Open a perspective and add a view to it. Close this perspective and reopen it. The changes made to the perspective by adding the view are lost.

This is not bug caused by the view navigator but became apparent using it.

Event Timeline

We might want to discuss whether the state of a perspective should be saved to disk upon closing.

This sounds weird because perspective changes are saved by default. Maybe the application was started again with /BlueBerry.clean?

You do not even need to restart the application. Neither do you need the view navigator.

To reproduce:

  1. Start application
  2. Open any perspective using Window->Open Perspective
  3. Move a view in the perspective around or open a new view
  4. Close the perspective using Window->Close Perspective
  5. Reopen the perspective using Window->Open Perspective

-> Your changes of step 3 are lost

I am *very* sure that this used to work. Need to verify this with the 2014.03 release (installer).

I researched this a little bit. Explicitly closing the perspective in the menu also resets it. You need to do "Save as..." for the perspective to store its meta-data in a new custom perspective.

http://stackoverflow.com/questions/10475625/can-a-perspective-be-closed-in-eclipse-without-its-layout-being-reset

Given that there is already a reset button I think we might want to change the behaviour of our close button to do a save as instead of a close.

Given that we have both "Close" and "Save As..." actions in the workbench, I would not change anything here ;-)

Personally I would expect the following behaviour:

  • Reset

Perspective is reset to factory default

  • Close

Perspective is closed and will be reopened with the same state it is in at the time of closing (similar to just closing and reopening the application)

  • Save As

Save the current state as a different perspective, reset the original one to factory default (or even better, last saved state)

kislinsk claimed this task.
kislinsk added a project: Auto-closed.
kislinsk added a subscriber: kislinsk.

Hi there! 🙂

This task was auto-closed according to our Task Lifecycle Management.
Please follow this link for more information and don't forget that you are encouraged to reasonable re-open tasks to revive them. 🚑

Best wishes,
The MITK devs

kislinsk removed kislinsk as the assignee of this task.May 26 2020, 12:05 PM
kislinsk removed a subscriber: kislinsk.