Page MenuHomePhabricator
Create Task
Maniphest T18428

Statistics tool has problem with values "close" to 0 (crash and mutliple other bugs).
Closed, ResolvedPublic
Actions

Description

  1. Load the attached image, which contains very small values (-0.00005 - 0.00008).
  2. Open statistics plugin and select the image.
  3. Statistics are calculated, but x-axis looks weird (units: -0.05m?) -> BUG?
  4. Deselect "Use default bin size." checkbox and click into Bin size field.
  5. Click away to get another arbitary element the focus -> The Histogram vanishes. -> T6. Click into the Bin size field again
  6. Try to enter a value smaller than 1: Not possible (no comma values possible) -> T8. Give focus to another field again after changing the value in the Bin size field -> crash -> BUG

It's weird that a histogram is displayed in the beginning, as the bin size has to be substantially smaller than 1.

Event Timeline

• wirkert added projects: MITK, Bugzilla.Nov 19 2014, 2:50 PM
• wirkert added a subscriber: • wirkert.Nov 19 2014, 2:53 PM

Attachement was too big, instead put the picture into:
/E130-Daten/Bilddaten/Bugs Testdata/T18428

• wirkert added a comment.Nov 19 2014, 4:27 PM

This is e.g. relevant then analysing images with probabilites as pixelvalues (between 0-1). Reproduced the bug on one of those.

• git-user added a subscriber: • git-user.Jan 14 2015, 4:38 PM

User wirkert has pushed new remote branch:

bug-18428-enable_statistics_for_probabilities
• wirkert added a comment.Feb 11 2015, 3:36 PM

[146142]: Merge branch 'bug-18428-enable_statistics_for_probabilities'

Merged commits:

2015-02-11 14:59:34 Sebastian Wirkert [812848]
Removed bin size passing to java script, didn't work. Will push this version.
One bug still remaining: if histogram is only one bin big, the histogram will vanish.
Couldn't fix this because I didn't understand the intricacies of the JS code.
Very weird: in these cases, the histogram seams to be of length 0 (length 1 expected).

2015-02-03 14:42:46 Sebastian Wirkert [03a10e]
may be reverted again: try to pass bin size of histogram. Doesn't work right
now.

2015-01-21 15:32:04 Sebastian Wirkert [039c6b]
Enabled entering bin sizes with decimals.
To discuss: would it be better to enter number of bins instead of bin size.

2015-01-14 16:59:07 Sebastian Wirkert [d4be28]
encapsulated number of bin calculation in function since it is used two times.

2015-01-14 16:31:25 Sebastian Wirkert [a0e0a8]
Calculation of numberOfBins yielded 0 if bin size was bigger than range of the values
for the histogram. Corrected the calculation.

• wirkert added a comment.Mar 31 2015, 4:26 PM

The bug concerning the comma values was fixed. What remains is the bug concerning the crash when too many histogram bins are created.

• wirkert added a comment.Nov 27 2015, 3:05 PM

Will close this bug and opened bug for the not yet resolved issues:
bug-19453

kislinsk edited projects, added MITK (2016-11); removed MITK.Aug 1 2016, 10:49 PM
MITK · MIC · IMSY · DKFZ